Discussion of NodeBB Updates
-
@abarker I think I needed to refresh. Now they say "Flag 79 has been assigned to you." etc
-
@boomzilla ha! For once, en-us wins!
![0_1494369784605_upload-1c4ab4e1-de64-4325-adf6-e2c7982a7267](Uploading 100%)
![0_1494369791736_upload-e3390d28-36e6-46a9-9629-158933ce14d5](Uploading 100%)
error invalid file type...
![0_1494369818924_upload-d698a34a-9814-4b10-9e89-c1e304373535](Uploading 100%)
-
Hooray for consistency.
-
@ben_lubar image uploads are broken
-
@Yamikuronue Nah, just needed a refresh. Also, I had to refresh before I could paste a screenshot.
-
![0_1494369850823_1cbe18ba-5340-4995-bb6a-eb83b518ba8e-undefined](Uploading 100%)
still invalid after refresh. I paste into paint, then copy the section I want from there-- is taht the issue?
-
The console thinks we have had 150 flags today
-
@Yamikuronue Must be an artifact of the upgrade, because the created timestamps in the list obviously disagrees.
-
Is the 'reply to' indicator tiny for everyone else?
I swear it used to be bigger…
-
@RaceProUK said in Discussion of NodeBB Updates:
Is the 'reply to' indicator tiny for everyone else?
Yes.
@RaceProUK said in Discussion of NodeBB Updates:
I swear it used to be bigger…
So do I.
-
@abarker I may be imagining this, but I think the font size in general is slightly smaller too?
-
@Yamikuronue said in Discussion of NodeBB Updates:
I paste into paint, then copy the section I want from there-- is taht the issue?
Dunno...I typically do a rectangular selection with KSnapshot, click the copy button and then paste.
-
@boomzilla I do the same with Windows' Snipping Tool, and have no problems
-
@RaceProUK said in Discussion of NodeBB Updates:
Is the 'reply to' indicator tiny for everyone else?
I swear it used to be bigger…
It used to be readable...
Edit: now it's readable but only on hover (mouse cursor not shown in capture):
-
@ben_lubar said in Discussion of NodeBB Updates:
@JBert said in Discussion of NodeBB Updates:
@ben_lubar
Ehr... That's happening on a backup of our DB, right?Yes. On australium, which is a server in my basement.
Don't you already live in a basement?
So your basement has a basement?
-
@Yamikuronue said in Discussion of NodeBB Updates:
The console thinks we have had 150 flags today
Goddamnit Fox...
-
@boomzilla said in Discussion of NodeBB Updates:
@Yamikuronue Must be an artifact of the upgrade, because the created timestamps in the list obviously disagrees.
The update did two stupid things:
- Re-flagged all posts that were already flagged and then resolved the flags the same way they were already resolved.
- Changed our file type whitelist to "png, bmp, jpg" which is great because there was already a file type whitelist setting that we had set to "anything".
-
Is it just me or is infiniscroll broken? (INB4 "broken by definition") Now, when I scroll to the top or bottom of the currently loaded posts, it seems like the new posts are loaded and the current posts are immediately unloaded from the page as evidenced by the scrollbar slider jumping between the top and bottom of the window. This makes it impossible to read posts on the border of these transitions. This is happening on Linux and Windows desktops with Firefox and IE.
-
Status: Getting a really weird case of jellypotato in Here. NFC what happening to the infiniscroll logic, but I can no longer scroll the screen properly so .
-
@MZH said in Discussion of NodeBB Updates:
Is it just me
It's not just you then! OMG I thought I was going insane or something...
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
Status: Getting a really weird case of jellypotato in Here. NFC what happening to the infiniscroll logic, but I can no longer scroll the screen properly so .
Me too. It keeps jumping between post 1700 and 1711 in an infinite loop. Interestingly enough the codethulu post keeps showing up mid-screen. Maybe they've got something to do with it.
-
So the notifications page now paginates instead of infiniscrolling.
I'm just not sure how I configure the number of topics per page.
-
@ben_lubar said in Discussion of NodeBB Updates:
@JBert said in Discussion of NodeBB Updates:
@ben_lubar
Ehr... That's happening on a backup of our DB, right?Yes. On australium, which is a server in my basement.
Just don't let the enemy take it!
-
@MZH
I'm also having a lot of problems with entering topics several "pages" back from my last read position on iOS/safari mobile. Had a few 5 or 10 like notifications, went ahead and clicked on them to load that post and clear the notification, infinite jellypotato until I got sick of it and hit "go to end of thread"
-
@MZH said in Discussion of NodeBB Updates:
Is it just me or is infiniscroll broken?
My paginated view is still working.
-
@Zecc said in Discussion of NodeBB Updates:
So the notifications page now paginates instead of infiniscrolling.
I'm just not sure how I configure the number of topics per page.No, you just can't see the notifications that filtered out.
-
@MZH said in Discussion of NodeBB Updates:
Is it just me or is infiniscroll broken? (INB4 "broken by definition") Now, when I scroll to the top or bottom of the currently loaded posts, it seems like the new posts are loaded and the current posts are immediately unloaded from the page as evidenced by the scrollbar slider jumping between the top and bottom of the window. This makes it impossible to read posts on the border of these transitions. This is happening on Linux and Windows desktops with Firefox and IE.
I noticed it in this topic when I got jellypotatoed up to post 1127, and it went back and forth between that and 1140 (with the topic header and no posts above it). Also, RIP "Replies" indicator
-
The editor that worked fine before is now sluggish on Android.
-
Editor still shitty on iOS. News at 11.
-
I made a bookmarklet to show the replies indicator:
javascript:(function(){var m=document.getElementsByClassName('threaded-replies hidden'); for (var i=m.length; i--;){m[i].className = m[i].className.replace('hidden','')}})();
Unfortunately it unhides it for every post, not just ones with replies, and the content of the indicator is f'd. But still, better than nothing, and lets you see the replies when there are any.
-
What did this update do, anyway? Aside from breaking infini-scroll and replies indicator?
-
@hungrier said in Discussion of NodeBB Updates:
What did this update do, anyway? Aside from breaking infini-scroll and replies indicator?
And uploads. It broke those also.
-
@Polygeekery said in Discussion of NodeBB Updates:
@hungrier said in Discussion of NodeBB Updates:
What did this update do, anyway? Aside from breaking infini-scroll and replies indicator?
And uploads. It broke those also.
And in reply to
-
@Polygeekery
![0_1494424238356_1a9d7f11-61f0-49ed-9be2-d3e3d6006765-undefined](Uploading 100%)Oh, wonderful.
-
@hungrier did you get the nifty "Invalid File Type" error?
-
@Polygeekery Yeah. I'd've posted a screenshot, but you know
-
@hungrier I remember when we used to harangue the DiscoDevs for not doing the most basic of testing. Those were the days...
-
@hungrier Try a hard refresh and upload again? You may have some old scripts in the cache.
-
@RaceProUK Did Ctrl+Shift+R, with devtools open and "disable cache" checked. Let's see if it works
![0_1494424698827_199c9a78-bb70-42bb-a794-1404b47aa312-undefined](Uploading 100%)
Nope, still the same.
-
@hungrier said in Discussion of NodeBB Updates:
I made a bookmarklet to show the replies indicator:
javascript:(function(){var m=document.getElementsByClassName('threaded-replies hidden'); for (var i=m.length; i--;){m[i].className = m[i].className.replace('hidden','')}})();
Unfortunately it unhides it for every post, not just ones with replies, and the content of the indicator is f'd. But still, better than nothing, and lets you see the replies when there are any.
...wait, what the hell? Why is the reply indicator gone?!
-
@hungrier Hmm...
Dragon Drop
Copy Pasta
Amy Nation
All working for me, so not sure what the issue is.
-
Version 57.0.2987.133
Nearly up to date! Relaunch Google Chrome to finish updating.
RelaunchLet's see if this will fix it
-
Looks like it works now with 58.0.3029.110 (64-bit)
-
@anotherusername said in Discussion of NodeBB Updates:
@Zecc said in Discussion of NodeBB Updates:
So the notifications page now paginates instead of infiniscrolling.
I'm just not sure how I configure the number of topics per page.No, you just can't see the notifications that filtered out.
That might explain while page sizes are all over the place, but it does not explain why it stopped infiniscrolling. I want my infiniscrollable notifications back. It's already irritating enough that notifications of unread replies in a given topic don't merge.
-
Oh god... I think I just found another information leak. Please hold...
edit: as in, the same information leak that I've found previously, just in a different place now.
-
Well one thing I've noticed, the "X out of Y" indicator in the upper right actually updates Y as new posts are streamed in instead of only setting it when the thread loads. Or was that added in one of the previous updates?
-
@hungrier alright, this.
javascript: (function (e) { $(window).on('action:topic.loaded', e); $(window).on('action:posts.loaded', e); socket.on('event:new_post', function (p) { p.posts.forEach(function (o) { if (o.toPid) e(o.toPid) }) }); e() })(function (i) { require(['translator'], function (T) { T.translate('[[topic:replies_to_this_post,\40]]', function (t) { [].forEach.call(document.querySelectorAll(i == +i ? '[data-pid="' + i + '"]' : '[data-pid]'), function (p, r) { if (r = p.querySelector(i == +i ? '.threaded-replies.hidden' : '.threaded-replies')) { socket.emit('posts.getReplies', p.getAttribute('data-pid'), function (n, a) { if (!n && a.length) { r.classList.remove('hidden'); r.querySelector('.replies-count').innerText = t.trim() + ':\40' + a.length; r.querySelector('.replies-last').classList.add('hidden') } }) } }) }) }) })
To bookmarklet, just remove all whitespace (I made sure that none of it is syntactically necessary).
edit: improved version, also cross-posted in the Stylish/userscript thread.
-
Well, apparently it doesn't trigger an update when you post a reply, but that's just a minor detail...
I wonder if it will, if the reply streams onto the same page? Probably...
edit: yes, but then it results in "NaN Replies: 1" instead of "Replies: 1". Don't ask me why.
edit 2: improved version coming soon
-
@anotherusername test
-
@anotherusername 'nuther test