Discussion of NodeBB Updates
-
@hungrier said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- Removed FontAwesome images.
- Added FontAwesome emoji that turn into little boxes when you copy them but should load a lot faster because they share resources with the font NodeBB already loads.
Are you sure this shit works at all?
Boxes look fine to me!
-
@hungrier try doing a hard refresh on https://what.thedailywtf.com/plugins/nodebb-plugin-emoji/emoji/styles.css
@PitaJ why does this not have a cache buster?
-
@hungrier said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- Removed FontAwesome images.
- Added FontAwesome emoji that turn into little boxes when you copy them but should load a lot faster because they share resources with the font NodeBB already loads.
Are you sure this shit works at all?Seems to work fine?
-
@jbert It wasn't working for me until I manually refreshed the css.
-
@ben_lubar said in NodeBB Updates:
- Added FontAwesome emoji that turn into little boxes when you copy them
That could be fixed, you realize? You'd need to use a
@font-face
declaration for a customfont-family
withunicode-range
specified to grab the regular characters from Roboto, and another@font-face
declaration for thatfont-family
withunicode-range
set to grab the emoji characters from FontAwesome. Something like:[component="post"] .content, .composer .write-preview-container { font-family: "Roboto-Emoji",Roboto,"Helvetica Neue",Helvetica,Arial,sans-serif !important; } @font-face { font-family: "Roboto-Emoji"; font-style: normal; font-weight: 400; src: local("Roboto"), local("Roboto-Regular"), url("https://fonts.gstatic.com/s/roboto/v18/KFOmCnqEu92Fr1Mu4mxK.woff2") format("woff2"); unicode-range: U+0-FF, U+131, U+152-153, U+2BB-2BC, U+2C6, U+2DA, U+2DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD; } @font-face { font-family: "Roboto-Emoji"; font-style: normal; font-weight: 400; src: url("/vendor/fontawesome/fonts/fontawesome-webfont.eot?#iefix&v=4.7.0") format("embedded-opentype"), url("/vendor/fontawesome/fonts/fontawesome-webfont.woff2?v=4.7.0") format("woff2"), url("/vendor/fontawesome/fonts/fontawesome-webfont.woff?v=4.7.0") format("woff"), url("/vendor/fontawesome/fonts/fontawesome-webfont.ttf?v=4.7.0") format("truetype"), url("/vendor/fontawesome/fonts/fontawesome-webfont.svg?v=4.7.0#fontawesomeregular") format("svg"); unicode-range: U+E000-F8FF; }
The only problem is, without a container to set the font size, they'll render at the same font size as the rest of the text:
To fix that, you'd need to wrap them in a span so that the CSS could target them properly and set the
font-size
. This could be done either server-side when baking the post/preview (preferably), or (less ideally) it could be done client-side in JS when actually rendering them (or as aMutationObserver
).Or... you could just translate them to a span with the FontAwesome style... but they'd still look like little boxes in the composer text area then.
-
@ben_lubar said in Discussion of NodeBB Updates:
why does this not have a cache buster?
Cache invalidation is the hardest problem in programming.
. . .
Well, that and naming things (like "cache invalidator/buster").
. . .
. . .
Oh, and off-by-one errors.
(Let me come in again.)
-
@djls45 It's usually told as "there are two truly hard things in programming: ...", the final and third being off-by-one errors.
I didn't expect this imprecision.
-
-
@jbert
Are you claiming to be from Spain? Because no one expects the Spanish imprecision...
-
why does this not have a cache buster?
Fixed in
nodebb-plugin-emoji@2.1.2
It looks to me like your emoji plugin isn't actually updated.
Evidence:
-
https://what.thedailywtf.com/assets/src/modules/emoji.js
ctrl+f "fuse"
Might want to double check this stuff because it doesn't look right.
-
@pitaj https://hub.docker.com/r/boomzillawtf/tdwtf/builds/bmzkrhrhyaqqlgbvrbqscdw/ ctrl+f "nodebb-plugin-emoji@2.1.1"
-
@jbert Precision errors are the 4.007th hard thing.
-
@pitaj on the staging server:
root@dc5f0451b8cb:/usr/src/app# npm install --save nodebb-plugin-emoji@2.1.2 + nodebb-plugin-emoji@2.1.2 removed 1 package and updated 1 package in 7.287s root@dc5f0451b8cb:/usr/src/app# grep '"nodebb-plugin-emoji"' package.json "nodebb-plugin-emoji": "^2.1.2", root@dc5f0451b8cb:/usr/src/app# ./nodebb upgrade &> /dev/null root@dc5f0451b8cb:/usr/src/app# grep '"nodebb-plugin-emoji"' package.json "nodebb-plugin-emoji": "2.0.9",
-
@pie_flavor said in Discussion of NodeBB Updates:
Jeff's thoughts
-
@ben_lubar My bad, thought you were pulling master, you need this commit: https://github.com/NodeBB/NodeBB/commit/d7722de21090e5dce31631b45ff130b56806e007
-
What about the dropdown menu that always goes off the bottom of the screen? After a couple minutes of searching I've found that it's using this plugin: textcomplete which is apparently deprecated and should be replaced with this one: textcomplete. The newer one has a demo of it popping up, so it should be perfect, but maybe even the old one has that feature.
-
@pitaj said in Discussion of NodeBB Updates:
you were pulling master
Eventually the burnination hurt too bad, even for us...
-
@hungrier As mentioned elsewhere the dropdown thing isn't implemented by the emoji plugin, but instead by the composer. I have, however, fixed it and whether @ben_lubar decides to pull in that patch immediately or wait for a new NodeBB version including it is up to him.
-
@ben_lubar said in Discussion of NodeBB Updates:
@hungrier try doing a hard refresh on https://what.thedailywtf.com/plugins/nodebb-plugin-emoji/emoji/styles.css
@PitaJ why does this not have a cache buster?
Doesn't seem to matter. After doing that and getting the extra lines I'm still getting boxes:
@hungrier said in Discussion of NodeBB Updates:
-
@boomzilla they'll be boxes if you copy and paste, but they should show up correctly if you type
:fa_
and then look at the autocomplete results.
-
@ben_lubar Yes, of course it works by typing in the emoji.
-
@ben_lubar said in NodeBB Updates:
- Cleared persistent post cache because of the new method of
fa_*
emojis. - Added @PitaJ's composer patch that fixes autocomplete appearing off-screen.
Oh? Let's see... :tro
7/10, still doesn't match exact prefix first...
- Cleared persistent post cache because of the new method of
-
@tsaukpaetra said in Discussion of NodeBB Updates:
7/10, still doesn't match exact prefix first...
I could give a fuck less about that. What I would like to be able to do is type a colon and hit Enter without getting :
Sweet jumping Jesus. They fucking fixed that. Will wonders never cease?
Now I feel really bad about all the kittens I murdered in a fit of rage in order to spite @ben_lubar
-
@polygeekery said in Discussion of NodeBB Updates:
Sweet jumping Jesus. They fucking fixed that. Will wonders never cease?
@ben_lubar said in NodeBB Updates:
- Fixed typing a colon and pressing enter inserting an emoji instead of a colon followed by a line break
-
@polygeekery said in Discussion of NodeBB Updates:
I feel really bad
-
@anotherusername what do I look like? The type of person who reads release notes?
-
@tsaukpaetra I'm actually working on that right now. If you can find more examples post them in the relevant topic, mention me, and I'll take a look.
-
@polygeekery said in Discussion of NodeBB Updates:
Now I feel really bad about all the kittens I murdered in a fit of rage in order to spite @ben_lubar
Don't worry about it; you can bank them as credit against the 15 bugs this bugfix certainly introduced.
-
@lorne-kates I better get busy. I like having a high balance in the bank.
-
@polygeekery said in Discussion of NodeBB Updates:
@lorne-kates I better get busy. I like having a high balance in the bank.
So does your bank.
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@lorne-kates I better get busy. I like having a high balance in the bank.
So does your bank.
He's talking about murdering more kittens.
-
@pie_flavor said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@lorne-kates I better get busy. I like having a high balance in the bank.
So does your bank.
He's talking about murdering more kittens.
And I was talking about that sweet sweet bounty that will accrue.
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@lorne-kates I better get busy. I like having a high balance in the bank.
So does your bank.
He's talking about murdering more kittens.
And I was talking about that sweet sweet bounty that will accrue.
The market for kitten pelts is not as lucrative as you would think.
-
@polygeekery
Easy solution: launch DedKittehCoin
-
@izzion said in Discussion of NodeBB Updates:
@polygeekery
Easy solution: launch DedKittehCoinYou sir are a genius and a prophet.
-
@ben_lubar said in NodeBB Updates:
- Added @PitaJ's composer patch that fixes autocomplete appearing off-screen.
I... how... what??? Finally? I can't believe it... yes!
Thanks guys. Now I can waste more time discovering all the wonderful emojis we have.
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
I feel really bad
Though?
-
@zecc Let the guilt flow tough yo
-
@zecc said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
I feel really bad
Though?
Oh dear, my keyboard seems to be getting worse...
-
@tsaukpaetra Filed under: Laugh as yep
-
@hungrier said in Discussion of NodeBB Updates:
@tsaukpaetra Filed under: Laugh as yep
An, that one was from my other keyboard...
-
@tsaukpaetra
Blame the rat chewing on the cables.
-
@ben_lubar said in Discussion of NodeBB Updates:
Anyone who doesn't know why "I wrote a parser for [language] in regular expressions" doesn't make sense is not qualified to write a parser for any language.
Obligatory:
-
@izzion said in Discussion of NodeBB Updates:
@tsaukpaetra
Blame the rat chewing on the cables.*shudders* That is not a good thought...
-
-
-
It's in
develop
at the moment. I do know of at least one issue, in that it might muck around with post cache and unintentionally save old versions of posts in the cache. That's not good. Probably don't deploy this here yet.
-
@julianlam said in Discussion of NodeBB Updates:
It's in
develop
at the moment. I do know of at least one issue, in that it might muck around with post cache and unintentionally save old versions of posts in the cache. That's not good. Probably don't deploy this here yet.When it gets released, please add a database upgrade script so I can remove the plugin and not have two competing post diff systems.
-
@Tsaukpaetra does this repro the bug you were talking about (here)?
-
@anotherusername Yes.