Discussion of NodeBB Updates
-
@zecc Did you try making your zoom level 13% less?
-
@hungrier No, but I've tried deleting all my custom CSS (no effect).
I did try changing the zoom level, to no interesting result.Changing to any theme but the one I happen to use fixes this.
Changing back... makes it wrong again. It's a conspiracy.
-
Yep, "Superhero" is broken for whatever reason. I'm changing to "Darkly" till I get the patience to figure out what's the cause.
-
@zecc You should use Slate, all the cool kids are doing it
-
@hungrier said in Discussion of NodeBB Updates:
@zecc You should use Slate, all the cool kids are doing it
#SlatePitch
-
This probably isn't a good scientific way to do this, but I put my test version of this forum on PostgreSQL and timed a local HTTP GET of the front page:
ben@australium:~$ time curl https://discourse.local.lubar.me/ &> /dev/null real 0m0.389s user 0m0.084s sys 0m0.024s root@what:~# time curl https://what.thedailywtf.com/ &> /dev/null real 0m0.497s user 0m0.108s sys 0m0.012s
If we subtract user- and kernel-space time, we get 0.281 seconds of waiting on PostgreSQL and 0.377 seconds on MongoDB. And that's with a real server with 32GB of RAM running MongoDB and a repurposed Core 2 Duo desktop machine with a tenth of that RAM running PostgreSQL. Again, probably not a good indicator, but... wow.
-
@ben_lubar said in Discussion of NodeBB Updates:
This probably isn't a good scientific way to do this, but I put my test version of this forum on PostgreSQL and timed a local HTTP GET of the front page:
ben@australium:~$ time curl https://discourse.local.lubar.me/ &> /dev/null real 0m0.389s user 0m0.084s sys 0m0.024s root@what:~# time curl https://what.thedailywtf.com/ &> /dev/null real 0m0.497s user 0m0.108s sys 0m0.012s
If we subtract user- and kernel-space time, we get 0.281 seconds of waiting on PostgreSQL and 0.377 seconds on MongoDB. And that's with a real server with 32GB of RAM running MongoDB and a repurposed Core 2 Duo desktop machine with a tenth of that RAM running PostgreSQL. Again, probably not a good indicator, but... wow.
If anyone wants to try this at home, the only change I made to the current version of the Dockerfile is this:
diff --git a/Dockerfile b/Dockerfile index 0f8811e..1356384 100644 --- a/Dockerfile +++ b/Dockerfile @@ -10,6 +10,10 @@ ENV NODE_ENV=production \ RUN sed -e "s/var mediumMin = \\([0-9]\\+\\);/var mediumMin = !window.localStorage['unresponsive-settings'] || JSON.parse(window.localStorage['unresponsive-settings']).responsive ? \\1 : 0;/" -i /usr/src/app/node_modules/nodebb-plugin-composer-default/static/lib/composer/resize.js +RUN ln -sf /usr/src/app/install/package.json /usr/src/app/package.json +RUN curl -sSL https://patch-diff.githubusercontent.com/raw/NodeBB/NodeBB/pull/6267.diff | patch -p1 +RUN npm install + COPY plugins /usr/src/app/plugins RUN npm install --save ./plugins/*/ nodebb-plugin-shortcuts@1.1.2 @@ -27,7 +31,6 @@ RUN echo public/uploads/*/ > .make-uploads-folders RUN cd node_modules/nodebb-plugin-imagemagick && curl -sSL https://patch-diff.githubusercontent.com/raw/NodeBB/nodebb-plugin-imagemagick/pull/6.diff | patch -p1 RUN curl -sSL https://patch-diff.githubusercontent.com/raw/NodeBB/NodeBB/pull/5185.diff | patch -p1 RUN cd node_modules/nodebb-plugin-tdwtf-buttons && curl -sSL https://patch-diff.githubusercontent.com/raw/NedFodder/nodebb-plugin-tdwtf-buttons/pull/2.diff | patch -p1 -RUN curl -sSL https://patch-diff.githubusercontent.com/raw/NodeBB/NodeBB/pull/6266.diff | patch -p1 COPY youtube-embed-debug.diff /usr/src/app/node_modules/nodebb-plugin-youtube-embed/youtube-embed-debug.diff RUN cd node_modules/nodebb-plugin-youtube-embed && cat youtube-embed-debug.diff | patch -p1
Edit: In fact, I can make it even easier. Once this build is done, just
docker pull boomzilawtf/tdwtf:postgres-test
instead of the usualdocker pull boomzilawtf/tdwtf
: https://hub.docker.com/r/boomzillawtf/tdwtf/builds/bqmcfkchgrggjvr5prxwnrj/
-
Was just randomly logged out.
-
@pie_flavor said in Discussion of NodeBB Updates:
Was just randomly logged out.
happens to me about once a month, fortunately LastPass is configured to detect this and automatically log me back in.
i blame mariaDB
why mariaDB? because i felt like it. i'll probably blame georgeDB next time, or maybe kennyDB. or poshSpiceDB.
i have options!
-
@pie_flavor said in Discussion of NodeBB Updates:
Was just randomly logged out.
Jeff was impersonating you for some reason, probably to check that your TL3 autopromotion was working correctly, and then logged out to stop impersonating you. Except that logs you out too.
Oh wait, that's only a bug in Discourse, not this forum!
-
Ok, I split the bug report to https://what.thedailywtf.com/topic/24565/flickering-vote-count-tooltip-thingy so it doesn't get lost when this thread inevitably gains another thousand replies.
-
@ben_lubar Good, 'cause there's another one.
When I post something, it highlights what I just posted, but it also highlights a different post and scrolls to that one.
-
Actually, it seems to be cumulative.
Edit: Never mind.
-
@pie_flavor I got that one earlier but I think it might ahev been because the topic was being Jeffed
-
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar Good, 'cause there's another one.
When I post something, it highlights what I just posted, but it also highlights a different post and scrolls to that one.And yet you continue to post here instead of in a bug thread?
-
@boomzilla said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar Good, 'cause there's another one.
When I post something, it highlights what I just posted, but it also highlights a different post and scrolls to that one.And yet you continue to post here instead of in a bug thread?
It can always be Jeffed away later.
-
@ben_lubar said in NodeBB Updates:
There will be an update as soon as the Docker Hub build finishes:
- Fixed Mafia XX highlight color CSS so it highlights the GM instead of one of the players.
You forgot your patch. IE is broken again.
-
@heterodox said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
There will be an update as soon as the Docker Hub build finishes:
- Fixed Mafia XX highlight color CSS so it highlights the GM instead of one of the players.
You forgot your patch. IE is broken again.
I've applied it manually again and also added it to the Dockerfile just in case there's another update before NodeBB's next release.
-
@boomzilla said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar Good, 'cause there's another one.
When I post something, it highlights what I just posted, but it also highlights a different post and scrolls to that one.And yet you continue to post here instead of in a bug thread?
It was introduced in this update, and I'm discussing it.
-
@ben_lubar said in Discussion of NodeBB Updates:
I've applied it manually again and also added it to the Dockerfile just in case there's another update before NodeBB's next release.
Bless you. Meanwhile, over on the forum I administer, I can't even be bothered to upgrade it from phpBB 3.0.12 to 3.2.2... I know it's necessary (security fixes) but themes break and that seems like a lot of work to fix... :P
-
@heterodox said in Discussion of NodeBB Updates:
I can't even be bothered to upgrade it from phpBB 3.0.12 to 3.2.2
Does phpBB still require manual installation of plugins by modifying source code?
-
@ben_lubar said in Discussion of NodeBB Updates:
Does phpBB still require manual installation of plugins by modifying source code?
Well, when I last installed it, it did but it had the ".automod" system that would do it for you (phpBB never referred to them as plugins, it was upfront that you had to modify the platform). Part of my reluctance to upgrade is also trying to update all of those mods, some of which don't exist anymore and will have to be replaced.
-
This is impressive.
Partial generated HTML? With a tag applied to its own visible self? Splitting the content of attributes?
-
@pie_flavor said in Discussion of NodeBB Updates:
This is impressive.
I feel like I might need to step in and make a custom emoji plugin like I had to do with the HTML sanitizer.
Anyone who doesn't know why "I wrote a parser for [language] in regular expressions" doesn't make sense is not qualified to write a parser for any language.
-
@ben_lubar said in Discussion of NodeBB Updates:
I feel like I might need to step in and make a custom emoji plugin like I had to do with the HTML sanitizer.
Did you mean to switch the order of those two?
-
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
I feel like I might need to step in and make a custom emoji plugin like I had to do with the HTML sanitizer.
Did you mean to switch the order of those two?
No. The HTML sanitizer is working properly. That's why you get
<a class
and not an actual link that contains the remainder of the page.
-
@ben_lubar said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
I feel like I might need to step in and make a custom emoji plugin like I had to do with the HTML sanitizer.
Did you mean to switch the order of those two?
No. The HTML sanitizer is working properly. That's why you get
<a class
and not an actual link that contains the remainder of the page.Oh Jesus, are you telling me that's what would happen on stock NodeBB?
-
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
I feel like I might need to step in and make a custom emoji plugin like I had to do with the HTML sanitizer.
Did you mean to switch the order of those two?
No. The HTML sanitizer is working properly. That's why you get
<a class
and not an actual link that contains the remainder of the page.Oh Jesus, are you telling me that's what would happen on stock NodeBB?
Stock NodeBB doesn't support raw HTML. You have to write in Markdown.
Let's check:
@boomzilla alt" class="img-responsive img-markdown"/>
O_o
-
@ben_lubar said in Discussion of NodeBB Updates:
O_o
Yeah, isn't it because mentions are processed out of order from something? I thought this was discussed before...
-
I clicked somewhere random from the Unread screen, and suddenly I had an edit box open for a post on a thread that wasn't even on the screen and that I haven't visited yet on this device.
-
@pie_flavor said in Discussion of NodeBB Updates:
I clicked somewhere random from the Unread screen, and suddenly I had an edit box open for a post on a thread that wasn't even on the screen and that I haven't visited yet on this device.
Submit your bug reports at https://meta.discourse.org
-
@polygeekery I will if I ever find bugs with Discourse.
Edit: what is going on with mentioning? @ben_lubar god dangit not again with this fix it in prod stuff
-
@pie_flavor they triage our bugs for us. Go post it there and it will be added to the queue.
-
@pie_flavor said in Discussion of NodeBB Updates:
not again with this fix it in prod stuff
-
Interesting off-by-one bug, if the @ is the first thing it doesn't get processed.
-
@pie_flavor said in Discussion of NodeBB Updates:
I will if I ever find bugs with Discourse.
I got one: On mobile, every topic I enter, the moment my finger touches the screen to start scrolling down I find myself a page down instantly, despite not actually moving my finger at all. Doesn't seem to happen again while in the topic, but navigating lets it happen again. So much fun I will have when I install it this weekend...
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
I will if I ever find bugs with Discourse.
I got one: On mobile, every topic I enter, the moment my finger touches the screen to start scrolling down I find myself a page down instantly, despite not actually moving my finger at all. Doesn't seem to happen again while in the topic, but navigating lets it happen again. So much fun I will have when I install it this weekend...
That's not a bug. It's a feature.
-
@polygeekery said in Discussion of NodeBB Updates:
It's a feature.
I sure hope so. In fact, I plan to livestream the install process from begin to functioning server this weekend. We'll see how featureful it is...
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
I will if I ever find bugs with Discourse.
I got one: On mobile, every topic I enter, the moment my finger touches the screen to start scrolling down I find myself a page down instantly, despite not actually moving my finger at all. Doesn't seem to happen again while in the topic, but navigating lets it happen again. So much fun I will have when I install it this weekend...
Same on NodeBB, except it's actually
rand.next_f64() * post_count
, and upwards, and you don't have to tap first, and it's desktop too.@tsaukpaetra said in Discussion of NodeBB Updates:
Interesting off-by-one bug, if the @ is the first thing it doesn't get processed.
Nested quotes too.
-
@ben_lubar said in Discussion of NodeBB Updates:
@heterodox said in Discussion of NodeBB Updates:
I can't even be bothered to upgrade it from phpBB 3.0.12 to 3.2.2
Does phpBB still require manual installation of plugins by modifying source code?
Only for plugins that do it wrong, but last time I checked that was a lot of plugins.
-
@sockpuppet7 With PHP, I wasn't aware that there was a 'right'.
-
@pie_flavor said in Discussion of NodeBB Updates:
@sockpuppet7 With PHP, I wasn't aware that there was a 'right'.
I developed for bbPress for a while, and one of my most popular plugins was a new private messaging plugin that didn't have SQL injection vulnerabilities and also supported threading and group private messages and reporting and moderators being allowed to see a PM thread if and only if you reported a message in it.
The installation of the plugin consisted of copying a folder into another folder. You could also do it through the admin panel UI in bbPress.
-
@pie_flavor said in Discussion of NodeBB Updates:
With PHP, I wasn't awawe that thewe was a 'wight'.
Status: I think I might keep this extension, it produces mirth emotions more powerful than other less savory ones...
Though reading comprehension suffers somewhat more than usual...
-
@tsaukpaetra said in Discussion of NodeBB Updates:
mirth
In Dwarf Fortress, mirthful (neutral good) forests and shrublands can have unicorns in them. Unicorns are not magical kind creatures. They're exactly what would happen if you attached a spear to the head of a wild horse.
Another type of animal found in good regions is Fluffy Wamblers, which are Extremely Copyrighted.
-
This is driving me mad @ben_lubar
(how damn hard is it to find an app to draw a circle on Android you ask? Hard it appears...)
-
-
How about now?
-
@zecc Nope - only one:
-
@zecc said in Discussion of NodeBB Updates:
How about now?
That's a thing of beauty. How do we ensure this survives various forum upgrades unmolested?
-
@swayde said in Discussion of NodeBB Updates:
That's a thing of beauty. How do we ensure this survives various forum upgrades unmolested?
Do what we did on Discourse when we didn't have nested quotes.