@japonicus said in How do I deal with people who throw away my work?:
regression tests
@boomzilla said in How do I deal with people who throw away my work?:
automated tests
Good idea. I've actually put my notice in to leave this place but I checked and the new place seems more open to, like, actually doing these. I can't (be bothered to) make the change here by my last day (Tuesday) but it makes me feel better about my new place.
@jaloopa said in How do I deal with people who throw away my work?:
I'm sure I'm missing something when it comes to merging code in heavily contested areas. I'm always worried I'm going to overwrite someone else's code by accident. Could we have some sort of training course so we can all learn how to get the best from our tools?
I like it. I mean, I don't think I've thrown other people's code away by accident, but then how would I know? I tend to just put a link to my PR on group chat and tell people I've had conflicts so they should try and spot check any issues. Still "I worry I might make this mistake" is a good place to start. Thanks.
@boomzilla said in How do I deal with people who throw away my work?:
I hope that you at least report back up the chain what happened.
Alas, no I was frightened it would come out like "piece-of-shit waste of space and air 'Derek' dumped my code and I only found out when dumbass 'Paul' told me the bug I'd fixed wasn't fixed", hence my question now. Admittedly I wasn't in a good place emotionally because the talentless lead who got fired for not doing PRs properly managed to get a complaint through that I "refactor things I shouldn't" and the delivery managers who knew the frontend had just been torn apart by non-frontenders and replaced by a backend-run jQuery replacement which after several months didn't compare in functionality or pattern consistency to the original SPA complained about my performance. At least I think those were the guys that complained, the complaints were technically anonymous. I had to extrapolate.
You're right though, it should be raised.
@blakeyrat said in How do I deal with people who throw away my work?:
code reviews
We did PRs, but I guess those weren't enough.
@blakeyrat said in How do I deal with people who throw away my work?:
disabling or deleting the failing test
Reasons I think low coverage should fail the build. Also linting. Also having CI at all.
I do appreciate all the input guys, thanks.