Discussion of NodeBB Updates
-
@boomzilla Looks like mime vomit (clown vomit, but in black and white)
-
Scrolling in the composer no longer scrolls the page
Scrolling the page in the composer still scrolls the emojicon menu though
-
@Jaloopa said in Discussion of NodeBB Updates:
Scrolling in the composer no longer scrolls the page
Scrolling the page in the composer still scrolls the emojicon menu though
Also, merely opening the composer Scrolls up a page or so still.
-
-
@ben_lubar said in NodeBB Updates:
Got tired of waiting, so some pull requests are locally merged as part of the Docker container build process:
So, we're cherry-picking now? Nice.
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Got tired of waiting, so some pull requests are locally merged as part of the Docker container build process:
So, we're cherry-picking now? Nice.
Actually, we're using the
patch
command because the Docker build process doesn't copy the .git folder.
-
@ben_lubar Hooray l18n!
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
@ben_lubar Hooray l18n!
It won't be translated on anything but the en_GB one until the PR is accepted.
-
@ben_lubar So why exactly do we prefer to merge early?
-
@Yamikuronue said in Discussion of NodeBB Updates:
@ben_lubar So why exactly do we prefer to merge early?
I prefer this over waiting forever for things like "fixed: permanent bans expire after 0 seconds" and "that one feature that people actually liked from Discourse".
Maybe I'm just petty and want my things NOW instead of having to wait.
-
@ben_lubar said in Discussion of NodeBB Updates:
Maybe I'm just petty and want my things NOW instead of having to wait.
And I want my things in English, not placeholder-ese. I shouldn't have to accept u's in everything to get that.
-
@Yamikuronue said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Maybe I'm just petty and want my things NOW instead of having to wait.
And I want my things in English, not placeholder-ese. I shouldn't have to accept u's in everything to get that.
Yeah, there should be a mechanism for default-if-not-found placeholders.
-
Wasn't the permanent ban already fixed?
Is this why the reply button is unusable now?
-
@fbmac Reply button works for me.
-
@coderpatsy the replies to link is over it
-
@fbmac said in Discussion of NodeBB Updates:
Is this why the reply button is unusable now?
Hey Ben, I found another reason not to pull in unmerged PRs.
-
@fbmac Ah, mobile. Well
Also I don't know if it's supposed to do replies-to-this-post updates over websocket or if you're supposed to refresh to see them, cause I have to do the refresh thing so far.
-
@coderpatsy there is an announcement that mobile is different at 1:30 UTC.
As it's not 1:30 yet mobile isn't different.
-
@Yamikuronue said in Discussion of NodeBB Updates:
@fbmac said in Discussion of NodeBB Updates:
Is this why the reply button is unusable now?
Hey Ben, I found another reason not to pull in unmerged PRs.
As if they would test on mobile before merging.
In fact, if @fbmac hadn't said that now, it'd probably be still broken on mobile when 1.3.0 came out.
-
@coderpatsy said in Discussion of NodeBB Updates:
@fbmac Ah, mobile. Well
Also I don't know if it's supposed to do replies-to-this-post updates over websocket or if you're supposed to refresh to see them, cause I have to do the refresh thing so far.
WOMM.
-
@coderpatsy said in Discussion of NodeBB Updates:
Also I don't know if it's supposed to do replies-to-this-post updates over websocket
It doesn't
@coderpatsy said in Discussion of NodeBB Updates:
or if you're supposed to refresh to see them
Anything that reloads the post (infiniscroll, going to another page, leaving the thread and coming back) works. No need to do a hard refresh.
-
@fbmac said in Discussion of NodeBB Updates:
@coderpatsy the replies to link is over it
E_NO_REPRO get a lower DPI phone.
-
@Tsaukpaetra it's after 02:00 UTC, so mobile is different.
-
@Yamikuronue said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Maybe I'm just petty and want my things NOW instead of having to wait.
And I want my things in English, not placeholder-ese. I shouldn't have to accept u's in everything to get that.
brillant
-
@Lorne-Kates said in Discussion of NodeBB Updates:
@Yamikuronue said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Maybe I'm just petty and want my things NOW instead of having to wait.
And I want my things in English, not placeholder-ese. I shouldn't have to accept u's in everything to get that.
brillant
Yay signatures!
Also, looks like it shows the most recent post first?
-
Even more brillant on a tiny screen.
-
I get all the βbenefitsβ of all the bugs it seems:
TEH CSSES R HARD!
-
http://i.imgur.com/yr6YXEg.png
This is not very helpful. (And no, you can't scroll as far as I can tell).
-
Oh, now I've noticed the NaN in the post counter. So there are at least three bugs on this single screenshot. Can you find more?
-
@clatter - what about en@pirate...
-
@ben_lubar said in Discussion of NodeBB Updates:
In fact, if @fbmac hadn't said that now,
The fact that @fbmac said anything also proves the Delete function is broken.
-
-
@e4tmyl33t I saw that someone had replied to that post in the updates thread...
... so I clicked on it...
... and after the reply I started seeing the beginning of the updates thread. I wonder if I could make it literally infiniscroll!
EDIT: 'd over here.
-
Status: That's special...
-
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post PR accepted
- Style change for replies-to-post
- Fixed NaN showing up on the infiniscroll thing
- Profile dropdown on mobile no longer white-on-white on dark themes
- Fixed tooltip in chat dropdown
- Added popcorn button to NodeBB updates thread
Change lists
What does this button do?
-
@Lorne-Kates said in Discussion of NodeBB Updates:
What does this button do?
Oh.
Also, clicking that button sent me to Post #1 of this thread, rather than Last Read Post of this thread.
-
@Lorne-Kates said in Discussion of NodeBB Updates:
@Lorne-Kates said in Discussion of NodeBB Updates:
What does this button do?
Oh.
Also, clicking that button sent me to Post #1 of this thread, rather than Last Read Post of this thread.
Yeah, the popcorn button is just a hack.
-
There's a bug when there is a reply to a deleted post:
-
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post PR accepted
- Style change for replies-to-post
- Fixed NaN showing up on the infiniscroll thing
- Profile dropdown on mobile no longer white-on-white on dark themes
- Fixed tooltip in chat dropdown
- Added popcorn button to NodeBB updates thread
Change lists
I still want the replies-to-post to have a grayer background like it was in . Also the button that opens it kinda hangs in nowhere. It should join the other buttons at the right side.
-
@marczellm said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post PR accepted
- Style change for replies-to-post
- Fixed NaN showing up on the infiniscroll thing
- Profile dropdown on mobile no longer white-on-white on dark themes
- Fixed tooltip in chat dropdown
- Added popcorn button to NodeBB updates thread
Change lists
I still want the replies-to-post to have a grayer background like it was in . Also the button that opens it kinda hangs in nowhere. It should join the other buttons at the right side.
-
@ben_lubar said in Discussion of NodeBB Updates:
@marczellm said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post PR accepted
- Style change for replies-to-post
- Fixed NaN showing up on the infiniscroll thing
- Profile dropdown on mobile no longer white-on-white on dark themes
- Fixed tooltip in chat dropdown
- Added popcorn button to NodeBB updates thread
Change lists
I still want the replies-to-post to have a grayer background like it was in . Also the button that opens it kinda hangs in nowhere. It should join the other buttons at the right side.
Indeed, but I agree with him actually...
-
@marczellm said in Discussion of NodeBB Updates:
I still want the replies-to-post to have a grayer background
I don't want pale grey on my dark blue, thanks
-
@Yamikuronue said in Discussion of NodeBB Updates:
@marczellm said in Discussion of NodeBB Updates:
I still want the replies-to-post to have a grayer background
I don't want pale grey on my dark blue, thanks
Oh, right. Themes.
Ugh.
That makes life harder.
-
@sloosecannon Allowing for opacity in background color makes it a bit easier:
.topic [component="post/replies"] { background-color: rgba(127, 127, 127, 0.25); }
It's what I added to make them a bit different, tried Default, Darkly, Cyborg, and Superhero and it looks alright on all of them. But I'm only suggesting this as a Stylish change unless everyone is fine with how it looks on their theme of choice.
-
@ChaosTheEternal That looks pretty good on the default background, imo. :D
-
@marczellm said in Discussion of NodeBB Updates:
I still want the replies-to-post to have a grayer background like it was in . Also the button that opens it kinda hangs in nowhere. It should join the other buttons at the right side.
If we can't come to an agreement about cross theme colors, at least a border would help. And yes, the moving target for the replies expander is annoying.
-
@boomzilla said in Discussion of NodeBB Updates:
at least a border would help. And yes, the moving target for the replies expander is annoying.
Yes.
The + looks like "add a reply", not "there are replies to this post". And the fact that it's text looks like just information, not an actionable item (ie: a button).
-
@Lorne-Kates
Yeah, I would think a " View Replies to this Post" " Collapse Replies to this Post" UI would be more useable.I would even be willing to negotiate on skipping "to this post".
-
@boomzilla said in Discussion of NodeBB Updates:
moving target for the replies expander
Never mind, looks like someone else put in a
display: block
on that which "fixes" it jumping around.
-
@ChaosTheEternal said in Discussion of NodeBB Updates:
Never mind, looks like someone else put in a display: block on that which "fixes" it jumping around.
But since they didn't set a width, there's a huge, screen-wide, invisible hyperlink that will fuck things up if you accidentally click it.