Discussion of NodeBB Updates
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Update scheduled for 04:00 UTC.
There are no server-side code changes. The update includes some CSS changes for Mafia and a light gray background for fa- emoji on dark themes.
and removing the "April fools joke"?
I didn't realise it was pile-on-Ben time again.
Come on, it was harmless, and picked up on recent events with necroing and downvote-debacles. Ben, FWIW I enjoyed them. Don't stop.
...But if you next year decide to replace all usernames with names from dwarf fortress, I might take that back.
-
@Mikael_Svahnberg
I think the tilt thing is overdone and due for a rest. Though at least it wasn't as bad as /r/guildwars2 which made their subreddit literally unreadable with how much tilt they applied.
-
@Mikael_Svahnberg said in Discussion of NodeBB Updates:
I didn't realise it was pile-on-Ben time again.
The vote flip shenanigans *on their own would have been annoying but acceptable to me as an april fools "joke".
The necro notifier shenanigans *on their own would have been aggravating but acceptable to me as an april fools "joke".
The tilt shenanigans *on their own would have been infuriating but acceptable to me as an april fools "joke".
all three together are far to far and take this from "April Fools Joke" to "I am now going out of my way to deface the website with stylish and userscripts to remove your "joke" to make the site usable again.
That's not a joke anyonre, that's going far to far, and i'm going to make that clear in the hope that next year we either don't participate in the foolishness or CHOOSE A SINGLE "JOKE"
-
@accalia see how much clearer things get when you use your words.
-
@accalia said in Discussion of NodeBB Updates:
to make the site usable again.
Nothing about it made the site unusable.
-
@loopback0 said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
to make the site usable again.
Nothing about it made the site unusable.There is no way to make NodeBB usable.FTFY
-
@loopback0 said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
to make the site usable again.
Nothing about it made the site unusable.
Well, that depends on one's definition of "unusable". I found it annoying enough to just stay mostly away from here while they were in place. That being said, it was on a Saturday and I am not around a whole lot on the weekends anyway.
Plus, it was only one day. No need to get panties in such a wad.
-
@ben_lubar I propose every NodeBB update to have a different, subtle joke
-
It could also finish at midday, like proper countries do it.
-
@wharrgarbl said in Discussion of NodeBB Updates:
@ben_lubar I propose every NodeBB update to have a different, subtle joke
Bugs are already incorporated into each update already, what are you asking for?
-
Should've made downvotes public again for an April Fools joke
-
@wharrgarbl said in Discussion of NodeBB Updates:
@ben_lubar I propose every NodeBB update to have a different, subtle joke
I would upvote your post for that evil idea, but it is just way too likely that someone is going to try it.
-
Next year: add signature guys
-
@bb36e said in Discussion of NodeBB Updates:
Next year: very occasionally add signature guys that appear to be posts from the current user saying stupid things
Hmm...
-
@ben_lubar add fake deleted posts from some new user and make people think he's another fbmac alt
-
Next year's April Fool should apply only to @accalia
-
@Polygeekery said in Discussion of NodeBB Updates:
I found it annoying enough to just stay mostly away from here while they were in place.
Same here.
-
@ben_lubar said in Discussion of NodeBB Updates:
@bb36e said in Discussion of NodeBB Updates:
Next year: very occasionally add signature guys that appear to be posts from the current user saying stupid things
Hmm...
I think you jumped the gun on this one, I see it on the board all the time.
-
@Jaloopa said in Discussion of NodeBB Updates:
Next year's April Fool should apply only to @accalia
Next year, each of the style changes should only apply to a subset of users, so that everyone has a different, random experience.
Call the update "WOMM".
-
@Jaloopa said in Discussion of NodeBB Updates:
Next year's April Fool should apply only to @accalia
5/1 (1/5, or whatever) is next month, not next year.
-
@accalia said in Discussion of NodeBB Updates:
all three together are far to far and take this from "April Fools Joke" to "I am now going out of my way to deface the website with stylish and userscripts to remove your "joke" to make the site usable again.
I liked having them all. But then, I wasn't trying to read the forums on mobile, which I understand the necro notifiers particularly made annoying.
-
@ben_lubar said in NodeBB Updates:
- Fixed an infinite loop if 256 users signed up with the same username.
-
- Users will now be forcibly removed from underprovisioned NodeJS processes.
What is it? The link doesn't work for me
-
@wharrgarbl said in Discussion of NodeBB Updates:
- Users will now be forcibly removed from underprovisioned NodeJS processes.
What is it? The link doesn't work for me
That is because you were forcibly removed.
-
@Polygeekery said in Discussion of NodeBB Updates:
@wharrgarbl said in Discussion of NodeBB Updates:
- Users will now be forcibly removed from underprovisioned NodeJS processes.
What is it? The link doesn't work for me
That is because you were forcibly removed.
I would say there is no way I could be posting stuff if that happened, but this is NodeBB, anything can happen.
-
@wharrgarbl said in Discussion of NodeBB Updates:
- Users will now be forcibly removed from underprovisioned NodeJS processes.
What is it? The link doesn't work for me
It's not a link, but if you want a link, you can have one, I guess?
-
@ben_lubar I mean the URL doesn't work for me, it shows a message in my local language that there is no article.
-
@wharrgarbl It's articles about recent incident during the boarding of a United flight.
-
@coderpatsy said in Discussion of NodeBB Updates:
@wharrgarbl It's articles about recent incident during the boarding of a United flight.
-
@ben_lubar said in NodeBB Updates:
Partial revert because WHO INTRODUCES LITERAL BREAKING CHANGES TO THE STABLE CHANNEL RIGHT AFTER AN URGENT BUGFIX
I'm not going to justify that.
-
-
@ben_lubar said in NodeBB Updates:
Partial revert because WHO INTRODUCES LITERAL BREAKING CHANGES TO THE STABLE CHANNEL RIGHT AFTER AN URGENT BUGFIX
What was the breaking change?
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Partial revert because WHO INTRODUCES LITERAL BREAKING CHANGES TO THE STABLE CHANNEL RIGHT AFTER AN URGENT BUGFIX
What was the breaking change?
Exception thrown in the composer when submitting a post. After I posted that, the NodeBB people invited me to their Slack so I could help them repro it.
-
@ben_lubar said in Discussion of NodeBB Updates:
invited me to their Slack
What? Not dogfooding their own chat? For shame!
-
@Tsaukpaetra they need something useable on their phones
-
@ben_lubar You didn't write patch notes before going to bed.
-
@NedFodder said in Discussion of NodeBB Updates:
@ben_lubar You didn't write patch notes before going to bed.
Inb4 @ben_lubar posts
Patch notes before going to bed
-
@ben_lubar said in NodeBB Updates:
@sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
Given there's an active Mafia game which (I believe) uses SockBot, shouldn't we make sure this update won't affect the game before applying it?
-
@RaceProUK said in Discussion of NodeBB Updates:
Given there's an active Mafia game which (I believe) uses SockBot, shouldn't we make sure this update won't affect the game before applying it?
You obviously forgot who you are, and who @ben_lubar is. Go home @RaceProUK, you're drunk.
-
@Polygeekery said in Discussion of NodeBB Updates:
Go home @RaceProUK, you're drunk.
I'm not drunk! :P
Yet.
-
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
@sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
Given there's an active Mafia game which (I believe) uses SockBot, shouldn't we make sure this update won't affect the game before applying it?
The tiny bit of code I read will not be affected:
-
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
-
Don't know what combination of factors caused this, but I'm seeing weird things with repies in another thread:
It goes on with seemingly every post in the NodeBB Updates thread.
-
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
oh. a change to the markup
p'shaw! we go at the backend api, we don't care about the markup real people see!
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
oh. a change to the markup
p'shaw! we go at the backend api, we don't care about the markup real people see!
The code I linked is server-side.
-
@hungrier Yeah, I have no idea why the NodeBB Updates topic has double-counted replies for every post or why if the last post in a topic has replies it repeats the topic from the beginning.
-
@ben_lubar Yes, but we don't deal with markup, we deal with the raw JSON. So long as that's unchanged, there won't be an issue.
-
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
oh. a change to the markup
p'shaw! we go at the backend api, we don't care about the markup real people see!
The code I linked is server-side.
and it affects teh CSS classes that notifications get which is completely ignored by sockbot
unless of course i misread it because i'm missing a vital piece of information that you assume i know when i in fact do not.
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- @sockdevs this update changes notification text for notifications containing a post, topic, or category ID, so if you're doing string matching, you'll need to modify your regular expressions.
got any details on this for us? Or is this going to be another "suck it and see" update where things change and we have to figure out how they changed later?
I don't see anything obvious in the changelogs quoted that would affect this change and having a 9-5 that doesn't give me time to sit down and figure it out before you pull the trigger either.
oh. a change to the markup
p'shaw! we go at the backend api, we don't care about the markup real people see!
The code I linked is server-side.
and it affects teh CSS classes that notifications get which is completely ignored by sockbot
unless of course i misread it because i'm missing a vital piece of information that you assume i know when i in fact do not.
The SockBot code I linked looks at the field that that server-side code is modifying:
However, the SockBot code only looks at the start and the server-side code only modifies the end, so we should be okay.