Discussion of NodeBB Updates
-
@HardwareGeek said in Discussion of NodeBB Updates:
I can't get /unread to show more than 20 topics, even though I have ~35 unread. Nothing more streams in when I scroll to the bottom.
This was a bug which had been fixed until Ben applied the downdate.
-
@loopback0 I figured it was something like that. Thanks, @ben_lubar.
-
@HardwareGeek does it work if you change to pagination?
-
@barisu Yes, I do get a second page with the remaining topics. Notifications are still , though.
-
@loopback0 said in Discussion of NodeBB Updates:
Deployment on a Friday before leaving for the weekend. Top ing.
wait when do I ever leave my basement for a weekend?
-
Looks like downvoter display is completely gone from the popup.
-
Is the autosave icon new?
-
@loopback0 said in Discussion of NodeBB Updates:
Is the autosave icon new?
No, that's actually a fairly old image that looks like a 3.5" diskette, which people used to use for saving data.
Yes, I noticed it showing up after the update, too.
-
-
@loopback0 said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Some emoji updates.
dafuq?
It's working just fine now.... and in the composer preview.... Does NodeBB bake posts?!?!?
-
@loopback0 said in Discussion of NodeBB Updates:
autosave
Does that mean composer posts will now not automatically re-pop-up when opening a new tab with the composer open?
-
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
@loopback0 said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Some emoji updates.
dafuq?
It's working just fine now.... and in the composer preview.... Does NodeBB bake posts?!?!?
NodeBB doesn't but our modifications do
-
@boomzilla is not downvoting our posts anymore:
-
d by the prime @boomzilla
himself 5 days ago:@boomzilla said in Discussion of NodeBB Updates:
Looks like downvoter display is completely gone from the popup.
-
Is @Mikael_Svahnberg back? His profile shows last online 6 hours ago, and IIRC his avatar was hatoshopped before
-
(click the votes counter on a post)Also the Popcorn button is missing from the updates thread.
-
@loopback0 said in Discussion of NodeBB Updates:
(click the votes counter on a post)Also the Popcorn button is missing from the updates thread.
hmm, popcorn button is visible for me...
-
Status: desperately trying to recall everything I've said in the last two weeks…
you've robbed me of the fire-breathing pterosaur! And a fair few witticisms and rep whoring! And a 2000th post!
-
@loopback0 said in Discussion of NodeBB Updates:
(click the votes counter on a post)Also the Popcorn button is missing from the updates thread.
ok, popcorn and votes should be fixed now
-
@ben_lubar said in Discussion of NodeBB Updates:
ok, popcorn and votes should be fixed now
Popcorn shows if you navigate to the topic but disappears if you refresh.
-
@ben_lubar said in NodeBB Updates:
NodeBB would do a full database scan for every post's reply count
-
@lolwhat said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
NodeBB would do a full database scan for every post's reply count
and we wondered why performance of the site was carp........
-
@ben_lubar said in NodeBB Updates:
probably should have manually taken a backup before I did the maintenance,
-
Google and Twitter logins are fucked too, apparently. Good thing I associated every possible authentication method so I don't get locked out...
-
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
Did something clear the notifications? It says I have no recent notifications.
Also this thread appears in recent twice.
Also... I'm not super fond of the red boob's poorly-placed nipple pastie.
-
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
You have got to be fist fucking me? You wiped out two fucking weeks of posts?
-
@Polygeekery said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
You have got to be fist fucking me? You wiped out two fucking weeks of posts?
Oh.
Yeah I guess that would also explain the lack of notifications. WTF.
-
@Polygeekery said in Discussion of NodeBB Updates:
You wiped out two fucking weeks of posts?
The Roomba vacuumed too much
-
All our posts for the past two weeks
-
Ah shit, we lost our fancy interstitial too
-
@hungrier said in Discussion of NodeBB Updates:
All our posts for the past two weeks
If he were an employee this is the point where he would be cleaning out his desk.
-
@Vixen said in Discussion of NodeBB Updates:
@lolwhat said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
NodeBB would do a full database scan for every post's reply count
and we wondered why performance of the site was carp........
It's a good thing NodeBB didn't have too many objects that supported replies on each page, or that could get computationally expensive.
-
@brie said in Discussion of NodeBB Updates:
Also... I'm not super fond of the red boob's poorly-placed nipple pastie.
I was wondering if that was new or not.
-
It seems the iFramely for YouTube is broken. Previous embeds (assumed cached) work fine, new ones (see the Song of the Day thread) have an invisible play button and don't load when you click them...
-
@Polygeekery said in Discussion of NodeBB Updates:
If he were an employee this is the point where he would be cleaning out his desk.
I'm looking at this from the positive side: I don't have to come up with new witty posts for two weeks, I just have to remember my old ones.
-
@hungrier said in Discussion of NodeBB Updates:
All our posts for the past two weeks
You have been waiting to use that, haven't you?
-
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
Bug report:
- Go to the post I replied to.
- Look at the replies.
- Notice that in addition to the actual replies, it lists a bunch of posts by @ben_lubar.
Also, I can now see two columns of posts on my profile, it's completely unreadable. Both happens on mobile, not sure about the desktop version.
-
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
You should be apologizing some more to @obeselymorbid. Just when he got to liking posts from 2019 he now needs to start over again.
-
@dfdub said in Discussion of NodeBB Updates:
Bug report:
Go to the post I replied to.
Look at the replies.
Notice that in addition to the actual replies, it lists a bunch of posts by @ben_lubar.Works on desktop, I see only posts which really quote Ben's post.
@dfdub said in Discussion of NodeBB Updates:
Also, I can now see two columns of posts on my profile, it's completely unreadable. Both happens on mobile, not sure about the desktop version.
On desktop it's clear that it shows two different post timelines: "Best posts made by X" and "Latest posts made by X". Must be that they didn't test the layout on mobile.
-
@dfdub said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
Bug report:
- Go to the post I replied to.
- Look at the replies.
- Notice that in addition to the actual replies, it lists a bunch of posts by @ben_lubar.
It's looped round to the start of the topic, which I think may or may not have been a previous bug. It's a real time warp.
-
@loopback0 said in Discussion of NodeBB Updates:
It's a real time warp.
It’s just a jump to the left,
and then a step to the riiiiiight
-
So the details tag no longer works correctly...
This should be hidden below the fold.
Also when using a details tag the preview is just flat broken. displays nothing at all.
nothing at all...
Nothing at all......
this seems to be relevant as as soon as i include the details tag it starts spitting it out in the js console:
jquery.js:1560 Uncaught Error: Syntax error, unrecognized expression: So the details tag no longer works correctly... <p>This should be hidden below the fold.</p> <p>Also when using a details tag the preview is just flat broken. displays nothing at all.</p> <p>nothing at all...</p> <p>Nothing at all......</p> <p>And the ABBR tag looks weird too...</p> at Function.se.error (jquery.js:1560) at se.tokenize (jquery.js:2216) at se.select (jquery.js:2643) at Function.se [as find] (jquery.js:862) at x.fn.init.find (jquery.js:2896) at new x.fn.init (jquery.js:3006) at x (jquery.js:152) at i.<anonymous> (preview.js:28) at i.onack (socket.io.js:8) at i.onpacket (socket.io.js:8)
And the ABBR tag looks weird too...
-
The login page also exhibits weird behavior. My browser auto-fills the username and password, then NodeBB decides to auto-focus the password field for some reason and I have to enter the password manually.
Also, the new user page with the two columns looks horrible even in Desktop browsers.
-
@cvi said in Discussion of NodeBB Updates:
@Polygeekery said in Discussion of NodeBB Updates:
If he were an employee this is the point where he would be cleaning out his desk.
I'm looking at this from the positive side: I don't have to come up with new witty posts for two weeks, I just have to remember my old ones.
You're just poking fun at those of us afflicted with CRS, aren't you?
-
@Polygeekery said in Discussion of NodeBB Updates:
@cvi said in Discussion of NodeBB Updates:
@Polygeekery said in Discussion of NodeBB Updates:
If he were an employee this is the point where he would be cleaning out his desk.
I'm looking at this from the positive side: I don't have to come up with new witty posts for two weeks, I just have to remember my old ones.
You're just poking fun at those of us afflicted with CRS, aren't you?
Not just that. He's poking fun at the rest of us too...
-
@dfdub said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
sorry about that; I managed to mess up the
legacy_hash
table, so we're on the latest backup (usually backups are every week, but my windows PC was dead this saturday)probably should have manually taken a backup before I did the maintenance, but
also the part where NodeBB would do a full database scan for every post's reply count is fixed now
Bug report:
- Go to the post I replied to.
- Look at the replies.
- Notice that in addition to the actual replies, it lists a bunch of posts by @ben_lubar.
Also, I can now see two columns of posts on my profile, it's completely unreadable. Both happens on mobile, not sure about the desktop version.
This bug is around on all popcorn-able threads. It's not new and it's not actual bad data.
The thread loops.
-
@Vixen said in Discussion of NodeBB Updates:
So the details tag no longer works correctly...
This should be hidden below the fold.
Also when using a details tag the preview is just flat broken. displays nothing at all.
nothing at all...
Nothing at all......
this seems to be relevant as as soon as i include the details tag it starts spitting it out in the js console:
jquery.js:1560 Uncaught Error: Syntax error, unrecognized expression: So the details tag no longer works correctly... <p>This should be hidden below the fold.</p> <p>Also when using a details tag the preview is just flat broken. displays nothing at all.</p> <p>nothing at all...</p> <p>Nothing at all......</p> <p>And the ABBR tag looks weird too...</p> at Function.se.error (jquery.js:1560) at se.tokenize (jquery.js:2216) at se.select (jquery.js:2643) at Function.se [as find] (jquery.js:862) at x.fn.init.find (jquery.js:2896) at new x.fn.init (jquery.js:3006) at x (jquery.js:152) at i.<anonymous> (preview.js:28) at i.onack (socket.io.js:8) at i.onpacket (socket.io.js:8)
And the ABBR tag looks weird too...
Those tags are getting stripped from the rendered post.
@ben_lubar issue with the html sanitizer plugin, maybe?
-
The abbr tag even has its own button in the composer. Is it really not in the default whitelist, or is this some other post reset weirdness?
-
What if Ben really got an ultimatum from the Government That Shall Not Be Named, and had to delete posts from a specific thread... but decided to cover it up by staging a data loss event instead