Discussion of NodeBB Updates
-
@loopback0
Gotta fit in the ransomware backup of the Debian repo mirror somewhere.
-
@loopback0 said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Updated iframely to 1.2.7 and added custom support for embedding Mastodon statuses like this one:
Ben are you the only Mastodon user?
I've never seen/heard anyone else ever mention it.I've got an account, but I've never posted to it.
-
I updated my Mastodon instance:
-
@ben_lubar Yes, we can tell!
-
@TwelveBaud said in Discussion of NodeBB Updates:
@ben_lubar Yes, we can tell!
That's not Mastodon going down. That's the entire system somehow becoming unroutable. I tried using Wireshark to see what was getting sent back and nothing was even getting sent to Urist when I tried to connect.
-
@ben_lubar While you're adding iframelies for weird things nobody uses, why don't you add an iframely for WTDWTF posts?
-
@pie_flavor Preferably one that won't affect the read flag
-
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar While you're adding iframelies for weird things nobody uses, why don't you add an iframely for WTDWTF posts?
Because recursively loading a page that builds on demand might do bad things?
-
@ben_lubar Who said recursively? Get the json for the individual post and turn it into an embed.
-
@pie_flavor IIRC posts used to embed but there was no reliable way to tell iframely not to onebox any oneboxes in the onebox so it was trivial to make two posts link to each other and cause an infinite loop
-
@Jaloopa how is there no reliable way? just don't iframely anything inside an iframely. If it's being rendered on-demand from the JSON, I doubt anyone could fuck that up.
-
@pie_flavor ask the iframely developers. That's what I remember of Ben's explanation for why he disabled it
-
@Jaloopa It worked in the twitter iframely. Therefore, it's possible.
-
@pie_flavor said in Discussion of NodeBB Updates:
I doubt anyone could fuck that up.
-
@HardwareGeek said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
I doubt anyone could fuck that up.
Remember: Alternate universe.
-
@ben_lubar said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar While you're adding iframelies for weird things nobody uses, why don't you add an iframely for WTDWTF posts?
Because recursively loading a page that builds on demand might do bad things?
He said the post, not the page. Break recursion by
either not letting a post embed itself, or bynot letting an embedded post embed any further posts.edit: what does iframely look for to trigger loading a onebox? There ought to be some way to fiddle the classes so that it doesn't onebox posts inside another oneboxed post.
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@ben_lubar While you're adding iframelies for weird things nobody uses, why don't you add an iframely for WTDWTF posts?
Because recursively loading a page that builds on demand might do bad things?
He said the post, not the page. Break recursion by
either not letting a post embed itself, or bynot letting an embedded post embed any further posts.edit: what does iframely look for to trigger loading a onebox? There ought to be some way to fiddle the classes so that it doesn't onebox posts inside another oneboxed post.
iframely has two parts: the plugin running on the forum, which can't tell which page it's being called from, and the service running outside of the forum, which only knows how to retrieve data using a few standardized formats.
-
@ben_lubar the part running in the forum as a plugin has to detect the links that it's supposed to embed. There has to be some way to change the post that's given to the server-side part so that the client-side part won't recursively embed things.
Hell, just serving up the post inside an actual iframe would probably work, since I don't think the client side code would be able to mess with the contents of the iframe.
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar the part running in the forum as a plugin has to detect the links that it's supposed to embed. There has to be some way to change the post that's given to the server-side part so that the client-side part won't recursively embed things.
If the forum embeds posts directly from the database, I'd be worried about lounge stuff leaking. At that point, just quoting the post you want to link to would be more accountable.
@anotherusername said in Discussion of NodeBB Updates:
Hell, just serving up the post inside an actual iframe would probably work, since I don't think the client side code would be able to mess with the contents of the iframe.
Uh, what happens when a post and it embeds itself?
-
@ben_lubar Dude, you should totally check out this discussion about that! It's right here:
https://what.thedailywtf.com/post/1435028
-
@ben_lubar said in NodeBB Updates:
Update to NodeBB 1.11 scheduled for 19:00 UTC
Change list:
From the link:
traffic filtering, navigation improvements and more
-
Hrm...it seems that we lost the ability to left click an image to get it opened in a new tab.
-
@boomzilla https://github.com/NodeBB/NodeBB/issues/7030 1.11.1 or maybe 1.12.0 since we have another big change incoming at https://github.com/NodeBB/NodeBB/pull/7109
-
Has anyone else noticed an inability to stream more topics when scrolling / or /unread on mobile? There doesn't seem to be a problem streaming posts within topics (at least that I've noticed), just on the topic lists. Chrome 71.0.numbers on Android 6.0.
-
@HardwareGeek What I noticed so far is that I can't use buttons on mobile and that jumping to a post won't work. Also the top bar will always show, no matter if you drag the page up or down (it used to hide itself when scrolling down, then reappear when moving in the other direction).
Could be a case of an outdated browser on my phone though...
-
@JBert said in Discussion of NodeBB Updates:
Also the top bar will always show, no matter if you drag the page up or down (it used to hide itself when scrolling down, then reappear when moving in the other direction).
I hadn't noticed, but yes, it's always consuming valuable screen real estate now. And collapsing the editor seems to have made the submit button permanently unavailable. Ok, refresh fixed that.
-
@HardwareGeek said in Discussion of NodeBB Updates:
And collapsing the editor
Ah, I see what you mean...
Hrm....
-
I'm completely confused as to how post revision history works now. There always seems to be one item in the dropdown?
well this one seems to work fine. Is it providing a modal dialog anyway for people who haven't allowed their revision history to be visible?
nope, after saving I get the weird single-item thing. Then I refresh and the history becomes a link that works properly.
-
@kazitor Yeah, and it seems to have broken whatever hid the old revision history dialog so the new one would be the only thing that showed.
-
Wait, what happened to the thing where images would only load once scrolled to? Now I open a link to a particular post and have to scroll down two pages to where the images displaced it to.
-
@kazitor There was a time when it didn't do that for you?
-
@pie_flavor the actual option in the settings page has vanished.
-
And where'd the composing help thing go, with the list of allowed markup? I had to go digging around for a post with spoiler-style stuff to find out how to do it.
<details><summary>FYI...</summary> In case you don't know either. </details>
-
@HardwareGeek said in Discussion of NodeBB Updates:
Has anyone else noticed an inability to stream more topics when scrolling / or /unread on mobile?
I have this issue on desktop now. It's fine on recent just not unread.
-
@ben_lubar said in NodeBB Updates:
Update to NodeBB 1.11 scheduled for 19:00 UTC
Change list:
Has anyone else noticed topics loading at the wrong position since this update? Firefox 64.
-
@PleegWat More than usual, yes.
-
The drag the bar to get to a post thing is a bit annoying. I keep starting a scroll swipe a bit too low and going to a completely different post
-
I love when the websocket reconnects and the notification counter, notification list on the menu, and notification on the notifications page forever stay desynced... Well, until you enter a topic, then they might sync. Sometimes.
-
did anyone mention posting on mobile/tablet ? cause the post buttons are hiden for me. (the chrome/safari adress bar covers the space where the post button should be)
-
The dark theme didn't load after login. This has never happened before.
-
@swayde The Chrome/Safari header doing it? Or the NodeBB header?
I do know the CSS is messed up for the composer. It's given a z-index of 1050 in "desktop" and 1070 in "mobile" then overriden with a local rule with z-index of 1000 !important, while the header has a z-index of 1030.
Until the local rule is removed, you can dump this workaround in your Custom CSS in User Settings and see if that fixes it:
html:not([data-disable-tdwtf-css]) .composer { z-index: 32767!important; }
Looks fine to me on my Android phone and my now dusty iPad.
-
Hooray, they've added minimization back! In... two different places. Yes, we totally needed the red boob back when there's already a minimize button up top. Also, nobody tested this at all, because when I minimize a post, re-open it, and re-minimize it, I end up at the top of the currently loaded frame. Come on, guys, you fixed this for fullscreen video, how could you fuck this up again? There is no fucking reason to scroll to top when the composer is open. For a bonus, minimizing that post is the only way to get rid of it again because once you've reopened a minimized post the post buttons are gone. By the way, that top of the frame thing - at one point it sent me to the top, and I pushed the scroll all the way to the bottom button, and it landed me at https://what.thedailywtf.com/compose/undefined/undefined/90224 which is obviously a 404.
e: Oh good. Reopens always have broken post buttons, but broken post buttons manifest elsewhere at random too. This is quite literally one step forward two steps back as a feature I had requested was re-added and two bugs that particularly annoyed me were re-introduced.
-
@pie_flavor said in Discussion of NodeBB Updates:
There is no fucking reason to scroll to top when the composer is open.
You'll be unsurprised, but the reason this happens is because all of the posts are
display:none
'd on mobile while the composer is open.
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
the reason this happens is because all of the posts are display:none'd on mobile
Wrong. The HTML tag gains the class
composing
which has a rule to setoverflow: hidden
on the BODY. With no overflow, it resets the scroll position.More override CSS:
@media (max-width: 991px) { html.composing, html.composing body { overflow: initial; } }
Caveat with this is, you can still scroll the page while the composer is open, and no clue how that may impact infiniscroll users.
-
@ChaosTheEternal said in Discussion of NodeBB Updates:
Wrong.
Eh, close enough. The observable difference is unobservable.
-
@pie_flavor paging @barisu
-
@loopback0 said in Discussion of NodeBB Updates:
@HardwareGeek said in Discussion of NodeBB Updates:
Has anyone else noticed an inability to stream more topics when scrolling / or /unread on mobile?
I have this issue on desktop now. It's fine on recent just not unread.
Yes, I have it on both. I only mentioned mobile because that's what I was using when the problem appeared.
-
@Jaloopa said in Discussion of NodeBB Updates:
The drag the bar to get to a post thing is a bit annoying. I keep starting a scroll swipe a bit too low and going to a completely different post
Seconded, this is the worst thing ever. Is there any way to get rid of this? I'm getting whiplash every time I try to read a topic...
-
We looked into the issue regarding body overflow hidden... it apparently was a fix for users on iOS Safari
We're looking to roll out a fix to that as it doesn't seem to be needed anymore on latest Safari...
-