:wtf: How can this be so wrong??? (AKA the Discopocalypse thread)
-
You have to connect your teledildonics devices somehow ...
-
Filed under: cat5 cables now available at your nearest sex shop, strip it for me baby
Also filed under: Reset my Cisco, baby
-
I'm telling you, one time I met this girl at a bar that could wire an RJ45 plug with her tongue!
Filed under: but then she crimped it with her teeth and I kinda lost interest
-
Filed under: You use 2560x1440? That's different.
-
Round these parts 2/5 Ă— y is 200, but since we don't currently have that feature, it doesn't much matter.
Now 400! And we should have it tomorrow.
-
-
On the vein of the whisper feature:
Do whispers bump a topic without visibly updating the Activity time? If so, it makes it look like a bug in Discourse that it can't sort properly.
-
Do whispers bump a topic without visibly updating the Activity time? If so, it makes it look like a bug in Discourse that it can't sort properly.
Please file a bug report on meta.d.
-
I think deleted posts have the same problem. So it's "not a whisper bug". :jeff:.
-
Who wants to start a pool on when this guy gets anon'd?
-
I love this:
The performance hit was about rendering the images in the first place (CPU) not network.
Well, if Discourse would stop wasting so much damned resources otherwise, maybe there would be plenty of CPU time left for rendering avatars.
Isn't the whole idea of clientside MVVM fad to reduce the server load?
Filed under: Yes, I'm aware of other benefits too, but they like to push the "offloading work" angle IME
-
Who wants to start a pool on when this guy gets anon'd?
He seems rational, I don't see how that could happe-
I'm not trying to armchair-engineer Discourse for you...
<Dammit Discourse, I want a space here!
I'm not sure you've considered the concrete suggestions I made at the end of my last comment...
Oh yeah, he's getting banned.
-
The next time one of the "long name hijacking" bugs regress, someone should
exploitresponsibly use them on meta.d to randomly change people to "I Stand with WTDWTF" or "Remember WTDWTF" or "When will they ban you"
-
Well, if Discourse would stop wasting so much damned resources otherwise, maybe there would be plenty of CPU time left for rendering avatars.
Or just deal with the avatar generation differently. Or deal with avatars differently. Or lots of solutions that aren't an avatar CDN.
-
My wish would be that at some point in the future, such privacy concerns will be taken into consideration more seriously.
Haha. Good luck. Unless you pay mad dollars to JeffCo™.
-
deal with the avatar generation differently
There's literally 26 letters of the alphabet, and a handful of colors. Couldn't they just make a handful of spritesheets with the alphabet on a solid background and ship them with Discourse? CPU time: 0.
-
-
I'm not sure doing stuff on registration using GDI would be that bad.
Unless they never save the letter avatars and requests are just routed to a gener... no, nobody is that stupid!
Right? Right?
-
Couldn't they just make a handful of spritesheets with the alphabet on a solid background and ship them with Discourse?
Of course. If they weren't Discodevs.
Even if they want their fancy lots of colours - the image only needs fucking generating once (per size) when the user signs up, and then stored on the server. Job done. How much CPU time does a coloured square with a fucking letter on it really need?
-
Sam's official response:
you can submit a PR
But you probably already knew he would say that.
-
Unless they never save the letter avatars and requests are just routed to a gener... no, nobody is that stupid!
I think that's exactly what they do.
-
Sam's official response
I'm sure my suggestion would be met with the same official response Jeff gave our other bug reports
-
https://meta.discourse.org/t/optimizing-letter-avatar-rendering/33082
Note that the avatar CDN (option 4 - already identified as NOT THE SIMPLEST) has "people may have privacy concerns" as a con.
They expected this, did it anyway, and fucking shock horror... look what happened.
-
I think that's exactly what they do.
-
Wait... did someone with a letter avatar post in
/t/1000
?Could that... oh FFS
-
@sam said:
But, we can not afford to spend dev time on this at the moment
HAHAHAHAHAHAHAHAHAHA@sam said:and I am not going to accept a performance hit here.
*gasp* HAHAHAHAHAHAHAHAHAHAHAHAHAHA.Wow. No self-awareness at all.
-
Transpires they generate it on user sign up, and cache it. And then the cache gets deleted every time there's a container rebuild. And it goes through 7 layers of Ruby hell just to serve an image of a letter on a square.
-
Showing user avatars shows up near the top of the performance reports:
Top 100 routes by Server Load Route Duration Reqs Mobile ----- -------- ---- ------ topics/show 89892.09 70212 3241 (4.62)% topics/timings (POST) 85895.54 130092 12041 (9.26)% posts/show 48931.00 47782 1827 (3.82)% user_avatars/show 24326.48 43713 8287 (18.96)% topics/posts 23429.28 43973 1994 (4.53)%
Top 30 users by Server Load Username Duration Reqs Routes -------- -------- ---- ------ [Anonymous] 88453.62 108237 topics/show(29121.43) - (POST)(19288.11) user_avatars/show(14345.65) -(7692.71) list/latest(4471.77)
No, this has never made sense to me, either, but I think it helps explain why they came up with this crazy scheme for CDN-ing a picture of a letter.
-
I can't top letter-avatar generation....
but (is this even the right place for this complaint, there are so many to pick from...)
ONE: after some update or other I now have to 1) realize that I'm
logged outnot logged in because I'm told I can't do something 2) actually logout 3) log back in. - five to ten times a day. THX!!TWO: IRONY - after the most recent update THEY HAVE MOVED THE LOGOUT BUTTON to make this stupidity even more cumbersome. MORONS!
THREE: WHY DID YOU ALLOW ME TO BEGIN TO REPLY IF I"M NOT ALLOWED TO?? and then trash my reply, and now I can't even find @poly's thread on freaking trucks because it's not new anymore and where did it go?
Yes, Jeff, WE are the problem, not you. Obviously.
-
Also - this has been discussed before.
Why is "Sign Up" and "Remind..." a link that looks like a button, but "no, thanks" a link that looks like a link?
-
No, this has never made sense to me, either, but I think it helps explain why they came up with this crazy scheme for CDN-ing a picture of a letter.
What about
user_avatars/show_letter
?
-
a link that looks like a button
Necessary evil if you want it to gracefully degrade when JavaScript is not avail...
Oh.
-
ONE: after some update or other I now have to 1) realize that I'm logged outnot logged in because I'm told I can't do something 2) actually logout 3) log back in. - five to ten times a day. THX!!
Sorry, my bad. I tried to use the new shadowban feature, but, well...it's a discourse feature, so it doesn't really work.
-
What about user_avatars/show_letter?
Oh, right, forgot that was two different things:
Top 100 routes by Server Load Route Duration Reqs Mobile ----- -------- ---- ------ topics/show 89892.09 70212 3241 (4.62)% topics/timings (POST) 85895.54 130092 12041 (9.26)% posts/show 48931.00 47782 1827 (3.82)% user_avatars/show 24326.48 43713 8287 (18.96)% topics/posts 23429.28 43973 1994 (4.53)% - (POST) 19288.11 1959 219 (11.18)% list/latest 8970.89 17562 836 (4.76)% post_actions/create (POST) 8730.20 8508 567 (6.66)% - 7692.71 2547 66 (2.59)% posts/create (POST) 6993.65 1893 221 (11.67)% draft/update (POST) 6693.98 9912 1339 (13.51)% notifications/index 4302.58 6211 385 (6.20)% users/show 3745.40 767 44 (5.74)% user_avatars/show_letter 3701.79 9234 1263 (13.68)%
We don't have too many letter people around here. So I guess that's even worse that it's so difficult to serve up the avatars. I mean...I get that they have to resize them sometimes, but most of us don't change that often.
-
shadowban
I thought the first rule of shadowban is...
...wait, I can't say it, can I?
-
Yeah but 19% + 14% of the load for serving what should be a static image in either case?
That's retarded, even on Discolevels.
-
Yeah but 19% + 14% of the load for serving what should be a static image in either case?
I think those percentages are about how many of the requests were mobile. Which in no way excuses the amount of time spent on avatars.
-
No, this has never made sense to me, either,
Everypageinfiniload, for every user with a post in the hunk, as well as every quote (since it's in the cooked post), as well as every time someone replies to a post (both for the editor and for the "in reply to" thing near the date) they do a database hit to make sure the avatar ID requested was one originally belonging to the username it's being associated with, take either that one or their latest one, and fork to ImageMagick to scale it to the requested size, assuming it's not cached (it usually isn't). That's why.Oh, and for letters? That's a hash (wouldn't be surprised if that was also a fork) of username, e-mail address, few other things, to come up with two colors. These and the first letter are passed to a forked ImageMagick to generate the avatar and prepopulate the cache, which gets frequently blown away.
-
I think those percentages are about how many of the requests were mobile.
Ah. I see.
-
-
Why is "Sign Up" and "Remind..." a link that looks like a button, but "no, thanks" a link that looks like a link?
They feel obligated to put a "no thanks" in there, but they really don't want anyone to actually click it, so they hide it in a corner and make it not stand out. Duh.
Filed under: why not make it the FA trashcan icon,
0.5em
, andrgb(0,0,0,0.05)
?
-
people may have privacy concerns
Maybe I'm remembering wrong, but wasn't that why they changed their Gravatar support, because it could effectively do the same thing that their current Avatar CDN can do?
-
Quite likely.
-
After we made a big deal of it, too. Might be other factors / users too, but I do remember TDWTFers making a fuss about that.
-
I can't even find @poly's thread on freaking trucks because it's not new anymore and where did it go?
You should have hit the Back history button... OH WAIT.
-
-
They should do it in JS on canvas, client-side, and then upload it like any other avatar.
-
Too simple.
-
Also, JS on canvas is unlikely to corrupt the color like Imagemagick.
-
Also, JS on canvas is unlikely to corrupt the color like Imagemagick.
Simple and works better?
That's not very Discourse.