Jeffing 233 posts sucks.
-
The dialog grows to cover most of the screen, so I can't see what I'm selecting, and the buttons go off the page, so I had to tab and hit enter blindly. That's an awful UX.
-
@Yamikuronue said in Jeffing 233 posts sucks.:
The dialog grows to cover most of the screen,
Huh. Wat. The dialog doesn't use scrolling overflows?
-
@Tsaukpaetra Nope. Very few things do.
-
@Yamikuronue And you have to click every single post.
-
@Yamikuronue and you didn't try to css-whip it into submission?
-
@aliceif Exactly! Discourse at least had "select + replies". I want "Select recursive: Every reply to this post, every reply to those replies, and so on down the whole chain"
-
-
@Yamikuronue said in Jeffing 233 posts sucks.:
Discourse at least had "select + replies".
Which disappeared on selected replies, of course.
-
For the record, this is what the dialog looks like:
There are a lot of rough edges due to not considering the typical thread lengths that we have around here.
-
@boomzilla That's… just awful.
-
@boomzilla Is that a list of all posts in the topic, and you click those? Or do you click elsewhere and that's a list of the ones you have clicked?
Is the post ID even visible elsewhere? How would you know which post 882353 is?
-
@loopback0 The list grows as you click on posts. No, the post id isn't visible anywhere, though the posts get greyed out when they're selected.
-
@boomzilla That's not as bad as it could have been, I guess.
-
@loopback0 Needs more
-
@Yamikuronue said in Jeffing 233 posts sucks.:
Every reply to this post, every reply to those replies, and so on down the whole chain
That's a problem in NodeBB, as that's usually not tracked very well at all....
-
@Yamikuronue said in Jeffing 233 posts sucks.:
@aliceif Exactly! Discourse at least had "select + replies". I want "Select recursive: Every reply to this post, every reply to those replies, and so on down the whole chain"
Discourse actually tracked replies to posts. Not sure how difficult that would be in NodeBB. I mean, it does have that thing, but it can only point to one post and it may not necessarily even be correct. Tracking actual replies to posts would probably be almost impossible since they're actually just an @mention with some extra syntactical sugar.
@boomzilla said in Jeffing 233 posts sucks.:
posts get greyed out when they're selected
In that case, it'd make sense to just put a red boob on it. Hide it, highlight all the posts you want to move, unhide it and do stuff. Fill out the new thread title at some point before you hit Fork.
-
@boomzilla Sure sounds like it needs less wharrgarbl.
-
@anotherusername said in Jeffing 233 posts sucks.:
Not sure how difficult that would be in NodeBB
I would go with "quite", since it would effectively mean parsing the post content for links (which are topic-relative for some reason), match the current post, then for posts that match, rinse and repeat all the way down.
-
@Tsaukpaetra A lot of it could be got by following the things. Probably enough for a considerable improvement over what's there now.
-
@Tsaukpaetra The real issue is that links are based on post index, not post id. Post index can change with Jeffing or user sorting.
-
@boomzilla said in Jeffing 233 posts sucks.:
or user sorting
Oh god, I hadn't even thought of that.
...tested and it appears that it does, at least, make the numbers count backward instead of forward if you sort from "Newest to Oldest", so the links still work in that view. But if you sort by "Most Votes", they break horribly.
-
@anotherusername Yep. I discovered that when I was working on updating last read positions after Jeffing.
-
Reply made while viewing by "Oldest to Newest":
@boomzilla said in Jeffing 233 posts sucks.:
Needs more
Reply made while viewing by "Newest to Oldest":
@boomzilla said in Jeffing 233 posts sucks.:
Needs more
Reply made while viewing by "Most Votes":
@boomzilla said in Jeffing 233 posts sucks.:
Needs more
...fuuuuuuuuuuuck. So effectively, anyone who chooses to sort by "Most Votes" is living in limbo-land where the numbers don't mean the same thing as they do here.
I move to disable "Most Votes" sorting entirely. Does anyone actually use that? I realize we're breaking the workflow of the guy who was rapidly changing it back and forth to heat his cubicle, but does anybody legitimately use it?
At least until someone can figure out how to switch from these relative post links to something that doesn't change with the tides?
-
@anotherusername said in Jeffing 233 posts sucks.:
I move to disable "Most Votes" sorting entirely. Does anyone actually use that? I realize we're breaking the workflow of the guy who was rapidly changing it back and forth to heat his cubicle, but does anybody legitimately use it?
I guess it could be useful for suggestion threads or code challenges ..?
-
-
@anotherusername said in Jeffing 233 posts sucks.:
where the numbers don't mean the same thing as they do here.
Welcome to Whose Reply Is It Anyway, the show where every quote's made up and the numbers don't matter
-
@Yamikuronue ugh. I think @Fox would like it there. Mostly just because he already thinks he lives there and he'd be right about something for once.
-
@anotherusername said in Jeffing 233 posts sucks.:
he'd be right about something for once.
Not even then.
-
@RaceProUK said in Jeffing 233 posts sucks.:
@boomzilla That's… just awful.
He totally deserves it. But @Yamikuronue and @aliceif shouldn't be subjected to such torture.
-
@Fox Keep it in the guacamole thread please
-
@RaceProUK said in Jeffing 233 posts sucks.:
@Fox@anotherusername @FrostCat Keep it in the guacamole thread pleaseFTFY
-
How about all of you shut the fuck up before I have to jeff another 233 posts?
-
@Yamikuronue Please be sure to fill out the appropriate change request forms in triplicate, and make sure the Jeffing is run through Dev and QA before executing in production.
-
@boomzilla said in Jeffing 233 posts sucks.:
The real issue is that links are based on post index, not post id. Post index can change with Jeffing or user sorting.
Fuuuuuck
-
@loopback0 said in Jeffing 233 posts sucks.:
@boomzilla said in Jeffing 233 posts sucks.:
The real issue is that links are based on post index, not post id. Post index can change with Jeffing or user sorting.
Fuuuuuck
I see the problem. You're moving them instead of deleting them. You should delete the posts instead. Nobody wanted to read them anyway. That's why you moved them.
-
@DogsB What are you, some kind of Jeff-fbmac hybrid?
-
@loopback0 said in Jeffing 233 posts sucks.:
@DogsB What are you, some kind of Jeff-fbmac hybrid?
Behold I am become Jeffmac destroyer of forums.
Calling @Onyx for a wittier phrase!
-
@DogsB Huh? Since when have I become the authority on witty phrases?
Wait... do I get paid?
-
@Onyx said in Jeffing 233 posts sucks.:
@DogsB Huh? Since when have I become the authority on witty phrases?
Wait... do I get paid?
No. See it as practice for when you leave your job to pursue a career in headline writing.
Also calling @Lorne-Kates. We need a little bit of monetary advice apparently!
*edit spellar! appearently wtf... the spellcheck even catches it.
Also!
Also! Osla!
indeed!
-
Quick response:
Though...the quote links need to be updated now.
-
@boomzilla Chaching!
-
-
-
@El_Heffe It's fixed for new replies, but that's not going to fix old stuff.
-
@boomzilla Elementary programming mistake: taking meta-data (what post is this a reply to?) and converting it into data (text of the post).
-
@blakeyrat That's not what happened. They were just referencing the post by its index in a topic, which can change instead of the unique post id.
-
@boomzilla said in Jeffing 233 posts sucks.:
They were just referencing the post by its index in a topic
Right, which (at the time) was perfectly cromulent (and, indeed, the only way, because there was no /post/ route to identify a particular post)
-
@boomzilla said in Jeffing 233 posts sucks.:
@El_Heffe It's fixed for new replies, but that's not going to fix old stuff.
What about notifications? When I click on the link it doesn't always take me to my post that was mentioned or upvoted. Sometimes it's only off by a couple of posts, sometimes it drops me into No-Mans-Land where there is no post of mine in site.
-
@Tsaukpaetra said in Jeffing 233 posts sucks.:
@boomzilla said in Jeffing 233 posts sucks.:
They were just referencing the post by its index in a topic
Right, which (at the time) was perfectly cromulent
At what time?
-
@anotherusername said in Jeffing 233 posts sucks.:
Not sure how difficult that would be in NodeBB
Very. Since I asked if they can (and Ben upstreamed it). And the reply was "huh, we never even thought of that!"
Nothing has happened since.
Because "select post_id as RepliesToThisPost FROM posts WHERE toPid = @thisPostPID" is super difficult and a completely unknown and untested database retrieval theory.