Discussion of NodeBB Updates
-
@zecc said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@zecc Make a PR then.
What do you think my post above was?
Not a PR, AKA the thing I did to get that warthog emoji here in the first place.
-
@loopback0 said in Discussion of NodeBB Updates:
@zecc It's supposed to be flipped. That's what it is.
-
@ben_lubar said in NodeBB Updates:
- Modified user settings to use the core functionality.
Ah, so your failure is why I've been getting a notification for every upvote all the sudden. Gotcha.
-
@tsaukpaetra said in Discussion of NodeBB Updates:
I've been getting a notification for every upvote all the sudden
BRB, gotta do something. Paybacks are hell.
-
@polygeekery said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
I've been getting a notification for every upvote all the sudden
BRB, gotta do something. Paybacks are hell.
Too late, I re-fixed it by setting the...
The fuck?
I bet there's a topic on Bugs about that already...
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
I've been getting a notification for every upvote all the sudden
BRB, gotta do something. Paybacks are hell.
Too late, I re-fixed it by setting the...
The fuck?
I bet there's a topic on Bugs about that already...
Set language to en-GB if you want unmerged pull requests to have translations.
-
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
I've been getting a notification for every upvote all the sudden
BRB, gotta do something. Paybacks are hell.
Too late, I re-fixed it by setting the...
The fuck?
I bet there's a topic on Bugs about that already...
Set language to en-GB if you want unmerged pull requests to have translations.
What do you expect
upvote-notif-freq.threshold
to translate to? Isn't that a dynamic site setting?Testing...
Ah... Hmmm.....
-
@tsaukpaetra said in Discussion of NodeBB Updates:
Ah... Hmmm.....
Also, I kinda miss the "and X others" part of the notification...
-
Good news, we're merged: https://github.com/NodeBB/NodeBB/pull/6640#event-1744940047
-
@ben_lubar
You reduced code coverage by -0.2%/giphy shame
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar
You reduced code coverage by -0.2%/giphy shame
code coverage went up on one of the six builds: https://coveralls.io/builds/17899108
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar
You reduced code coverage by -0.2%/giphy shame
So he increased it by +0.2%?
-
-
@TwelveBaud Dunno why it's showing blank for line 13; there are actually more lines of code there:
-
@TwelveBaud said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Code Climate, were you dropped on your head as a child?
if(real) return real; /* snip */ real = pubsub; return pubsub;
There, it's much more readable now!
Seriously, I understand the idea behind this rule, but seriously, making code more readable is an error? Or should you refactor a one-off if into a function as well?
Bloody hell people.
Filed under: function checkIfThisSpecificThingIsTrue(thing)
-
-
-
Click one notification:
@PJH said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Hmm. Is that really wise?
Click the next notification:
@anotherusername said in In other news today...:
And vaginas, and penises, and naked babies, and scrolling through his Wikipedia article, I noticed one of his works prominently mentioned that the naked lady he painted was being raped in the painting.
But sure, what you said.
-
@TwelveBaud said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Code Climate, were you dropped on your head as a child?
The book code complete pointed to research that claimed that you can go up to 200 lines without a negative impact on bugs and productivity. Reducing function size reduced productivity, iirc.
Anyway, a 25 line limit is clearly retarded.
-
Testing something.
-
@e4tmyl33t said in Discussion of NodeBB Updates:
Testing something.
Was it how fast I would come to upvote your post?
-
@Tsaukpaetra Negative. See https://what.thedailywtf.com/topic/25458/x-replies-dropdown-shows-doubled-count-for-popcorn-replies/
Was testing if removing the quoted portion of a popcorn quote still counted in the original thread as one or two replies in the dropdown box counter.
-
@ben_lubar said in NodeBB Updates:
Fix for the IP address hashing thing coming soon.
Note to @administators: one of the server's cores will be used by PostgreSQL for a while the SHA1 hashes are being "reversed". Don't stop it.
It shouldn't affect forum performance by any noticeable amount while it runs.
What's going to happen when we move over to IPv6?
-
@PJH said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Fix for the IP address hashing thing coming soon.
Note to @administators: one of the server's cores will be used by PostgreSQL for a while the SHA1 hashes are being "reversed". Don't stop it.
It shouldn't affect forum performance by any noticeable amount while it runs.
What's going to happen when we move over to IPv6?
The system will continue to work because it records new IP hashes automatically.
-
@ben_lubar said in NodeBB Updates:
Fix for the IP address hashing thing coming soon.
Note to @administators: one of the server's cores will be used by PostgreSQL for a while the SHA1 hashes are being "reversed". Don't stop it.
It shouldn't affect forum performance by any noticeable amount while it runs.
Ok, the temporary table has 1197436 rows. That's 1197436 hashes. I'll reply again when it finishes with the number of rows in the mapping table (which might be higher due to new guest IPs or lower due to the garbage data that's in there).
-
Yay! My PR was finally merged into the forum! Now we can quote and reply and not have to manually correct the name of the person we're quoting/replying to.
-
@djls45 Oh that's finally been fixed! Bravo.
-
@djls45 said in Discussion of NodeBB Updates:
Yay! My PR was finally merged into the forum! Now we can quote and reply and not have to manually correct the name of the person we're quoting/replying to.
Okay, but, I mean, you didn't have to...
-
@loopback0 said in Discussion of NodeBB Updates:
Yay! My PR was finally merged into the forum! Now we can quote and reply and not have to manually correct the name of the person we're quoting/replying to.
Wait, was this a problem?
-
@Zecc said in Discussion of NodeBB Updates:
@loopback0 said in Discussion of NodeBB Updates:
Yay! My PR was finally merged into the forum! Now we can quote and reply and not have to manually correct the name of the person we're quoting/replying to.
Wait, was this a problem?
Yes, it would stop certain members from being @mentioned for raisins. Because being @mentioned is important. Or something.
-
@Tsaukpaetra no, this is a different thing. Click his PR link and decypher what he changed.
-
@anotherusername said in Discussion of NodeBB Updates:
@Tsaukpaetra no, this is a different thing. Click his PR link and decypher what he changed.
See, I thought it was the capitalization thing, but then I did read it, and changed my idea...
-
@Tsaukpaetra it was the capitalization thing. As far as I know, it didn't break anyone's mentions.
-
@anotherusername said in Discussion of NodeBB Updates:
@Tsaukpaetra it was the capitalization thing. As far as I know, it didn't break anyone's mentions.
Well... um... Ok.
So long as someone is now happier I suppose...
-
@tsaukpaetra test
@Tsaukpaetra hmm, both got linked
-
@Tsaukpaetra I am. Thank you for your encouragement. :)
-
I have this thread set to watching, yet none of the posts in here today have generated a notification.
-
@Erufael Do you have it open on some other browser somewhere?
-
@Jaloopa Nope. I did get a notification that you posted to this thread this time, but not that you mentioned me.
-
@Erufael said in Discussion of NodeBB Updates:
have generated a notification.
Usually happens in the Status Thread for me. I'm in another thread, see the toaster that someone posted, but the notification is immediately marked read.
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
Yes, it would stop certain members from being @mentioned for raisins. Because being @mentioned is important. Or something.
I think it's over-rated...
-
@mention said in Discussion of NodeBB Updates:
@Tsaukpaetra said in Discussion of NodeBB Updates:
Yes, it would stop certain members from being @mentioned for raisins. Because being @mentioned is important. Or something.
I think it's over-rated...
It's OK, you can @mention me any time. Every time some of the times I'm @mentioned I will upvote them. Whoever @mentions me the most might get a !
-
@Tsaukpaetra
What does downvoting get me?
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
Whoever @mentions me the most might get a !
Hello?
-
@Luhmann said in Discussion of NodeBB Updates:
@Tsaukpaetra
What does downvoting get me?A highly-collectible icon of @boomzilla
EDIT: A post-lunch nap is threatening to take over, I read it as "What does downvoting me get?"
-
@Luhmann said in Discussion of NodeBB Updates:
@Tsaukpaetra
What does downvoting get me?Nothing, I can't tell who downbotes me.
-
@mentions said in Discussion of NodeBB Updates:
@Tsaukpaetra said in Discussion of NodeBB Updates:
Whoever @mentions me the most might get a !
Hello?
Hello there!
-
@Tsaukpaetra
You can't? For me it always seems to be this boomzilla tranny
-
-