Discussion of NodeBB Updates
-
@benjamin-hall huh, just 1 hour now? I was under the impression that it was still set to 7 days or something.
-
Can we get rid of the red boob on mobile? It frequently ends up where I need to tap the screen and that is annoying.
-
.taskbar[data-active="1"] { display: none !important; }
'course, that disables it for Desktop too...
Filed under: I take no responsibility for my CSS haxor skillz
-
@tsaukpaetra That's why you wrap it in a media tag:
@media (max-width: 991px) { .taskbar[data-active="1"] { display: none !important; } }
991px is when it cuts over to the "mobile style" composer.
-
@anotherusername said in Discussion of NodeBB Updates:
@benjamin-hall huh, just 1 hour now? I was under the impression that it was still set to 7 days or something.
I don't actually know. I just know enough to blame @fbmac for all deleting/necroing-related issues.
-
@chaostheeternal said in Discussion of NodeBB Updates:
991px is when it cuts over to the "mobile style" composer.
-
The new progress bar thing is shit. It duplicates the scroll bar and removes the visual indicator there used to be that there were more posts but the socket had fucked up.
Also, the red boob on mobile is a big red button exactly where you're looking on the screen, so I keep pressing it to post without thinking
-
@polygeekery Everyone knows all the cool people browse at 988 px.
-
@anotherusername This is fixed in 1.7.2, it will say
Home
on/
andRecent Topics
when you go to/recent
-
@barisu said in Discussion of NodeBB Updates:
@anotherusername This is fixed in 1.7.2, it will say
Home
on/
andRecent Topics
when you go to/recent
E_NO_REPRO
though since i have Recent topics set to my home page this observed behavior is correct as far as i'm concerned.
Not So Fake Edit: Oh..... you meant upcoming relase, not latest...... Still. My point it hink stnads. if i'm on recent topics my title should be Recent, no?
-
@accalia Yeah it will be available in 1.7.2, and yes if you are on
/recent
title will beRecent Topics
but if you are on/
and the homepage is displaying the same thing the title will beHome
(or something the admin can specify in the ACP )
-
@barisu said in Discussion of NodeBB Updates:
@accalia Yeah it will be available in 1.7.2, and yes if you are on
/recent
title will beRecent Topics
but if you are on/
and the homepage is displaying the same thing the title will beHome
(or something the admin can specify in the ACP )harumph. i still say if there isn't a distinct home page the title should be what the page is.
not that i ever look at the title, the favicon is right so i know the tab is right.
still. harumph.
:-P
-
-
@ben_lubar
Ooh, more protests for the warthog. Now he can protest unforking the forums.
-
I'd just like to point out that we've supported forking since 0.2 or thereabouts. Just goes to show that it's easy to take thing apart but hard to put it back together again
-
Hey guess who can't log into the staging forum to test the update!
-
@julianlam said in Discussion of NodeBB Updates:
I'd just like to point out that we've supported forking since 0.2 or thereabouts. Just goes to show that it's easy to take thing apart but hard to put it back together again
I beg to differ. I can make a WAY bigger mess picking a thread apart than mashing two together.
-
Well, that bumped up the severity of https://github.com/NodeBB/NodeBB/issues/6152
Looks like @baris reverted it, I'll write the upgrade script tomorrow
-
@julianlam if it's any consolation, I never liked underscores anyway. Especially the one we're too afraid to remove from my username.
-
@ben_lubar said in Discussion of NodeBB Updates:
for ... scientific purposes a mod should merge the likes thread with uhmm... the status thread?
-
why would you move the menu that’s been on the right side since day freaking one to the left side!?!?!?!
:mckaylamaroney.meme:
@julianlam i must now ritually stalk you on the inter webs for breaking my workflow.
—-
Seriously though, that’s a really really jarring change. And I find it odd to move the menu and leave chats, which are basically miss or miss on mobile, behind in the prime real estate. Any particular reason you didn’t just eject chats to the left side?
-
@izzion said in Discussion of NodeBB Updates:
left side!?!?!?!
whoa...yeah this is gonna take some getting used to
-
@izzion said in Discussion of NodeBB Updates:
why would you move the menu that’s been on the right side since day freaking one to the left side!?!?!?!
:mckaylamaroney.meme:
@julianlam i must now ritually stalk you on the inter webs for breaking my workflow.
—-
Seriously though, that’s a really really jarring change. And I find it odd to move the menu and leave chats, which are basically miss or miss on mobile, behind in the prime real estate. Any particular reason you didn’t just eject chats to the left side?
Yeah, that didn't occur to me when he unmentioned the new page-drag handling.
Also, what's with the header?
-
@tsaukpaetra said in Discussion of NodeBB Updates:
Also, what's with the header?
I added some ‼EMERGENCY CSS‼ that moves the mobile composer down by 50 pixels so people can hopefully reach the buttons.
-
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
Also, what's with the header?
I added some ‼EMERGENCY CSS‼ that moves the mobile composer down by 50 pixels so people can hopefully reach the buttons.
I'd rather the bodge just make the header z-level under the mobile composer, but as I understand it that's not very easy to do...
-
@ben_lubar said in Discussion of NodeBB Updates:
Hey guess who can't log into the staging forum to test the update!
I guess @LB_.
-
what the fuck why is the menu on the left side
It didn't even work right the first time. I push it, it opens chats. I push it again, it reloads the page. I push it again, it inexplicably leads me to the status thread. I push it again, it finally fucking opens.
-
Posting from mobile is tricky when you only have half of the post buttons visible
-
I don't want to go all Blakey here, and I generally have quite a high opinion of @julianlam, but seriously the only way this menu location cockup could have happened is if literally nobody tested to the extent of trying to post one message from mobile. Just opening the composer immediately displays the bug, so presumably all of the testing was of a similar vein to what we did when asked, of running the page and swiping around a bit
-
Seems like the emoji are now classed "emoji-emoji-one" instead of "emoji".
Is this going to be definitive? I take no pleasure in having to edit my custom CSS.The
data-emoji-id
attribute is gone too, there's anemoji--
whatever class instead.--
Okay, just noticed this:
@ben_lubar said in NodeBB Updates:
- NodeBB has a different default emoji plugin now, so there may be some turbulence around the time of the update because it won't default to our usual set during the update process. (It will be back to normal shortly.)
-
@julianlam said in Discussion of NodeBB Updates:
I'd just like to point out that we've supported forking since 0.2 or thereabouts. Just goes to show that it's easy to take thing apart but hard to put it back together again
What's missing is the ability to move multiple posts at once to an existing thread.
-
-
@ben_lubar said in NodeBB Updates:
- NodeBB has a different default emoji plugin now, so there may be some turbulence around the time of the update because it won't default to our usual set during the update process. (It will be back to normal shortly.)
And suddenly all the emoji are really big, except for a few which are enormous, such as
-
@masonwheeler said in Discussion of NodeBB Updates:
And suddenly all the emoji are really big
Until you refresh your styles
This post may have been just an excuse to post a giant emoticon
-
@jaloopa said in Discussion of NodeBB Updates:
I don't want to go all Blakey here, and I generally have quite a high opinion of @julianlam, but seriously the only way this menu location cockup could have happened is if literally nobody tested to the extent of trying to post one message from mobile. Just opening the composer immediately displays the bug, so presumably all of the testing was of a similar vein to what we did when asked, of running the page and swiping around a bit
Yep. That was a pretty good cockup.
I miss the days when we used to test before we...
Scratch that. I long for the future where we will test shit before deploying it.
-
@polygeekery said in Discussion of NodeBB Updates:
the future where we will test shit before deploying it
uhuh. Is that the same future where countries have leaders who aren't incompetent, crooked or downright insane, everyone goes to work via hyperloop and I'm a millionaire?
-
@jaloopa said in Discussion of NodeBB Updates:
uhuh. Is that the same future where countries have leaders who aren't incompetent, crooked or downright insane, everyone goes to work via hyperloop and I'm a millionaire?
I see more hope for point #1 than for #2 and #3.
-
@polygeekery said in Discussion of NodeBB Updates:
I long for the future where we will test shit before deploying it.
a fever dream..... but one i too wish for.
-
the Quixotic Ideas Thread is
-
For those who are wondering, you should be able to swap the top buttons via the user settings page.
We've been running this code on our community site for quite awhile, so not only has this code been tested, it's been tested live, too, so I'm surprised you're seeing composer issues right now, to be honest.
-
Is it theme related? I use Darkly and from what I've seen of other screenshots, some themes hide the post buttons entirely.
Does the community site have different themes?
-
@jaloopa said in Discussion of NodeBB Updates:
Is it theme related? I use Darkly and from what I've seen of other screenshots, some themes hide the post buttons entirely.
Does the community site have different themes?
I use no theme.
-
@boomzilla said in Discussion of NodeBB Updates:
What's missing is the ability to move multiple posts at once to an existing thread ... in one step.
-
@julianlam said in Discussion of NodeBB Updates:
For those who are wondering, you should be able to swap the top buttons via the user settings page.
We've been running this code on our community site for quite awhile, so not only has this code been tested, it's been tested live, too, so I'm surprised you're seeing composer issues right now, to be honest.
I know I'm supposed to piss on NodeBB for the problems, but this particular set of problems sounds an awful lot like issues with our TDWTF customizations. That or issues with certain themes (you do also test on themes other than default, right?).
-
@anotherusername said in Discussion of NodeBB Updates:
I know I'm supposed to piss on NodeBB for the problems, but this particular set of problems sounds an awful lot like issues with our TDWTF customizations. That or issues with certain themes (you do also test on themes other than default, right?).
-
@ben_lubar said in NodeBB Updates:
- Because ctrl+enter is core functionality for the composer now, I've removed the "shortcuts" plugin that we were using only for that.
Was that the plugin that all let us select text and then CTRL+L to make a link? Because I definitely used it for that a lot. I have only ever used CTRL+ENTER on accident and cursed the functionality.
-
@jaloopa said in Discussion of NodeBB Updates:
Is it theme related? I use Darkly
That's a skin, provided by Bootswatch, and while people do use them, it's become harder to support and fix given how it is loaded onto NodeBB (as a CSS file dynamically loaded), it conflicts with any theme customizations we make to vanilla bootstrap, which... we do a fair bit of.
The unfortunate reality is we might need to remove skins entirely in a future version of NodeBB, but I want to be clear -- we probably wouldn't do it unless we had a "dark mode" baked in to replace it.
-
@julianlam said in Discussion of NodeBB Updates:
The unfortunate reality is we might need to remove skins entirely in a future version of NodeBB, but I want to be clear -- we probably wouldn't do it unless we had a "dark mode" baked in to replace it.
Or you could support it natively in a proper css-oriented way independent of whatever Bootstrap skins are available. But that sound like work
-
@julianlam said in Discussion of NodeBB Updates:
it's become harder to support and fix given how it is loaded onto NodeBB
Yeah, there are a few annoyances I just put up with, like the post count in the mobile progress bar being invisible if you're less than halfway through a topic (or screen now. Still not happy with that change)
-
@jaloopa said in Discussion of NodeBB Updates:
progress bar
I just noticed the progress bar seems to have reverted to the useful version from before.