Testing breaking update for NodeBB
-
@boomzilla said in The Official Status Thread:
@ben_lubar said in The Official Status Thread:
Fixed three days ago, not merged because there's also a change to how likes/bookmarks work and I want @boomzilla to make sure it won't explode his plugin.
Oh...is that what that PM was about? Hmm...I don't think that will mess with my plugin at all, since it didn't mention votes...but I guess I'll check it out...
./nodebb upgrade ... ... processing pid 1 processing pid 2 ....
-
Ayup...I guess I forgot that votes were in the
favourites
module.
-
@boomzilla said in Testing breaking update for NodeBB:
Ayup...I guess I forgot that votes were in the
favourites
module.Well that's why they renamed it, because it was a , right?
-
@Tsaukpaetra said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
Ayup...I guess I forgot that votes were in the
favourites
module.Well that's why they renamed it, because it was a , right?
They renamed all their translation strings, too.
-
@ben_lubar said in Testing breaking update for NodeBB:
@Tsaukpaetra said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
Ayup...I guess I forgot that votes were in the
favourites
module.Well that's why they renamed it, because it was a , right?
They renamed all their translation strings, too.
Well, yay for improvements, right?
Have they started building a RDMS-compatible schema so we can use
normalreal databases again?
-
@Tsaukpaetra said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
@Tsaukpaetra said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
Ayup...I guess I forgot that votes were in the
favourites
module.Well that's why they renamed it, because it was a , right?
They renamed all their translation strings, too.
Well, yay for improvements, right?
Have they started building a RDMS-compatible schema so we can use
normalreal databases again?From IRC a few days ago: https://docs.mongodb.com/manual/core/write-operations-atomicity/#transaction-like-semantics
Turns out MongoDB does have transactions, but they're not atomic.
In other news, I have this ice cream made entirely of warm grass clippings.
-
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have fake transactions, but they're not atomic.
FTFY.
-
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
if they're not atomic, they ain't transactions.
-
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
if they're not atomic, they ain't transactions.
Would you like some of my warm grass "ice cream"?
-
@ben_lubar said in Testing breaking update for NodeBB:
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
if they're not atomic, they ain't transactions.
Would you like some of my warm grass "ice cream"?
nah. i prefer meadow muffins. thanks
-
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
if they're not atomic, they ain't transactions.
Would you like some of my warm grass "ice cream"?
nah. i prefer meadow muffins. thanks
y'all have some weird kink foods, I'll tell you what...
-
@ben_lubar said in Testing breaking update for NodeBB:
In other news, I have this ice cream made entirely of warm grass clippings.
Mmmmmm...vegan ice cream....
-
@ben_lubar said in Testing breaking update for NodeBB:
@Tsaukpaetra said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
@Tsaukpaetra said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
Ayup...I guess I forgot that votes were in the
favourites
module.Well that's why they renamed it, because it was a , right?
They renamed all their translation strings, too.
Well, yay for improvements, right?
Have they started building a RDMS-compatible schema so we can use
normalreal databases again?From IRC a few days ago: https://docs.mongodb.com/manual/core/write-operations-atomicity/#transaction-like-semantics
Turns out MongoDB does have transactions, but they're not atomic.
In other news, I have this ice cream made entirely of warm grass clippings.
Don't you mean frozen non-dairy desert? You can't call it ice cream if it doesn't contain cream.
-
@dangeRuss said in Testing breaking update for NodeBB:
Don't you mean frozen non-dairy desert? You can't call it ice cream if it doesn't contain cream.
Do you have any strong opinions about ginger beer regulations?
Asking for a friend.
-
@boomzilla said in Testing breaking update for NodeBB:
@dangeRuss said in Testing breaking update for NodeBB:
Don't you mean frozen non-dairy desert? You can't call it ice cream if it doesn't contain cream.
Do you have any strong opinions about ginger beer regulations?
Asking for a friend.
I'm not aware of any ginger beer regulations. Please enlighten me.
-
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
This car has airbags. They just don't inflate. And they're located in the trunk. They face the road. Also, this isn't a car.
-
@boomzilla said in Testing breaking update for NodeBB:
Do you have any strong opinions about ginger beer regulations?
I never even read the thread this came from, but I still laugh every time.
-
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
@accalia said in Testing breaking update for NodeBB:
@ben_lubar said in Testing breaking update for NodeBB:
Turns out MongoDB does have transactions, but they're not atomic.
if they're not atomic, they ain't transactions.
Would you like some of my warm grass "ice cream"?
nah. i prefer meadow muffins. thanks
Cow turds? Not my thing, but whatever...
-
@Lorne-Kates I'll give you the tl;dr version:
: there's no difference between ginger beer and ginger ale. They mean the same thing.
: yes there is. They're clearly different products. They each have their own uniform characteristics.
: there are exceptions. The characteristics are not as clear-cut as you think.
: we need legislation to define what's ginger beer and what's ginger ale.
: no. We definitely do not.
: uh, what?
: WHAARGARBLE.
: here's a picture of a sexy redhead drinking beer1.
-
@Lorne-Kates said in Testing breaking update for NodeBB:
Also, this isn't a car.
Best car analogy EVER
-
@anotherusername said in Testing breaking update for NodeBB:
here's a picture of a sexy redhead drinking beer.
definitely the best part of the discussion
-
-
@Lorne-Kates said in Testing breaking update for NodeBB:
This car has airbags. They just don't inflate. And they're located in the trunk. They face the road.
Isn't that kind of what the C4 Cactus does?
-
@aliceif said in Testing breaking update for NodeBB:
what the C4 Cactus does
I thought the C4 Cactus sole goal was to be the ugliest car of this decade.
-
...and while I was in there I fixed the negative vote thing (which includes a new test)!
-
@boomzilla Is it my birthday?!
-
@boomzilla one problem: the newest version of NodeBB is 1.2.1, not 1.3.
-
@ben_lubar Right, the current version, which doesn't have the breaking change. They hooked this issue up to the 1.3 milestone. Which is still in the works. So while they haven't bumped the version yet, this should only be actually released in a 1.3 version of NodeBB.
Of course, we don't stick to just officially tagged and released versions so we're a little bit off. But if anyone is using that and sticking to actual versions, the 1.3 compatibility is correct (or should be correct when it actually happens). Anyone living on the bleeding edge like us will just have to install my plugin from github and live with the harmless warning message about the supported version number.
At least that's how I read the situation.
-
@Luhmann said in Testing breaking update for NodeBB:
I thought the C4 Cactus sole goal was to be the ugliest car of this decade.
Yeah but it only wins because the Multipla stopped production in 2010 (according to wiki), so it's the previous decade.
-
I think C4 Cactus looks quite fetching, actually. The white ones with black bubble-things especially.
-
@Onyx said in Testing breaking update for NodeBB:
looks quite fetching,
Well, yes we already established your sense in taste is off ...
-
@Onyx mine is purple with black bubble-things
-
@Jaloopa said in Testing breaking update for NodeBB:
@Onyx mine is purple with black bubble-things
You're supposed to clean that thing when you're done with it!
-
This post is deleted!
-
-
@dkf dafuq is it not rendering parts of the ground after the explosion?
-
@anotherusername said in Testing breaking update for NodeBB:
@dkf dafuq is it not rendering parts of the ground after the explosion?
java
And speaking of horrifically broken barely functional pieces of shit: is this "breaking update" for NodeBB responsible for the 5-10 second delay between me clicking something on the forum, and the thing actually happening (reply, votes, open a topic, etc)
-
@Lorne-Kates said in Testing breaking update for NodeBB:
is this "breaking update" for NodeBB responsible for the 5-10 second delay between me clicking something on the forum, and the thing actually happening (reply, votes, open a topic, etc)
No. The other day the youtube plugin was crashing (unrelated to this change) causing restarts which ate up our CPU credits with Amazon causing them to throttle our VM. That's happening again, though I have no idea why.
-
@boomzilla said in Testing breaking update for NodeBB:
@Lorne-Kates said in Testing breaking update for NodeBB:
is this "breaking update" for NodeBB responsible for the 5-10 second delay between me clicking something on the forum, and the thing actually happening (reply, votes, open a topic, etc)
No. The other day the youtube plugin was crashing (unrelated to this change) causing restarts which ate up our CPU credits with Amazon causing them to throttle our VM. That's happening again, though I have no idea why.
It's a good thing we have useful stack traces and helpful error messages to help diagnose and fix the problem.
...
Wait...
-
@boomzilla said in Testing breaking update for NodeBB:
The other day the youtube plugin was crashing (unrelated to this change) causing restarts which ate up our CPU credits with Amazon
The only way that should happen is if the youtube plugin connects to youtube server-side and re-streams the video through the forum.
Otherwise
-
@Lorne-Kates said in Testing breaking update for NodeBB:
The only way that should happen is if the youtube plugin connects to youtube server-side and re-streams the video through the forum.
Huh?
-
Question, did applying an update break being able to post in the comments on the main site when logged in to the forums?
-
@boomzilla said in Testing breaking update for NodeBB:
@Lorne-Kates said in Testing breaking update for NodeBB:
The only way that should happen is if the youtube plugin connects to youtube server-side and re-streams the video through the forum.
Huh?
The youtube plugin is a client-side thing, isn't it? Dumboxing Youtube links and decorating them with the video's name.
So if it's a client-side plugin, it shouldn't suck up copious amounts of SERVER resources, even if the plugin is misbehaving.
The only way I can see a Gootube plugin going so wild that it kills an AWS is if the plugin ran server-side, and instead of just retrieving metadata about the video-- it downloaded the entire video to our server, transcoded it, then streamed the video FROM what.thedailywtf.com directly.
I can't, for the life of me, figure out how a client-side plugin could have this sort of bug.
-
@Lorne-Kates said in Testing breaking update for NodeBB:
The youtube plugin is a client-side thing, isn't it?
No. In order to get the information from YouTube, you need to have an API key. The use of the key had limits, as in, every request costs points, of which you get so many per day.
We cache the results in an LRU cache so that we don't have to send a request for entry single person looking at a post with a video.
Not going to hand out the API key.
-
@Lorne-Kates said in Testing breaking update for NodeBB:
I can't, for the life of me, figure out how a client-side plugin could have this sort of bug.
No, see, it was retrieving metadata, but it had a runtime error, which crashed the forum, which automatically restarts.
-
@boomzilla said in Testing breaking update for NodeBB:
it was retrieving metadata, but it had a runtime error,
OK
which crashed the forum
WAT
-
@dkf said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
it was retrieving metadata, but it had a runtime error,
OK
which crashed the forum
WAT
Dereferencing a null pointer can do that.
-
@ben_lubar said in Testing breaking update for NodeBB:
@dkf said in Testing breaking update for NodeBB:
@boomzilla said in Testing breaking update for NodeBB:
it was retrieving metadata, but it had a runtime error,
OK
which crashed the forum
WAT
Dereferencing a null pointer can do that.
Have you tried... not dereferencing a null pointer?
if(pointer != NULL){ *pointer; }else{ onebox("Oops, something broke"); }
-
@Fox or even
try { //stuff that might dereference a null pointer } catch (NullReferenceException e) { Log("Naughty programmer SPANK SPANK"); }
-
@ben_lubar said in Testing breaking update for NodeBB:
Dereferencing a null pointer can do that.
It's usually considered good form to check for failure modes before assuming that you have a valid result.