Microsoft's Cl---ic mistake
-
The comments in Microsoft's "reference source" mention a
I wrote to them some time ago about it, but have so far noticed no change.---- conditionin some multithread libraries.
-
I think this is fixable in https://github.com/Microsoft/referencesource ?
A fun search: https://github.com/Microsoft/referencesource/search?q=----&unscoped_q=----
-
Looks like the pointless censorship tool at least found SOME true positives:
// This is a workaround for a RTB issue that causes their // algorithm to ---- up if OnContentsResize recurses.
-
It took me way too long to figure out what it's censoring
I may need more coffee...
-
If I don't know your culture, let's fuck!
catch (CultureNotFoundException) { // If this is the last iteration before giving up, let the exception propagate upward. // Otherwise just ---- and move on to the next candidate.... and move on to the next candidate. From this I conclude that all Microsoft devs are 1) pro-race-mixing and 2) massive players.
-
Some people open things with their hands. But Microsoft developers FUCK them open: https://github.com/Microsoft/referencesource/blob/4fe4349175f4c5091d972a7e56ea12012f1e7170/System.Activities.Presentation/System.Activities.Presentation/System/Activities/Presentation/Base/Core/Internal/PropertyEditing/Model/ModelUtilities.cs#L48
-
I genuinely have no idea what's being censored in most of these cases.
-
In what situation is "race" a dirty word?
-
@ben_lubar said in Microsoft's Cl---ic mistake:
In what situation is "race" a dirty word?
Don't be obtuse. You know perfectly well that it's a topic some people are sensitive about ever since another four-year-old ran faster than them with an egg and spoon one time.
-
@ben_lubar said in Microsoft's Cl---ic mistake:
In what situation is "race" a dirty word?
When you want to ----.
-
@ben_lubar said in Microsoft's Cl---ic mistake:
In what situation is "race" a dirty word?
If you race your wife you might beat her
-
Oh God, no... it doesn't just affect comments. They've censored strings as well: https://github.com/Microsoft/referencesource/blob/90b323fe52bec428fe4bd5f007e9ead6b265d553/System.Data.Entity.Design/System/Data/Entity/Design/PluralizationService/EnglishPluralizationService.cs
On the bright side, nobody will be triggered by the image of a vicious, patriarchal tRAPEzium.
-
@cabbage said in Microsoft's Cl---ic mistake:
Oh God, no... it doesn't just affect comments. They've censored strings as well: https://github.com/Microsoft/referencesource/blob/90b323fe52bec428fe4bd5f007e9ead6b265d553/System.Data.Entity.Design/System/Data/Entity/Design/PluralizationService/EnglishPluralizationService.cs
On the bright side, nobody will be triggered by the image of a vicious, patriarchal tRAPEzium.
I hope nobody from Scunthorpe is reading this.
-
Definition #4A term of derision by non-Anglo-Celtic Australians to describe Anglo-Celtic Australians. Especially used in inner-urban, working class areas of Melbourne frequented by children of Greek, Italian or Vietnamese migrants ("wogs") to describe (especially blue eyed, blond) Anglo-Celtic Australians. Only considered very mildly offensive
Basically, "cracker", but for Aussies.
-
@cabbage said in Microsoft's Cl---ic mistake:
Oh God, no... it doesn't just affect comments. They've censored strings as well: https://github.com/Microsoft/referencesource/blob/90b323fe52bec428fe4bd5f007e9ead6b265d553/System.Data.Entity.Design/System/Data/Entity/Design/PluralizationService/EnglishPluralizationService.cs
On the bright side, nobody will be triggered by the image of a vicious, patriarchal tRAPEzium.
Wow, why would they have done that? That's literally broken the code.
If you're going to run something destructive like that across the codebase, you'd better have unit tests so you can see just how badly your ----ing awful idea has ----ed up the code base.
What a stupid bunch of ----s.
-
@ben_lubar That comment didn't quite get a chuckle out of me, but at least got a s------.
-
@doctorjones
It was either that or keep dealing with the avalanche of
tickets about how awful their codebase was and that the ticket submitters were personally offended. 
-
@cabbage The big question here is, does it affect variable names? I'd guess so, but there's probably no way to know.
I don't know which one would be more
ish- Blindly applying a profanity filter to source code, potentially causing major breakage of everything
- Actually putting the time into making a profanity filter that only filters comments and strings
-
@cabbage Wait, so they censored their
dictionarypluralization services? Are they aware that this breaks user visible functionality?
-
@anonymous234 I don't think C# allows
-in variable names, so presumably if it did affect variable names everything would be completely broken, so presumably they did your second option.
-
@izzion said in Microsoft's Cl---ic mistake:
@doctorjones
It was either that or keep dealing with the avalanche of tickets about how awful their codebase was and that the ticket submitters were personally offended. @izzion ----ing millennial ------s.
-
There's no way to apply a profanity filter to strings and not break the code. This shit should have applied to comments and variable names only.
What were they thinking? Oh, wait, they clearly weren't.
-
@topspin Look, nobody should even be talking about a single t----zium, let alone multiple t----zia. If you think that "breaking" the ability to say things that trigger people is a problem, then you obviously hate women.
-
@cabbage said in Microsoft's Cl---ic mistake:
Oh God, no... it doesn't just affect comments. They've censored strings as well: https://github.com/Microsoft/referencesource/blob/90b323fe52bec428fe4bd5f007e9ead6b265d553/System.Data.Entity.Design/System/Data/Entity/Design/PluralizationService/EnglishPluralizationService.cs
On the bright side, nobody will be triggered by the image of a vicious, patriarchal tRAPEzium.
"ch----is"
Thread title checks out.
-
@cabbage But it won't manifest unless some variable has a "dirty word" in it. And it's entirely possible that none of them do.
Someone could do a search for some of the censored words and prove me wrong.
Also someone should call the PluralizationService library with "trapezium" and see if they get "trapezia" or not.
-
private Dictionary<string, string> _irregularPluralsDictionary = new Dictionary<string, string>() { {"brother", "brothers"}, {"child", "children"}, {"cow", "cows"}, {"ephemeris", "ephemerides"}, {"genie", "genies"}, {"money", "moneys"}, {"mongoose", "mongooses"}, {"mythos", "mythoi"}, {"octopus", "octopuses"}, {"ox", "oxen"}, {"soliloquy", "soliloquies"}, {"trilby", "trilbys"}, {"crisis", "crises"}, {"synopsis","synopses"}, {"rose", "roses"}, {"gas","gases"}, {"bus", "buses"}, {"axis", "axes"},{"memo", "memos"}, {"casino","casinos"}, {"silo", "silos"},{"stereo", "stereos"}, {"studio","studios"}, {"lens", "lenses"}, {"alias","aliases"}, {"pie","pies"}, {"corpus","corpora"}, {"viscus", "viscera"},{"hippopotamus", "hippopotami"}, {"trace", "traces"}, {"person", "people"}, {"chili", "chilies"}, {"analysis", "analyses"}, {"basis", "bases"}, {"neurosis", "neuroses"}, {"oasis", "oases"}, {"synthesis", "syntheses"}, {"thesis", "theses"}, {"change", "changes"}, {"lie", "lies"}, {"calorie", "calories"}, {"freebie", "freebies"}, {"case", "cases"}, {"house", "houses"}, {"valve", "valves"}, {"cloth", "clothes"}, {"tie", "ties"}, {"movie", "movies"}, {"bonus", "bonuses"}, {"specimen", "specimens"} };Many of those aren't irregular.
-
@doctorjones said in Microsoft's Cl---ic mistake:
If you're going to run something destructive like that across the codebase, you'd better have unit tests so you can see just how badly your ----ing awful idea has ----ed up the code base.
That only helps if your find-and-replace doesn't change the unit tests at the same time. Quite possibly they do have unit tests, running and passing every commit, successfully validating that their pluralisation service still pluralises
t----ziumtot----zia.
-
{"----", "----s"}That's genuinely in there. I didn't read the code, but I have to wonder, can you infinite loop it if you try to pluralize the correct word...
Sadly, nothing pluralizes TO
"----"as far as I can see...
-
@cabbage said in Microsoft's Cl---ic mistake:
@doctorjones said in Microsoft's Cl---ic mistake:
If you're going to run something destructive like that across the codebase, you'd better have unit tests so you can see just how badly your ----ing awful idea has ----ed up the code base.
That only helps if your find-and-replace doesn't change the unit tests at the same time. Quite possibly they do have unit tests, running and passing every commit, successfully validating that their pluralisation service still pluralises
t----ziumtot----zia.Here's a little visual analogy of what they did to their codebase.
-
I hoped this somehow managed to effect
README,LICENCEorPATENTSfiles. Especially the latter.Sadly, no such luck :(
-
@anonymous234 said in Microsoft's Cl---ic mistake:
@cabbage The big question here is, does it affect variable names? I'd guess so, but there's probably no way to know.
I don't know which one would be more
ish- Blindly applying a profanity filter to source code, potentially causing major breakage of everything
- Actually putting the time into making a profanity filter that only filters comments and strings
Or option 3, the filter is on the web page and not the source code.
-
@dragnslcr said in Microsoft's Cl---ic mistake:
Or option 3, the filter is on the web page and not the source code.
Well, it's on Github as well, so no, AFAIK.
Could be a post-commit hook in git, but fuck knows.
-
@onyx said in Microsoft's Cl---ic mistake:
Could be a post-commit hook in git, but
fuck---- knows.FTFY
-
FYI, the correct solution would've been to automatically run the filter on the source tree each time it changes and - instead of using the broken results - flag a build error if the filter had any matches.
The developers must then either remove the profanity (if genuine) or tell the censorship captain or whoever to add their word to the exception list.(Bonus points for starting with a filter that already has the common exceptions built-in)
-
private string[] _uninflectiveWordList = new string[] { "bison", "flounder", "pliers", "bream", "gallows", "proceedings", "breeches", "graffiti", "rabies", "britches", "headquarters", "salmon", "carp", "----", "scissors", "ch----is", "high-jinks", "sea-bass", "clippers", "homework", "series", "cod", "innings", "shears", "contretemps", "jackanapes", "species", "corps", "mackerel", "swine", "debris", "measles", "trout", "diabetes", "mews", "tuna", "djinn", "mumps", "whiting", "eland", "news", "wildebeest", "elk", "pincers", "police", "hair", "ice", "chaos", "milk", "cotton", "pneumonoultramicroscopicsilicovolcanoconiosis", "information", "aircraft", "scabies", "traffic", "corn", "millet", "rice", "hay", "----", "tobacco", "cabbage", "okra", "broccoli", "asparagus", "lettuce", "beef", "pork", "venison", "mutton", "cattle", "offspring", "molasses", "shambles", "shingles"};pneumonoultramicroscopicsilicovolcanoconiosis?
https://i.imgur.com/cpLFTdv.png
-
@el_heffe said in Microsoft's Cl---ic mistake:
pneumonoultramicroscopicsilicovolcanoconiosis
Origin
1930s: a word invented (probably by Everett M. Smith, president of the National Puzzlers' League) in imitation of very long medical terms.
-
@el_heffe
"asphinctersayswhat"
-
@onyx said in Microsoft's Cl---ic mistake:
@dragnslcr said in Microsoft's Cl---ic mistake:
Or option 3, the filter is on the web page and not the source code.
Well, it's on Github as well, so no, AFAIK.
Could be a post-commit hook in git, but fuck knows.
Yeah, that's pretty fucked up then.
-
@dragnslcr what's ----ed up about it? It's not like it would compile anyway. It's a filtered extract of the (internal) source they dumped on github for reference use only. If the runtime would have been deprofanitized, then they would really be beyond salvation....
-
-
@el_heffe said in Microsoft's Cl---ic mistake:
private string[] _uninflectiveWordList = new string[] { "bison", "flounder", "pliers", "bream", "gallows", "proceedings", "breeches", "graffiti", "rabies", "britches", "headquarters", "salmon", "carp", "----", "scissors", "ch----is", "high-jinks", "sea-bass", "clippers", "homework", "series", "cod", "innings", "shears", "contretemps", "jackanapes", "species", "corps", "mackerel", "swine", "debris", "measles", "trout", "diabetes", "mews", "tuna", "djinn", "mumps", "whiting", "eland", "news", "wildebeest", "elk", "pincers", "police", "hair", "ice", "chaos", "milk", "cotton", "pneumonoultramicroscopicsilicovolcanoconiosis", "information", "aircraft", "scabies", "traffic", "corn", "millet", "rice", "hay", "----", "tobacco", "cabbage", "okra", "broccoli", "asparagus", "lettuce", "beef", "pork", "venison", "mutton", "cattle", "offspring", "molasses", "shambles", "shingles"};pneumonoultramicroscopicsilicovolcanoconiosis?
https://i.imgur.com/cpLFTdv.pngIs that not a common word for you?
Urban Dictionary: Skip
Oxford Languages | The Home of Language Data
