nodebb-plugin-post-revisions feedback
-
@ben_lubar How about having each revision show the diffs from previous in-line?
e.g.
I was walking through the forest and saw a bear.
I was walking through the forest and saw an
bearowl.
I
was walking through the forest and saw an owlstayed at home and stared at the wall for 11 hours straight.
-
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@swayde said in nodebb-plugin-post-revisions feedback:
Looks good to me, except a bit too much whitespace ;)
If someone has a better method of determining which revisions to diff, I'm all for it.
Can you explain what this means, please? I still have no idea what you're talking about here. Here's what your example post looks like with the
height: 50%
style removed:Again, I think 50% max height (with overflow scrolling) makes sense so that you can see at least 2 revisions. Spreading three lines to cover half the screen feels like abuse.
-
@boomzilla The current automagic diff system uses half height as its magic line to determine which two revisions to diff.
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@swayde said in nodebb-plugin-post-revisions feedback:
Looks good to me, except a bit too much whitespace ;)
If someone has a better method of determining which revisions to diff, I'm all for it.
Something more like this:
-
@coderpatsy said in nodebb-plugin-post-revisions feedback:
@boomzilla The current automagic diff system uses half height as its magic line to determine which two revisions to diff.
Ah, thank you. It changes as stuff scrolls down. I dunno...pretty much anything would be better than all the wasted white space. Unlike threads, WHITESPACE ISN'T FREE
-
@boomzilla said in nodebb-plugin-post-revisions feedback:
It changes as stuff scrolls down.
Yeah, that part threw me off until I realized what it was doing.
-
@coderpatsy said in nodebb-plugin-post-revisions feedback:
@boomzilla The current automagic diff system uses half height as its magic line to determine which two revisions to diff.
Wat....
I mean, is there no way to get the next element in a list or whatever? This can't be an impossible task!
-
@tsaukpaetra said in nodebb-plugin-post-revisions feedback:
@coderpatsy said in nodebb-plugin-post-revisions feedback:
@boomzilla The current automagic diff system uses half height as its magic line to determine which two revisions to diff.
Wat....
I mean, is there no way to get the next element in a list or whatever? This can't be an impossible task!
I think what he's asking boils down to "if there are 3 versions, and the box doesn't scroll (they all fit in the window without scrolling), which 2 of the versions should it do the diff highlighting for". That's why he made them 50% height (so there can be only 2 without scrolling).
My answer is basically that I don't like the infiniscroll thing he built and can we please just have it show a single diff between two revisions. (Adding the cooked before/after versions above and below the raw diff would be ok too, in fact I kinda like the idea but it was beyond the scope of what I felt like hacking in the dev inspector for my exemplary screenshot.)
-
That reminds me - from last night, on mobile:
First post on https://what.thedailywtf.com/topic/23536/university-of-georgia-data-management-course
-
@anotherusername said in nodebb-plugin-post-revisions feedback:
asking boils down to "if there are 3 versions, and the box doesn't scroll (they all fit in the window without scrolling), which 2 of the versions should it do the diff highlighting for"
The topmost visible one and the one after that.
Or, just implement paging buttons and get over it...
-
@pjh
Filed under: That's different
-
@tsaukpaetra said in nodebb-plugin-post-revisions feedback:
The topmost visible one and the one after that.
It'd never show the diff between any of the last n revisions, if the last n + 1 revisions fit on the screen. You could only scroll to the bottom, and the topmost wouldn't be the 2nd to last. Unless you added a bunch of whitespace at the bottom that it could scroll into, which I suppose would work.
-
@anotherusername said in nodebb-plugin-post-revisions feedback:
@tsaukpaetra said in nodebb-plugin-post-revisions feedback:
The topmost visible one and the one after that.
It'd never show the diff between any of the last n revisions, if the last n + 1 revisions fit on the screen. You could only scroll to the bottom, and the topmost wouldn't be the 2nd to last. Unless you added a bunch of whitespace at the bottom that it could scroll into, which I suppose would work.
Yeah. Simple, easy, and helps it stop looking so dumb.
-
@anotherusername said in nodebb-plugin-post-revisions feedback:
I think what he's asking boils down to "if there are 3 versions, and the box doesn't scroll (they all fit in the window without scrolling), which 2 of the versions should it do the diff highlighting for". That's why he made them 50% height (so there can be only 2 without scrolling).
Meh...each revision shows the diff from the previous. Original version is left alone.
:emeril.bam:
-
@boomzilla said in nodebb-plugin-post-revisions feedback:
Meh...each revision shows the diff from the previous.
On its own page, with page back/page forward controls. That's basically the mock-up that I pasted a screenshot of a few days ago.
@boomzilla said in nodebb-plugin-post-revisions feedback:
Original version is left alone.
Inaccessible, because you can see what the original version was on the diff from it to the second version. For n revisions, you really only need n - 1 diffs.
-
@anotherusername said in nodebb-plugin-post-revisions feedback:
On its own page, with page back/page forward controls. That's basically the mock-up that I pasted a screenshot of a few days ago.
Nah...just show a list of 'em. Most posts aren't very long.
-
@boomzilla Most topics aren't 66k posts long. Most topics don't have dozens of upvotes per post. Most posts don't have hundreds of emoji.
See where I'm going with this...
-
@anotherusername Yes, in the wrong direction. I'll direct you to my suggestion to make the max height be 50%.
-
@wharrgarbl said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in NodeBB Updates:
- Post revision history! You can allow other users to see your edits in your profile settings.
What do y'all think?
Why would anyone want that? The final version is the version the author intended to allow otter people to read.
Which for you always is
This post was deleted.
Don't worry, you'll still be able to do that.
GODDAMNIT @wharrgarbl
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@izzion said in nodebb-plugin-post-revisions feedback:
Bug report:
When you submit a new edit, the regular edit pencil is all that shows on the post until you reload the post, and you cannot view edit history until you reload the post. The reload can be effected by either refreshing the page or scrolling far enough away from the post that it unloads, then scrolling back to it. I haven't tried to confirm if I get the same behavior on someone else's edited post that streamed to me, but 100% reproduction rate on my own posts.
This is not resolved, unfortunately. The edit pencil is now showing the appearance of "you can view edit history of this post" for a streamed in edit, but you cannot actually click to view the edits until reloading the post - clicking on the edit pencil behaves as though I had my view post history disabled (aka, nothing happens).