nodebb-plugin-post-revisions feedback
-
@ben_lubar said in NodeBB Updates:
- Post revision history! You can allow other users to see your edits in your profile settings.
What do y'all think?
-
@ben_lubar I have a few points:
- It's not at all obvious that the horizontal scrolling is how you see previous revisions: this should really be Forward/Back arrows instead.
- The modal needs an explicit Close button.
- It'd be nice to see an actual diff-like output e.g.
abc - def ghi + klm
Other than that, it looks good to me.
-
Bug report:
- When you submit a new edit, the regular edit pencil is all that shows on the post until you reload the post, and you cannot view edit history until you reload the post. The reload can be effected by either refreshing the page or scrolling far enough away from the post that it unloads, then scrolling back to it. I haven't tried to confirm if I get the same behavior on someone else's edited post that streamed to me, but 100% reproduction rate on my own posts.
Feature request:
- I would like it if the widget could implement a ninja edit window. Less so for the rush of tempting fate in a mafia game, and more because sometimes you just make stupid typos, and it would be great if you could fix them without the whole world seeing them :P
-
@izzion said in nodebb-plugin-post-revisions feedback:
I would like it if the widget could implement a ninja edit window
WHile a good idea, this would require NodeBB itself to be modified to support it.
-
@raceprouk
Eeeeeh. I'm assuming the plugin is going through the post history table already to pull the edit history together. So it should be conceptually possible (though I don't know how technically difficult to make performant) to look at the "submission time" of the edit and the "submission time" of the post itself, and suppress edits that are within a certain window of the original post.Depending on whether the plugin is completely over-writing the display of the edit pencil, or just adding a CSS class to it, that may also be sufficient to mask the pencil altogether / update the number to display only the count of non-ninja edits.
-
-
@yamikuronue I just got that same issue, but then I refreshed and it started working again, and now I can't reproduce it.
-
I haven't refreshed, but after dragging around for a while, the revisions are there, just, way offscreen.
-
@izzion said in nodebb-plugin-post-revisions feedback:
post history table
???
NodeBB has post history? Or tables?
-
Oh, nevermind. This time, they're all there. Last time, I was able to find two random revisions in the middle.
-
@yamikuronue said in nodebb-plugin-post-revisions feedback:
Oh, nevermind. This time, they're all there. Last time, I was able to find two random revisions in the middle.
I think it's a Chrome rendering bug. :/
-
@ben_lubar sounds like the technique this plugin uses won't work for chrome. What are our browser stats? I'mma guess Chrome is a significant portion of our userbase.
-
@raceprouk said in nodebb-plugin-post-revisions feedback:
WHile a good idea, this would require NodeBB itself to be modified to support it.
As opposed to what Ben's doing, which is... modifying NodeBB?
I'm sorry, you'll have to explain to me how modifying NodeBB differs from modifying NodeBB.
-
@yamikuronue Globally, Chrome's over 50%:
I can't imagine the stats here are wildly different.
-
@blakeyrat It's a plugin you dipshit. It's in the name: nodebb-plugin-post-revisions.
-
@raceprouk said in nodebb-plugin-post-revisions feedback:
@blakeyrat It's a plugin you dipshit. It's in the name: nodebb-plugin-post-revisions.
It would have to hook into something like
filter:post.edit
to accomplish that, and there's no way that's possible from a plugin!
-
@raceprouk said in nodebb-plugin-post-revisions feedback:
It's a plugin you dipshit. It's in the name: nodebb-plugin-post-revisions.
Oh good, I get to be called stupid again. Thanks. I love being stupid, moron, idiot, dumbass, etc.
I still don't see how the word "plugin" changes anything I just said. Ben is indeed modifying NodeBB, I can see the modification right there on the fucking screen. Unless your some kind of pedantic "I R SOFTWARE DEVLPOER ONLT IMPLEMENTATION DETAILAS MATTER WHO CARES WHAZT USER SEESS" type. Who spends all day bowed before some random old lady whose ancestors murdered a lot of people.
But as a normal human being looking at a webpage, I see it (gasp) (shock) (horror) modified from what it was before. Almost as if Ben had modified NodeBB.
But I guess that's just because I'm so fucking stupid. Where's Boomzilla when you need him! For a second there I almost felt like a human being instead of a pile of garbage, I need people to stomp me down again.
-
@blakeyrat Wake me up when you've descended from the drug-induced delusional world you're residing in and are ready to discuss the issue like an adult.
-
@raceprouk The drug-induced delusional world wherein if I see a product modified, I post "that product was modified". Right. I'm really tripping balls.
-
@blakeyrat NodeBB is forum software. Ben did not modify the forum software. Ben modified the page generated by the forum software. Unless you think dropping a DLL in an empty directory that gets scanned by some software counts as modifying the software.
-
@lb_ said in nodebb-plugin-post-revisions feedback:
@blakeyrat NodeBB is forum software. Ben did not modify the forum software. Ben modified the page generated by the forum software. Unless you think dropping a DLL in an empty directory that gets scanned by some software counts as modifying the software.
Can people stop trying to out-pedantic @blakeyrat on an issue he's right on? The plugin modifies NodeBB's post editing functionality, and implementing ninja edit windows would use exactly the same hook that the plugin uses to store post history and increment the revision count.
-
@ben_lubar sorry, I can be quite pedantic. Thanks for the awesome plugin.
-
@raceprouk @ben_lubar
Oh, wow, having actually looked at the example and seen the horizontal edit...There's also going to be a breaking point inflicted on the DOM with just rendering all of the edits in one big chain of DIVs - maybe not within a "normal" number of edits, but I could see it becoming an issue over time, especially if the feature can be extended to wiki posts.
I think I would prefer a layout with just two versions shown, and either some sort of selection mechanism for which is being compared to what, or at least the forward back arrows to go back one revision. I also agree with the suggestion to do diff-like output.
-
-
I'll echo the general sentimental here:
+diff
-horizontal scroll (or atleast add a scroll bar, to indicate there's more)
+close button
Meh Ninja editA vertical scroll with diff (and only loading a resonable amount of posts) would be ideal i think.
-
@swayde said in nodebb-plugin-post-revisions feedback:
or atleast add a scroll bar
It has a scroll bar unless your browser is interpreting
overflow-x: scroll;
a different way than the spec says to.@swayde said in nodebb-plugin-post-revisions feedback:
A vertical scroll [...] would be ideal
It automatically uses vertical scrolling if your viewport has an aspect ratio narrower than 1:1.
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
It automatically uses vertical scrolling if your viewport has an aspect ratio narrower than 1:1.
Why not "in all cases"?
-
@swayde said in nodebb-plugin-post-revisions feedback:
and only loading a resonable amount of posts
So you want InfiniScroll in the revisions window?
-
@hungrier said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in nodebb-plugin-post-revisions feedback:
It automatically uses vertical scrolling if your viewport has an aspect ratio narrower than 1:1.
Why not "in all cases"?
Because most computer mice primarily scroll horizontally, and most phones primarily scroll vertically?
-
@tsaukpaetra said in nodebb-plugin-post-revisions feedback:
Because most computer mice primarily scroll horizontally
Maybe I'm ing but hardly any of them even can. You have to click and drag the scrollbar like some kind of caveman.
-
@hungrier said in nodebb-plugin-post-revisions feedback:
@tsaukpaetra said in nodebb-plugin-post-revisions feedback:
Because most computer mice primarily scroll horizontally
Maybe I'm ing but hardly any of them even can. You have to click and drag the scrollbar like some kind of caveman.
Yes. I don't know the emojibb code for :sarcasm:, since it wasn't really ....
-
@ben_lubar overflow-x is definitely handled weirdly in iOS.
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
What do y'all think?
The link to view history needs a title or something - hovering over it doesn't even show a URL in what passes for a status bar in Chrome.
Edit: Ok - the pencil itself has a title, but most of the clickable area doesn't.
-
@lb_ said in nodebb-plugin-post-revisions feedback:
@blakeyrat NodeBB is forum software. Ben did not modify the forum software. Ben modified the page generated by the forum software. Unless you think dropping a DLL in an empty directory that gets scanned by some software counts as modifying the software.
Thank you. At least someone here has more intelligence than a beansprout.
-
I'm not sure if this is related to the reports up above or not, but here it is:
When I clicked on the button to show the history, it popped up correctly for a second, but then it went to a blank panel:
https://imgur.com/FsIDg4v
The scrollbar at the bottom was still present, there was just nothing displaying on screen.A short time later, it all came back. Is this the same issue, or a different problem?
-
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in NodeBB Updates:
- Post revision history! You can allow other users to see your edits in your profile settings.
What do y'all think?
Why would anyone want that? The final version is the version the author intended to allow otter people to read.
-
@wharrgarbl said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in NodeBB Updates:
- Post revision history! You can allow other users to see your edits in your profile settings.
What do y'all think?
Why would anyone want that? The final version is the version the author intended to allow otter people to read.
What about regular people who aren't otters?
-
@raceprouk said in nodebb-plugin-post-revisions feedback:
- It's not at all obvious that the horizontal scrolling is how you see previous revisions: this should really be Forward/Back arrows instead.
I changed it to always use vertical scrolling because that's supported better in browsers. (At least, I hope they all show the scrollbar now.)
@raceprouk said in nodebb-plugin-post-revisions feedback:
- The modal needs an explicit Close button.
@raceprouk said in nodebb-plugin-post-revisions feedback:
- It'd be nice to see an actual diff-like output e.g.
abc - def ghi + klm
@izzion said in nodebb-plugin-post-revisions feedback:
Bug report:
- When you submit a new edit, the regular edit pencil is all that shows on the post until you reload the post, and you cannot view edit history until you reload the post. The reload can be effected by either refreshing the page or scrolling far enough away from the post that it unloads, then scrolling back to it. I haven't tried to confirm if I get the same behavior on someone else's edited post that streamed to me, but 100% reproduction rate on my own posts.
@izzion said in nodebb-plugin-post-revisions feedback:
Feature request:
- I would like it if the widget could implement a ninja edit window. Less so for the rush of tempting fate in a mafia game, and more because sometimes you just make stupid typos, and it would be great if you could fix them without the whole world seeing them :P
@ben_lubar said in nodebb-plugin-post-revisions feedback:
Can people stop trying to out-pedantic @blakeyrat on an issue he's right on?
@pjh said in nodebb-plugin-post-revisions feedback:
@ben_lubar said in nodebb-plugin-post-revisions feedback:
What do y'all think?
The link to view history needs a title or something - hovering over it doesn't even show a URL in what passes for a status bar in Chrome.
Edit: Ok - the pencil itself has a title, but most of the clickable area doesn't.
@wharrgarbl said in nodebb-plugin-post-revisions feedback:
otter people
@erufael said in nodebb-plugin-post-revisions feedback:
regular people who aren't otters
-
@raceprouk said in nodebb-plugin-post-revisions feedback:
@izzion said in nodebb-plugin-post-revisions feedback:
I would like it if the widget could implement a ninja edit window
WHile a good idea, this would require NodeBB itself to be modified to support it.
He's tracking the revisions separately, so all he'd have to do is filter that list (replace the previous latest revision with the new latest revision if it's inside the ninja edit window). The pencil icon would still appear if you made ninja edits, but the revision history wouldn't show them.
-
Pretty cool. Vertical whitespace / revision size is a bit out of control.
-
@boomzilla loots of whitespace:
-
@boomzilla said in nodebb-plugin-post-revisions feedback:
Pretty cool. Vertical whitespace / revision size is a bit out of control.
The problem I ran into was if the revisions weren't half the height of the container, which ones would it compute the diff of?
-
@ben_lubar I don't understand the question. What's special about half the height of the container? It makes sense as a maximum height, but not a hard coded height.
-
@boomzilla said in nodebb-plugin-post-revisions feedback:
I don't understand the question
Something to do with how the top of the two displayed revisions is shown as the before in the diff and the second is the after? If three images fit in there then what's what?
Why not shrink the container in that case?
-
@ben_lubar can you make the pencil icon's border and edit count thing only happen on posts from users who've turned on the setting, and just leave the old pencil icon with the "last edited by ... on ..." title for posts whose edit history isn't visible? (instead of the edit icon + border + edit count + 80% (wild guess) "disabled" opacity that makes it just slightly different but not enough to be really noticeable)
-
Also, I think instead of a separate box for every revision, I'd just put one box, with the
<del>/<ins> between it and the previous revision, and then put forward/back buttons so that you could view the diff between any (adjacent) pair of revisions in that single box.
-
This post is deleted!
-
view revision history for this post
View should be capitalized. Also that title attribute should only be applied if the user has permissions to view that post's edit history. Unless you do @anotherusername 's suggestion to not render the count etc. when you can't see the history, in which case this is
Also the edit history modal could use a $revision_count indicator on each revision.
-
Looks good to me, except a bit too much whitespace ;)
-
@swayde said in nodebb-plugin-post-revisions feedback:
Looks good to me, except a bit too much whitespace ;)
If someone has a better method of determining which revisions to diff, I'm all for it.