Notifications have gone weird
-
@julianlam said in Notifications have gone weird:
I love the tests in your PR, they make me cry because our test coverage
Thank you! Now accept @Yamikuronue's PR to add coverage! :-D
-
I've just done a hard refresh, and mention notification links are still wrong:
-
@anotherusername How about this one?
-
@boomzilla that one works. The other one is still broken.
-
@anotherusername I think the link and stuff is made when the notification is created.
-
@julianlam said in Notifications have gone weird:
Guys, you do realise that the commit is only two hours old, right?
Let's say in theory Ben L hadn't pushed it here, and we never found those two extremely obvious bugs:
- Mentions previous to the update were deleted
- Mentions for new replies go to the wrong URL
Since the developer who pushed up the change didn't even bother to check either of those two cases, how in this hypothetical world would these bugs have been detected? Do you guys do a QA and bug bash before cutting a release? I'm genuinely curious. What's the actual process here?
@julianlam said in Notifications have gone weird:
I'm not saying making these wild-west style changes are fine, but notifications themselves are fairly transient data.
You're also not saying making these wild-west style changes is not fine, which is (I think it's safe to say) what everybody here wants to hear.
@julianlam said in Notifications have gone weird:
and before people start qq'ing
qq'ing?
@julianlam said in Notifications have gone weird:
about how we're on the fence about @boomzilla's PR and we didn't check baris' commit -- his commit actually deleted code (specifically code that would take a pid/tid and resolve it to a post) and reduced technical debt for the project.
But did it really? Because now it's broken and you need to go back and fix it. And that's to say nothing about the trust the NodeBB project has lost during this whole debacle.
I mean, that's just one in a million ways your statement there doesn't really make sense to me. I don't think it's true that it reduced technical debt. The strange unspoken assumption that code that reduces technical debt is beyond reproach. The word "qq'ing".
@julianlam said in Notifications have gone weird:
Honestly? I love the tests in your PR, they make me cry because our test coverage is abysmal less than ideal.
It seems like maybe you should start using the PR process GitHub offers and stop approving code changes without an appropriate level of test coverage.
-
Ah derp, you're right. That's why the notification points to the wrong place. In any case, this feature (however rocky its release) means we can refer to posts by
/posts/:pid
instead of/topic/:tid/some-slug/:index
, which isn't a permalink.
-
Oop... I just said "permalink", and the actual permalink in the theme still uses the old topic index style. Let me report that one.
-
@loopback0 Thanks for the free profile view! :)
-
-
@julianlam said in Notifications have gone weird:
they make me cry because our test coverage is abysmal less than ideal
I was going to maybe help out with that, but my first PR doesn't seem to be going well...
-
@Yamikuronue Holy shit that notification message looks wrong on my theme.
-
@Yamikuronue On mine (darkly) as well....
To the Style-cave with us!
Filed Under: NaNaNaNaNaNaNa Styliiiiiish~
-
Hey @julianlam , is there a process by which I can add a
themeskin that's actually customized for NodeBB to the themes list?ETA: Skin is the word I want, NodeBB uses Theme to mean something different.
-
@Yamikuronue said in Notifications have gone weird:
Holy shit that notification message looks wrong on my theme.
It looks like most notifications on mine. Just a nice white-on-white box that I assume I can safely ignore.
-
@Tsaukpaetra said in Notifications have gone weird:
Just a nice white-on-white box that I assume I can safely ignore.
See the Style Cave
-
@Yamikuronue said in Notifications have gone weird:
See the Style Cave
I will. But I need to figure out if I can escape the corp. proxy to load a stylish plugin...
-
@Yamikuronue said in Notifications have gone weird:
my first PR doesn't seem to be going well...
I'm not sure their PRs are going much better...
-
@loopback0 said in Notifications have gone weird:
Imagine how many notifications you'd get if you got downvote notifications
Those are cheap. They can be condensed to 'BraFox has downvoted everything you've posted in the Guacamole thread'.
-
@loopback0 said in Notifications have gone weird:
I'm not sure their PRs are going much better...
Their PRs are doing mu, because they apparently don't bother using them and everybody and their dog has direct commit access to their main branch.
-
@blakeyrat said in Notifications have gone weird:
everybody and their dog
For values of "everybody and their dog" equivalent to "project owners", of course.
-
@sloosecannon I guess so.
Also that's not very fair of me; the dog probably would have spent more time QAing the change.
-
@blakeyrat said in Notifications have gone weird:
@sloosecannon I guess so.
Also that's not very fair of me; the dog probably would have spent more time QAing the change.
No joke. Have you seen how much testing a dog puts in just to decide where to shit?
-
@Lorne-Kates said in Notifications have gone weird:
@blakeyrat said in Notifications have gone weird:
@sloosecannon I guess so.
Also that's not very fair of me; the dog probably would have spent more time QAing the change.
No joke. Have you seen how much testing a dog puts in just to decide where to shit?
But as a non-joke point: pagination (a core feature of NodeBB) doesn't work on /unread (a core feature of NodeBB).
-
-
Oh boy just noticed I also get a useless toaster in addition to the useless notification dropdown.
@SoAndSo has Upvoted your post in The Offal Status thread.
Great. I've made a couple hundred posts there. Which one? How about:
@SoAndSo has
Upvoted
your post in The Offal Status Thread
This is a preview of the post that was upvoted. It is actually the entire post, but with a css style to elipses it in case someone wants to override the css and see the whole...
-
@boomzilla said in Notifications have gone weird:
@ben_lubar gets a bit excited sometimes about updating the site. That bit is our problem.
So all the yelling at @julianlam in this case was premature ejaculation?
-
@FrostCat said in Notifications have gone weird:
@boomzilla said in Notifications have gone weird:
@ben_lubar gets a bit excited sometimes about updating the site. That bit is our problem.
So all the yelling at @julianlam in this case was premature ejaculation?
What a joke. Very mature!
Filed under: you can stone me now
-
@kt_ said in Notifications have gone weird:
What a joke. Very mature!
What? "ejaculation" means "something said quickly and suddenly."
-
@FrostCat said in Notifications have gone weird:
So all the yelling at @julianlam in this case was premature ejaculation?
No. As I said in the GitHub thread:
we're talking about an update to the notifications system where the developer who pushed-up the commit didn't once click an notification before doing so.
@julianlam apparently thinks this isn't an issue because it was "less than 2 hours old" and because (in his mind at least) this change reduced technical debt. But when I asked what mechanism exists in his project that would have caught this bug had we wanted longer, I heard nothing but so.
No. The real problem here is we're (once again!) using an open source project run by people who have no idea what they're doing and don't give a shit about doing it better.
This is not a net improvement from Discourse.
-
@blakeyrat said in Notifications have gone weird:
No.
Man, I feel like last season of Dr Who when he invented a 2dis and Clara didn't get his joke again. People were yelling at the wrong person about the problem.
-
@FrostCat Ok, well I haven't watched that so I have no idea what the fuck you're talking about.
The problem is the NodeBB project has a rogue developer apparently immune to all code review requirements who pushes up bugs without doing even the most cursory testing. I've been trying to be a nice guy and not name-names during this whole thing.
@julianlam's involvement is coming in here and defending that rogue developer's action for various (illogical and weird) reasons. You're beyond criticism if you reduce tech debt! ... huh?
The way I see it, the worst thing @ben_lubar is doing is assuming other people are even slightly competent, and refusing to accept that they are not and we should be doing our own independent testing.
Today it was some notifications deleted. Tomorrow it could be users, or posts. It could be anything. The forum's a bomb, with no display on the timer, until this shit gets fixed.
-
@blakeyrat said in Notifications have gone weird:
Ok, well I haven't watched that so I have no idea what the fuck you're talking about.
You're familiar with the show's concepts, right? In particular, his time machine that looks like a phone booth, that is called a TARDIS? In one episode he made a thing called a 2DIS. He gave it to someone who should've recognized the pun, but didn't, and he had the "i'm bummed because you didn't get my joke" look on his face.
I looked for the clip on YT but couldn't find it.
-
@blakeyrat said in Notifications have gone weird:
Today it was some notifications deleted. Tomorrow it could be users, or posts. It could be anything. The forum's a bomb, with no display on the timer, until this shit gets fixed.
I don't even really disagree, although I assume you're aware your bad attitude isn't encouraging the devs to improve.
-
@FrostCat said in Notifications have gone weird:
He gave it to someone who should've recognized the pun,
What pun?
And it looks like a police box, which is a thing that existed in the UK in the 60s because apparently 75% of the population was dangerously drunk at all times.
@FrostCat said in Notifications have gone weird:
I don't even really disagree, although I assume you're aware your bad attitude isn't encouraging the devs to improve.
I don't care anymore. The incompetent assholes are calling themselves software developers. Their shitty behavior is harming my reputation. That pisses me off.
You know what else pisses me off? Some random person swooping-in and deleting my data.
So yes. Anyway I'm reasonably polite on their GitHub forum, I'm only letting loose here.
-
@blakeyrat said in Notifications have gone weird:
What pun?
Sorry, I forgot that someone who can't say "dagger" right might not get a verbal one.
Say TARDIS out loud. Now say 2DIS out loud ("two-dis").
-
@blakeyrat said in Notifications have gone weird:
Anyway I'm reasonably polite on their GitHub forum, I'm only letting loose here.
Ah. Well, carry on, then.
-
@blakeyrat said in Notifications have gone weird:
Their shitty behavior is harming my reputation.
Whaaaaaaat?
-
-
@FrostCat said in Notifications have gone weird:
Say TARDIS out loud. Now say 2DIS out loud ("two-dis").
Jump to 26:00 or so, if you want, to see it. Watch his face when he tells her what it's called and when she reads the name wrong.
-
@FrostCat said in Notifications have gone weird:
Say TARDIS out loud. Now say 2DIS out loud ("two-dis").
I get the wordplay, but I wouldn't call it a pun.
@boomzilla said in Notifications have gone weird:
Whaaaaaaat?
Right; this clown goes to a party says, "I'm a software developer, oh BTW today I deleted a bunch of user's data due to my own incompetence but I don't really give a shit ha ha ha, hand me a beer".
Tomorrow I go to an interview and say, "I'm a software developer", and the interviewer thinks, "oh God, another one of those assholes."
It's exactly like those asswads who go to parties and pretend they're veterans of the US Marine Corps to impress stupid women. But without the possibility of getting physically beaten-up while everybody around cheers, which is a shame.
Oh and BTW if you want a nice little added bonus, go look at that GitHub thread where @julianlam admits there was absolutely no need to delete the notifications because the database schema didn't change. That developer was just too fucking lazy to do it correctly.
-
@blakeyrat said in Notifications have gone weird:
It's exactly like those asswads who go to parties and pretend they're veterans of the US Marine Corps to impress stupid women.
Have you no sense of perspective, sir? At long last, have you no sense of perspective?
-
@blakeyrat said in Notifications have gone weird:
@julianlam's involvement is coming in here and defending that rogue developer's action for various (illogical and weird) reasons. You're beyond criticism if you reduce tech debt! ... huh?
That is not at all what he did. And it wasn't a "rogue developer", it was someone writing a commit to start using unique post IDs, instead of post indexes which change when a bunch of posts get jeffed, or even just based on the way the thread's sorted. It was a significant step toward fixing a fairly major problem:
@julianlam said in Notifications have gone weird:
specifically code that would take a pid/tid and resolve it to a post
...which doesn't even work correctly in certain cases, as he mentioned:
@julianlam said in Notifications have gone weird:
this feature (however rocky its release) means we can refer to posts by
/posts/:pid
instead of/topic/:tid/some-slug/:index
, which isn't a permalink.It's a fairly important change.
And here's where he's not defending the lack of proper testing:
@julianlam said in Notifications have gone weird:
I'm not saying making these wild-west style changes are fine
I will give you this much: wiping out all of the old notifications was very much "by design" and that was a poor design. They should've been updated. At the very least, the unread notifications should've been updated. If, as he said, they're only kept around for 7 days, there shouldn't even be all that many of them that would've needed to be updated.
Here, if you don't believe me, click the "Quote" button. It's a permalink. Hopefully the "Reply" button gets fixed soon as well (I think we probably added that, so whoever wrote it will need to get it updated).
-
@blakeyrat said in Notifications have gone weird:
Tomorrow I go to an interview and say, "I'm a software developer", and the interviewer thinks, "oh God, another one of those assholes."
And the interviewer was surprised because they were hiring for a sales position? I'm not really getting the point of this hypothetical anecdote.
-
@anotherusername said in Notifications have gone weird:
That is not at all what he did. And it wasn't a "rogue developer", it was someone writing a commit to start using unique post IDs, instead of post indexes which change when a bunch of posts get jeffed, or even just based on the way the thread's sorted. It was a significant step toward fixing a fairly major problem:
Ok, but it happened with:
- No code review
- No QA (not even the most cursory)
I call that a "rogue developer". He's working entirely outside the process known to produce non-ass software.
@anotherusername said in Notifications have gone weird:
And here's where he's not defending the lack of proper testing:
Read it. He's not saying they're fine, but he's also not saying they're not fine, and he's certainly not (not yet, at least) doing anything to stop it from happening again.
@anotherusername said in Notifications have gone weird:
I will give you this much: wiping out all of the old notifications was very much "by design" and that was a poor design. They should've been updated. At the very least, the unread notifications should've been updated.
The database schema didn't even change. They didn't even need updated. They just needed to be read from the database. And the code to do that already exists.
He just deleted working code for literally no reason.
@boomzilla said in Notifications have gone weird:
And the interviewer was surprised because they were hiring for a sales position? I'm not really getting the point of this hypothetical anecdote.
That's because I'm too insane and illiterate. Why do you give a fuck what I think, and why should I give a fuck what you think? Stop replying to me.
-
@blakeyrat said in Notifications have gone weird:
He's not saying they're fine, but he's also not saying they're not fine, and he's certainly not (not yet, at least) doing anything to stop it from happening again.
I like how you get upset when other people make assumptions about things you didn't say, but don't let that stop you from doing the same exact thing, only with extra hyperbole.
-
@FrostCat I'm reading what he said exactly. He said only:
I'm not saying making these wild-west style changes are fine
Well, ok. But so what? That's all he said. He's not taking any kind of stand, or taking any kind of action, or even saying that wild-west changes aren't fine. That statement is nothing at all.
I made no assumptions.
-
@blakeyrat said in Notifications have gone weird:
@FrostCat I'm reading what he said exactly. He said only:
I'm not saying making these wild-west style changes are fine
Well, ok. But so what? That's all he said. He's not taking any kind of stand, or taking any kind of action, or even saying that wild-west changes aren't fine. That statement is nothing at all.
For one thing, you have no evidence that "he's certainly not (not yet, at least) doing anything to stop it from happening again." Perhaps he is, and simply hasn't mentioned it here, because he doesn't like the abuse.
-
@FrostCat said in Notifications have gone weird:
For one thing, you have no evidence that "he's certainly not (not yet, at least) doing anything to stop it from happening again."
Ok; that is a fair criticism. But he has an open bug on his bug tracker about the lack of code review and QA, and it hasn't been updated in any meaningful fashion, so if he is acting on it, he's still engaging in bad development process by acting on it without updating the open issue.
-
@blakeyrat said in Notifications have gone weird:
Today it was some notifications deleted.
You really don't get it, do you? The notifications weren't deleted.