Notifications have gone weird
-
All of mine have disappeared except one mention notification, and it's going to the user page instead of the post.
-
@RaceProUK Yup. Same here.
-
Discourse ghost is a barrier to NodeBB
-
I think it was the update that just happened about 10 minutes ago. I don't have any notifications at all (like, at all, the list is now empty), but I have 3 unread. ;)
It's a good thing we don't use notifications, eh?
-
In case it's relevant, @ben_lubar...
X-Upstream:172.18.0.254:4568And yes, it's the same after a hard refresh.
-
@RaceProUK that's an intentional part of the update.
-
same here
-
Hmm… the links for upvote notifications is fine, just not for mentions
-
Mine is
X-Upstream:172.18.0.254:4567
-
@ben_lubar This is a new development methodology, do the code review after you push to production. I like it.
-
@ben_lubar said in Notifications have gone weird:
that's an intentional part of the update
At the risk of sounding like a certain someone, there's no justification for removing the entire notifications history
-
@ben_lubar said in Notifications have gone weird:
that's an intentional part of the update.
To break/delete them?
Also - the red number hasn't changed, even if the notifications have been removed or hidden or whatever.
-
@ben_lubar said in Notifications have gone weird:
@RaceProUK that's an intentional part of the update.
"See all notifications" doesn't show them, either, though.
-
@RaceProUK How do you think I felt?
-
They changed how notifications work in the update.
add /user/<uid> and /post/<pid> redirects · NodeBB/NodeBB@eb0aea6
change notifications to use new redirects
-
@ben_lubar said in Notifications have gone weird:
They changed how notifications work in the update.
And thought "fuck everyone who has notifications already"?
-
Oh, there's a new toaster too...
-
@loopback0 said in Notifications have gone weird:
And thought "fuck everyone who has notifications already"?
No; I can guarantee no thought went into this.
Hey, it's open source in 2016. Deleting user's data is just what you do! Apparently.
-
@blakeyrat In the least, they could have reset my notification count.
-
@loopback0 said in Notifications have gone weird:
Oh, there's a new toaster too...
Don't click it though, else...
-
@Tsaukpaetra said in Notifications have gone weird:
it was the update that just happened
That probably explains this:
-
This notification:
Goes here:
-
@ben_lubar said in Notifications have gone weird:
They changed how notifications work in the update.
And they meant to direct mentions to the user?
-
@Tsaukpaetra said in Notifications have gone weird:
Don't click it though
It seems to disappear too quickly.
-
-
@loopback0 +1 for the quotation marks on "improved"
Filed Under: So... ... .... erm... does this fix the notification for every upvote-thing now?
-
@Kuro said in Notifications have gone weird:
Filed Under: So... ... .... erm... does this fix the notification for every upvote-thing now?
I hope not. Call me narcissistic, but I like those.
-
-
@Kuro said in Notifications have gone weird:
Filed Under: So... ... .... erm... does this fix the notification for every upvote-thing now?
That for some reason is actually in a PR and actually (supposedly) being reviewed. I guess because Boomzilla isn't "trusted" enough, even though there's no way he didn't do at least an order of magnitude more testing of his change than whoever pushed this notifications thing directly to production did.
-
@blakeyrat The thing that's currently baffling me about this whole fiasco is that the same update has broken things on the official NodeBB community too - and yet it's seemingly only us that have noticed.
It's only us that have noticed (putting the removal of user data aside for a couple of seconds) that not only are the "improved" notifications broken, but the new toasters are broken too.
-
@loopback0 said in Notifications have gone weird:
Fixed?
closes #68 · julianlam/nodebb-plugin-mentions@5cbe1a2
NodeBB Plugin that allows users to mention other users by prepending an '@' sign to their username - closes #68 · julianlam/nodebb-plugin-mentions@5cbe1a2
-
@loopback0 said in Notifications have gone weird:
The thing that's currently baffling me about this whole fiasco is that the same update has broken things on the official NodeBB community too - and yet it's seemingly only us that have noticed.
I'd venture we're more active than the official community, not to mention we're a helluva lot pickier
-
@RaceProUK Dunno. I open the page, I see 4 unread notifications, I open the menu, I see only 1. I click on "show all", I see only 1.
How can you not notice that?
Very disappoint. :/
-
@RaceProUK said in Notifications have gone weird:
we're a helluva lot pickier
For some of the bugs we report, I agree (and did on Dickspores too) - but these were so fundamentally broken, and so fucking trivial to spot, that it would have taken literally seconds to spot on a local instance before committing.
-
@loopback0 said in Notifications have gone weird:
Fixed?
closes #4602 · NodeBB/NodeBB@decd853
Node.js based forum software built for the modern web - closes #4602 · NodeBB/NodeBB@decd853
-
@RaceProUK said in Notifications have gone weird:
not to mention we're a helluva lot pickier
The guy who made this change DIDN'T ONCE CLICK THE NOTIFICATION BEFORE PUSHING IT TO THEIR PRODUCTION BRANCH.
NOT ONCE.
Because it would have been impossible to miss that the notification went to the wrong page if he had clicked it. Just once.
-
@Kuro said in Notifications have gone weird:
Filed Under: So... ... .... erm... does this fix the notification for every upvote-thing now?
Different thing. There was some discussion on that with @julianlam. Not sure where we are right now. He didn't respond to my last comment.
-
Guys, you do realise that the commit is only two hours old, right?
I'm not saying making these wild-west style changes are fine, but notifications themselves are fairly transient data. It's automatically deleted after 7 days.
-
@julianlam said in Notifications have gone weird:
. It's automatically deleted after 7 days.
Oh god, don't say that here. The users here hate disappearing data..
Filed Under: It's going to be the @Kuro-Bar all over again!
-
@Kuro said in Notifications have gone weird:
@julianlam said in Notifications have gone weird:
. It's automatically deleted after 7 days.
Oh god, don't say that here. The users here hate disappearing data..
Filed Under: It's going to be the @Kuro-Bar all over again!
-
@boomzilla We're on the fence over whether there is sufficient rationale for inclusion of this feature (since it's just that little bit of extra code that we'll have to maintain going forward).
By all means, merge it into the tdwtf fork, I think it's a neat idea especially if there are calls for it here.
... and before people start qq'ing about how we're on the fence about @boomzilla's PR and we didn't check baris' commit -- his commit actually deleted code (specifically code that would take a pid/tid and resolve it to a post) and reduced technical debt for the project.
-
@Kuro said in Notifications have gone weird:
Filed Under: It's going to be the @Kuro-Bar all over again!
..... i'm tepted to register that as a bot account for rasins most foul now.
-
@julianlam said in Notifications have gone weird:
Guys, you do realise that the commit is only two hours old, right?
@ben_lubar gets a bit excited sometimes about updating the site. That bit is our problem.
-
@julianlam said in Notifications have gone weird:
We're on the fence over whether there is sufficient rationale for inclusion of this feature (since it's just that little bit of extra code that we'll have to maintain going forward).
That's fair. You're wrong, but fair. :-P It's just not obvious when discussion stops from where I can see it.
NB: I'm trying to make sure I have automated tests for all the stuff I try to push on you guys.
-
@julianlam Oh, I'd add that I probably get hundreds of upvote notifications per day.
-
@boomzilla said in Notifications have gone weird:
@julianlam Oh, I'd add that I probably get hundreds of upvote notifications per day.
oh, so i should stop obsessively upvoting everything you post?
-
Oh by the by -- @ben_lubar, latest mentions fixes the notif list.
@boomzilla Honestly? I love the tests in your PR, they make me cry because our test coverage is
abysmalless than ideal. I've toyed with the idea of registering for Google SoC just so I can make the intern bring test coverage to 100%, but I think that's kind of mean
-
@julianlam said in Notifications have gone weird:
It's automatically deleted after 7 days.
Yeah, and a 7 day old notification is likely pointless, but one that's like an hour old is not. They should have been migrated, not removed.
-
@Kuro said in Notifications have gone weird:
The users here hate disappearing data..
At least this time it's not your fault ;)
-
@boomzilla said in Notifications have gone weird:
I probably get hundreds of upvote notifications per day.
Imagine how many notifications you'd get if you got downvote notifications
