Discussion of NodeBB Updates
-
Stylish fix, to make it look like the buttons
.topic [component="post/reply-count"] { background-color: #337ab7; color: white; padding: 5px; width: 100px; text-align: center; }
My CSS knowledge isn't good enough to get the width to be based on the text length, but I think it looks OK
-
@Jaloopa As a quick hack, I changed with width to 150, and added the line height and font size to match the reply and quote buttons:
.topic [component="post/reply-count"] { background-color: #337ab7; color: white; padding: 10px; width: 150px; font-size: 11.9px; text-align: center; line-height: 17px; }
That at least gets it all on one line. :D
-
@Erufael said in Discussion of NodeBB Updates:
That at least gets it all on one line.
unless there's a signature:
-
@Jaloopa Wouldn't we want to modify the vertical alignment of the right buttons in that case?
It's OK for them to be on the same line as the signature if there's a signature, but not if there's also a replies link.
Or maybe shift the signature to the right on wider screens, but I'm hesitant on that.
-
@PleegWat said in Discussion of NodeBB Updates:
It's OK for them to be on the same line as the signature if there's a signature, but not if there's also a replies link.
I think they should be below the signature anyway. There's plenty of bugs where signatures are blocked by the reply button
-
@Jaloopa
Or maybe we could just take your signature to heart and disable signatures?
-
How's this look?
-
@Jaloopa said in Discussion of NodeBB Updates:
@Erufael said in Discussion of NodeBB Updates:
That at least gets it all on one line.
unless there's a signature:
Yeah sorry, I meant the text in the box, not where the box is. hehe. I still see the full "+ replies_to_this_post" text.
-
@ben_lubar
That I much like.
-
@ben_lubar Left margin looks bigger than right margin. Maybe the chevron is bigger than it looks and/or I'm just seeing things.
-
@ben_lubar That looks good!
-
@ben_lubar said in Discussion of NodeBB Updates:
How's this look?
-
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post:
Is there an ETA for the localization so that en-US doesn't show replies_to_this_post?
Fake Edit: 'd by @error
-
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post:
- Deleted posts no longer show all replies as deleted
- Better UI https://what.thedailywtf.com/post/1029419
- New/purged posts update the reply count and list of replies
- EU cookie law annoy-o-matic support
- Popcorn goes to the last read post instead of the first post
Change lists
Also it's still doing the "paste the whole thread" thing
- Replies-to-post:
-
@ben_lubar said in NodeBB Updates:
- EU cookie law annoy-o-matic support
Ben....... why are we downgrading our website?
because that is what it is.
it's also utter bullshit because the only way you can actually abide by the EU guidelines for that annoy-o-matic is to put cookies on the device before you get permission to (or, if they refuse, after they have already denied you permission)
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- EU cookie law annoy-o-matic support
Ben....... why are we downgrading our website?
because that is what it is.
it's also utter bullshit because the only way you can actually abide by the EU guidelines for that annoy-o-matic is to put cookies on the device before you get permission to (or, if they refuse, after they have already denied you permission)
-
@accalia said in Discussion of NodeBB Updates:
the only way you can actually abide by the EU guidelines for that annoy-o-matic is to put cookies on the device before you get permission to
Yes, the only way.
function getCookie( name ) { if( !localStorage.allowCookies ) return null; // could also by checking the existence of an accept cookie // access cookie } function setCookie( name, value ) { if( !localStorage.allowCookies ) return false; // set cookie return true; }
Filed under: They're all major pains in the ass, but there are ways to comply.
-
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- EU cookie law annoy-o-matic support
Ben....... why are we downgrading our website?
because that is what it is.
it's also utter bullshit because the only way you can actually abide by the EU guidelines for that annoy-o-matic is to put cookies on the device before you get permission to (or, if they refuse, after they have already denied you permission)
uhh.......... Use your words please.
what is that screenshot supposed to mean?
-
@accalia It looks like NodeBB uses Android style switches where checkboxes would work, but it looks like it's disabled here, it's just part of the NodeBB install now.
Though yes, it is annoying to see a screenshot as a response without any explanation.
-
@ChaosTheEternal said in Discussion of NodeBB Updates:
@accalia It looks like NodeBB uses Android style switches where checkboxes would work, but it looks like it's disabled here, it's just part of the NodeBB install now.
yes, but that doesnt explain what jeff junior wanted to say with the screenshot.
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- EU cookie law annoy-o-matic support
Ben....... why are we downgrading our website?
because that is what it is.
it's also utter bullshit because the only way you can actually abide by the EU guidelines for that annoy-o-matic is to put cookies on the device before you get permission to (or, if they refuse, after they have already denied you permission)
The correct way for a forum like this to comply is to not set cookies if not logged in, and have the notice on login and/or account create.
Or not notice at all since once it's for login it's basic site functionality so you don't need the notice.
-
@accalia said in Discussion of NodeBB Updates:
@ChaosTheEternal said in Discussion of NodeBB Updates:
@accalia It looks like NodeBB uses Android style switches where checkboxes would work, but it looks like it's disabled here, it's just part of the NodeBB install now.
yes, but that doesnt explain what jeff junior wanted to say with the screenshot.
Your overreacting isn't funny.
-
@aliceif said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
@ChaosTheEternal said in Discussion of NodeBB Updates:
@accalia It looks like NodeBB uses Android style switches where checkboxes would work, but it looks like it's disabled here, it's just part of the NodeBB install now.
yes, but that doesnt explain what jeff junior wanted to say with the screenshot.
Your overreacting isn't funny.
neither is posting ambiguous screenshots in response to directed questions.
not only do i think my analogy was fair, but i think me and ben are even on that score. However, if he disagrees I would welcome text based discussion from him on the matter.
-
@accalia An image can say more than a thousand words. A hundred for me, a hundred for you, a hundred for @aliceif, a hundred for @ben_lubar, ...
It would be much better if those were the same 100 words each time.
-
@PleegWat said in Discussion of NodeBB Updates:
@accalia An image can say more than a thousand words. A hundred for me, a hundred for you, a hundred for @aliceif, a hundred for @ben_lubar, ...
It would be much better if those were the same 100 words each time.
QFT.
Edit: My pictures are not your pictures, it just goes downhill from there... :P
-
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post:
Feature request: a recognisable way to jump to a reply. So you can jump upthread as usual to see the post to which the current post was a reply, and then expand the replies-to-post and go back to where you were.
-
What is testing etc.
-
@PleegWat said in Discussion of NodeBB Updates:
The correct way for a forum like this to comply is to not set cookies if not logged in, and have the notice on login and/or account create.
Or not notice at all since once it's for login it's basic site functionality so you don't need the notice.You're almost there.
The correct way is to not do it, ignore the fucking thing-- and if anyone makes stink about it, point out that the forum and parent company is in the US, so suck a hairy sack of donkey ovaries of @apapadimoulis 's chosing.
-
@Mikael_Svahnberg said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
- Replies-to-post:
Feature request: a recognisable way to jump to a reply. So you can jump upthread as usual to see the post to which the current post was a reply, and then expand the replies-to-post and go back to where you were.
The timestamp is a permalink on most websites, including this one.
-
@ben_lubar so it is. TIL.
Not sure it would qualify as 'recognisable', though, but it's good enough for me. Thanks.
-
@ben_lubar said in NodeBB Updates:
- That's not a feature, but I thought you'd like to know.
I appreciate it!
-
@ben_lubar said in NodeBB Updates:
- New chat button (/cc @yamikuronue) https://github.com/NodeBB/NodeBB/issues/5084
Minor bug: if you click new chat with someone and then close it, continue chat opens that empty chat instead of the actual existing one
-
@Jaloopa said in Discussion of NodeBB Updates:
Minor bug: if you click new chat with someone and then close it, continue chat opens that empty chat instead of the actual existing one
Oh "New Chat" button. I kept reading that as new "Chat" button, like restyled or something and couldn't figure out what was going on. Actually, I still can't (INB4 )...where is this button?
Ah, true Web form, not a button but a menu item.
-
This post is deleted!
-
This post is deleted!
-
@ben_lubar said in NodeBB Updates:
watchdog.bash
removed
okay.... that got my attention........... why?
did we actually finally solve the cooties? or?
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
watchdog.bash
removed
okay.... that got my attention........... why?
did we actually finally solve the cooties? or?
It was freaking out and barking too much, so we had to put him down.
Must have been all the bitching or something...
-
@accalia said in Discussion of NodeBB Updates:
did we actually finally solve the cooties? or?
Hmm...looking at the logs...
{"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.792Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.794Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.796Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.821Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.824Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.851Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.852Z"} {"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-15T11:31:33.981Z"}
Well...that's interesting. All of our instances restarted at the same time. So before that, this starts happening:
{"level":"error","message":"[plugins] filter:parse.post, connection 2805 to wtdwtf-mongo:27017 timed out","timestamp":"2016-11-15T11:22:36.207Z"} {"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-15T11:31:14.960Z"} {"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-15T11:31:14.960Z"} {"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-15T11:31:14.961Z"}
OK, at 11:22 there was a mongo time out for some reason. But then at 11:31 shit hits the fan for some reason. There's more after that, plus some other related stuff, where all of the instances get shutdown and then everything starts back up.
@PJH was that you restarting something? [found out that yes, it was]
-
@ben_lubar said in NodeBB Updates:
Highlights
watchdog.bash
removed
OK, going to ask again. Why? I manually killed a bunch of node processes that were pegging the CPU and probably had been for quite a while.
-
@boomzilla Yesterday as well, I had to have Ben kill an instance that was at 100% CPU.
-
@Yamikuronue can we migrate to a toxic hellstew yet?
-
@boomzilla said in Discussion of NodeBB Updates:
OK, going to ask again. Why?
i never did get an answer to that.
i'd like one, but Ben rarely talks to me......
am i really that scary?
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
watchdog.bash
removed
OK, going to ask again. Why? I manually killed a bunch of node processes that were pegging the CPU and probably had been for quite a while.
It appeared that watchdog.bash was causing cooties. We've had a few instances peg, but nothing like what watchdog.bash was causing.
-
@ben_lubar said in Discussion of NodeBB Updates:
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
watchdog.bash
removed
OK, going to ask again. Why? I manually killed a bunch of node processes that were pegging the CPU and probably had been for quite a while.
It appeared that watchdog.bash was causing cooties. We've had a few instances peg, but nothing like what watchdog.bash was causing.
So you adjust the sensitivity, not outright kill the thing that was made to help! I mean, WTF?!?
-
@ben_lubar said in Discussion of NodeBB Updates:
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
watchdog.bash
removed
OK, going to ask again. Why? I manually killed a bunch of node processes that were pegging the CPU and probably had been for quite a while.
It appeared that watchdog.bash was causing cooties. We've had a few instances peg, but nothing like what watchdog.bash was causing.
We need a watchdog for the watchdog?
insert latin quote here
-
@Mikael_Svahnberg It's watchdogs all the way down!
-
@Tsaukpaetra The watchdog was only a temporary measure, if I remember rightly. We need to solve the fucking cooties issues.
-
@Yamikuronue said in Discussion of NodeBB Updates:
@Tsaukpaetra The watchdog was only a temporary measure, if I remember rightly. We need to solve the fucking cooties issues.
I'm working on some admin panel tools to help test my hypothesis.
-
Basically, it looks at the last time an instance started and takes any instance that restarted within a minute of that, then looks for users that were online in the last hour with IPs that could have routed them to the recently restarted instances.
Obviously right after an update this will be useless, since all users will be on recently restarted instances. Our best chance of finding what's causing it is if we get a few instances pegging and then kill those instances at the same time.
-
@boomzilla said in NodeBB Updates:
Killed watchdog.bash.
Was it killing well-behaved instances or what?