Discussion of NodeBB Updates
-
@ben_lubar said in NodeBB Updates:
Highlights
- Unannounced breaking change: https://github.com/NodeBB/NodeBB/commit/c33d3e874a688857368147d81e7a61d4b0a444be#commitcomment-19974668
What's the break?
-
@Lorne-Kates said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
- Unannounced breaking change: https://github.com/NodeBB/NodeBB/commit/c33d3e874a688857368147d81e7a61d4b0a444be#commitcomment-19974668
What's the break?
On the surface, an expansion on how getting topic IDs works. Not sure, can't see right now.
-
Why does mobile composer not let me type letters sometimes
-
@Lorne-Kates said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Highlights
- Unannounced breaking change: https://github.com/NodeBB/NodeBB/commit/c33d3e874a688857368147d81e7a61d4b0a444be#commitcomment-19974668
What's the break?
They added a parameter to the beginning of a function signature and it just completely hangs if you use the old signature for that function instead of giving an error or crashing.
-
@ben_lubar said in Discussion of NodeBB Updates:
They added a parameter to the beginning of a function signature and it just completely hangs if you use the old signature for that function instead of giving an error or crashing.
Because adding an OPTIONAL parameter to the end of the signature was just too hard?
-
@ben_lubar said in NodeBB Updates:
Why don't you just call it corn? Am I missing something?
-
@Luhmann
Raw popcorn is very different from the raw corn you get in the frozen (or canned, eeeew) foods section. It has to be grown to an exacting standard of moisture content, and harvested within a very tight range of acceptable moisture levels, otherwise it won't popcorn at all. Typically popcorn is harvested several weeks earlier than "standard" or feed corn, due to that higher moisture requirement. Of course, if the growing season doesn't cooperate with the requirements of the popcorn, it will likely get chopped and turned into silage, rather than harvested for future consumption.
-
@izzion @Luhmann If I remember correctly, the popcorn corn is actually next to the dried peas, rather than in the canned goods section. Though I may be misremembering, it's like 200g a bag which lasts for ages since I don't eat popcorn often.
Dutch label is "popcorn mais".
-
@PleegWat said in Discussion of NodeBB Updates:
@izzion @Luhmann If I remember correctly, the popcorn corn is actually next to the dried peas, rather than in the canned goods section. Though I may be misremembering, it's like 200g a bag which lasts for ages since I don't eat popcorn often.
Dutch label is "popcorn mais".You can just uck off with your bitching about !
-
@Luhmann said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Why don't you just call it corn? Am I missing something?
Raw corn may sound like fun, but there are maybe health and safety issues to take into account, both for the top and bottom. Sure, porn makes it look easy and carefree, but there is a lot of behind-the-scenes preparation and off-camera safety measures you don't get to see.
-
@Lorne-Kates said in Discussion of NodeBB Updates:
health and safety issues
sure ... don't forget the goggles!
-
-
@accalia
So you had a bad experience ... sometimes it's more a drizzle then a geyser
-
TypeError: e is undefined
https://what.thedailywtf.com/nodebb.min.js?7002924311d1
Line 10
-
Can I just say, the Raw button is in absolutely the worst place. The first button in the row should be an action the user does frequently, as should the last; they're the easiest targets to find while scanning the row. Every damn time, I go hit the first button, starts with an
r
, and get raw instead of reply.
-
I agree with whoever said the popcorn and raw buttons should be under the button.
-
@Zecc Particularly if you also have posting permission for that thread.
I could also see popcorn (and reply as topic) being under the reply button, similar to how the topic-wide reply as topic is under the topic-wide reply button. Then if you don't have reply permission, the button could become a popcorn or reply as topic button instead, in that priority order.
-
@Zecc absolutely!
though i'm okay with popcorn popping out of that menu if there are no reply/quote buttons because permissions.
-
Ok so it turns out last time I updated the NodeBB instance never actually switched over and we were on the old version for 2 extra days, even though both versions were running.
-
@PleegWat said in Discussion of NodeBB Updates:
I could also see popcorn (and reply as topic) being under the reply button, similar to how the topic-wide reply as topic is under the topic-wide reply button.
Yes, but I didn't know how to do that.
...I mean, it would have been more work, and I was lazy.
-
@accalia said in Discussion of NodeBB Updates:
though i'm okay with popcorn popping out of that menu if there are no reply/quote buttons because permissions.
Speaking of permissions, it seems Raw is not available in One Post or in other locked threads (e.g. the updates thread). I don't see why it shouldn't be there?
-
@remi said in Discussion of NodeBB Updates:
Raw is not available in One Post
-
@RaceProUK Oh, I missed the fact that the button has already moved to the "..." menu. Thanks.
-
@ben_lubar said in Discussion of NodeBB Updates:
Ok so it turns out last time I updated the NodeBB instance never actually switched over and we were on the old version for 2 extra days,
even thoughbecause both versions were running.A problem with the update script / process? Shouldn't the old version ('s docker container) shut down once the new version is up?
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Ok so it turns out last time I updated the NodeBB instance never actually switched over and we were on the old version for 2 extra days,
even thoughbecause both versions were running.A problem with the update script / process? Shouldn't the old version ('s docker container) shut down once the new version is up?
Yes, but I changed the script to display the logs for startup instead of printing "Waiting for NodeBB..." over and over, and after the site is detected to be ready to switch over, it kills the log reader process and waits for it to exit, which results in the update script stopping due to the error code from waiting for a killed process. So it never runs the last three commands, which are:
- switch upstream in nginx
- stop old instance
- delete old instance
-
-
@Fox It's more inclusive. Now it applies to anyone who might want a rainbow on their flag
-
About the 'raw' now in the mini-hamburger, vertical spacing looks ugly
FF 50.0.2
-
@cabrito Not really: there's dividers to separate sections of the menu
-
@cabrito Looks ok(?) to me:
-
@aliceif yeah, it's just the divider taking up some extra space, which is controlled by
.dropdown-menu .divider { margin: 9px 0; }
.That divider and the two options above it are originally something from my userscript code. It put "Reply as topic" and a divider directly above the "Bookmark" option, and added "View raw" as a button. People complained about the button so it got moved into the menu.
-
@ben_lubar said in NodeBB Updates:
Allowed uploads in iframely. Updated iframely to 1.0.0.
Who'll be first to break it? Place yer bets! :D
-
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Allowed uploads in iframely. Updated iframely to 1.0.0.
Who'll be first to break it? Place yer bets! :D
To be clear, that's URLs starting with https://what.thedailywtf.com/uploads/, not actual file transfers to the iframely container.
-
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Allowed uploads in iframely. Updated iframely to 1.0.0.
Who'll be first to break it? Place yer bets! :D
@ben_lubar does it rebake old posts?
https://what.thedailywtf.com/post/1050111
The image link in OP isn't dumbboxing.
-
@Lorne-Kates said in Discussion of NodeBB Updates:
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Allowed uploads in iframely. Updated iframely to 1.0.0.
Who'll be first to break it? Place yer bets! :D
@ben_lubar does it rebake old posts?
https://what.thedailywtf.com/post/1050111
The image link in OP isn't dumbboxing.
It still isn't:
https://what.thedailywtf.com/uploads/files/1472952921478-iceewhatyoudidthere-resized.png
-
@anotherusername said in Discussion of NodeBB Updates:
@Lorne-Kates said in Discussion of NodeBB Updates:
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
Allowed uploads in iframely. Updated iframely to 1.0.0.
Who'll be first to break it? Place yer bets! :D
@ben_lubar does it rebake old posts?
https://what.thedailywtf.com/post/1050111
The image link in OP isn't dumbboxing.
It still isn't:
https://what.thedailywtf.com/uploads/files/1472952921478-iceewhatyoudidthere-resized.png
Hmm, I'll need to get that changed.
-
-
@RaceProUK said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- NodeBB 1.4.0!
hunting time!
It's like 0.1% different from what we're currently running because the version number only went up due to the breaking change that's already on this forum.
-
Anyone else got a completely screwed composer? Arrow keys, backspace and any shortcuts don't work. I can't even go to a new line. Windows 7, chrome 54
Edit: Not a forum problem, restarting my PC worked. Whatever the cleaners did to my keyboard last night, it wasn't happy about it
-
@ben_lubar said in NodeBB Updates:
we're twice as polished!
stop rubbing NodeBB all day! Watch some normal porn for a change.
-
@Luhmann said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
we're twice as polished!
stop rubbing NodeBB all day! Watch some normal porn for a change.
Why_not_both?
-
@Luhmann said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
we're twice as polished!
stop rubbing NodeBB all day! Watch some normal porn for a change.
-
@ben_lubar said in NodeBB Updates:
Fixed composer style.
Mobile composer's still kinda fucked up though.
-
Testing
This seems normal...
What mobile device are you on?
-
@ben_lubar Looks like an iPhone.
By the way, this issue with the composer on iPad has returned.
-
@ben_lubar it's Chrome on an iPhone 4.
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar it's Chrome on an iPhone 4.
Goddamn lying browser names
-
Well, there's your problem. You can't just call
preventDefault
on some random object that doesn't have any methods, which is what the resizeStart method does as its first statement.
-
@ben_lubar said in Discussion of NodeBB Updates:
Well, there's your problem. You can't just call
preventDefault
on some random object that doesn't have any methods, which is what the resizeStart method does as its first statement.
-
@ben_lubar said in NodeBB Updates:
- @Hitoshirenu-Shourai is subbing in for @error in The Impossible Mission
I thought you'd already done that?