Discussion of NodeBB Updates
-
@jaloopa That's a pretty good low-effort way to address the problem as well.
At some point (pending time, motivation, etc) I may add a css export feature to my userscript so that I can propagate my selective inversion to mobile (and wherever I don't have userscripts).
-
@jaloopa how do you do that? I can't seem to find the option to do that on mobile -_-
-
-
@polygeekery now if only there was a similarly easy-to-access WTDWTF-specific checkbox to disable WTDWTF CSS in times of need?
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery now if only there was a similarly easy-to-access WTDWTF-specific checkbox to disable WTDWTF CSS in times of need?
I couldn't find a checkbox, but I found this Chak box. Will that help?
-
@ben_lubar said in Discussion of NodeBB Updates:
Will that help?
You really have to try to be less helpful than @boomzilla, but you seem to have made that your life's work.
-
@polygeekery said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Will that help?
You really have to try to be less helpful than @boomzilla, but you seem to have made that your life's work.
Try clicking the chak box and then refreshing. That might help.
-
-
@ben_lubar said in Discussion of NodeBB Updates:
Try clicking the chak box and then refreshing. That might help.
-
speaking of updates, is it just me, or do links not properly sub-frame on Android Chrome in App anymore? I keep having to tap-hold to open in Chrome....
-
@tsaukpaetra said in Discussion of NodeBB Updates:
in App
What app? Just any old app that opens Chrome, or do we have a TDWTF-specific one?
-
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery now if only there was a similarly easy-to-access WTDWTF-specific checkbox to disable WTDWTF CSS in times of need?
I couldn't find a checkbox, but I found this Chak box. Will that help?
I think this should turn it off:
Nope. How do we get rid of it?
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery now if only there was a similarly easy-to-access WTDWTF-specific checkbox to disable WTDWTF CSS in times of need?
I couldn't find a checkbox, but I found this Chak box. Will that help?
I think this should turn it off:
Nope. How do we get rid of it?
I think
either empty string or justrefreshing without that parameter will work.
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@polygeekery now if only there was a similarly easy-to-access WTDWTF-specific checkbox to disable WTDWTF CSS in times of need?
I couldn't find a checkbox, but I found this Chak box. Will that help?
I think this should turn it off:
Try this on for size.
-
-
@ben_lubar I retyped the URL in the address bar and hit enter.
-
@ben_lubar said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
in App
What app? Just any old app that opens Chrome, or do we have a TDWTF-specific one?
The thing that happens when you press the three do dots and choose "add to home screen" and causes Chrome to pretend the site is an App.
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar I retyped the URL in the address bar and hit enter.
And for those who have no address bar due to the above-mentioned App-ification?
-
@tsaukpaetra
Throw your phone away and get an iPhone
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar I retyped the URL in the address bar and hit enter.
And for those who have no address bar due to the above-mentioned App-ification?
Did, it hurts when I do that!
Don't do that.
-
@boomzilla said in Discussion of NodeBB Updates:
@tsaukpaetra said in Discussion of NodeBB Updates:
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar I retyped the URL in the address bar and hit enter.
And for those who have no address bar due to the above-mentioned App-ification?
Did, it hurts when I do that!
Don't do that.I haven't seen the issues mentioned in this topic because of it, so... Doesn't hurt that much.
-
@ben_lubar said in Discussion of NodeBB Updates:
Try clicking the chak box and then refreshing. That might help.
Oh god, this is horrible. Is this vanilla NodeBB?
-
@polygeekery said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Try clicking the chak box and then refreshing. That might help.
Oh god, this is horrible. Is this vanilla NodeBB?
Basically.
Edit: oh! Everyone has little lights on their profile pic! So that's why you can set yourself away and whatnot.
Too bad you can't do that on mobile.edit edit: WTF the options just plopped in?!Consistent.
-
@tsaukpaetra said in Discussion of NodeBB Updates:
I haven't seen the issues mentioned in this topic because of it, so... Doesn't hurt that much.
Oh, that's an interesting solution.
-
@polygeekery oh ffs, I was fooled by the offset on html elements, I thought I was in settings, but I was in profile...
-
@hungrier said in Discussion of NodeBB Updates:
That's a pretty good low-effort way to address the problem as well.
The approves.
-
@ben_lubar said in NodeBB Updates:
- Removed
nodebb-plugin-upvote-notifications
. - Added its functionality to core, but not in the broken way it was implemented.
- Modified user settings to use the core functionality.
The localization on that setting is borked. I have a screenshot, but idk how to upload files on mobile.
- Removed
-
@erufael said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- Removed
nodebb-plugin-upvote-notifications
. - Added its functionality to core, but not in the broken way it was implemented.
- Modified user settings to use the core functionality.
The localization on that setting is borked. I have a screenshot, but idk how to upload files on mobile.
Since the PR hasn't been accepted yet, it's only localized on en-GB.
- Removed
-
@ben_lubar So the menu having "upvote-notif-freq.first" and "upvote-notif-freq.threshold" is normal on en-US? Just making sure.
-
@erufael said in Discussion of NodeBB Updates:
@ben_lubar So the menu having "upvote-notif-freq.first" and "upvote-notif-freq.threshold" is normal on en-US? Just making sure.
Yeah, that's what it'll be like until it goes through the localization pipeline.
-
@ben_lubar said in NodeBB Updates:
- Removed
nodebb-plugin-upvote-notifications
. - Added its functionality to core, but not in the broken way it was implemented.
- Modified user settings to use the core functionality.
You couldn't have cross-imported our old setting before you decided to test this in production?Edit: Which is to say, if you intended to pull my "threshold" setting across, which is one way to interpret the last bullet point, that process didn't work. And if you didn't intend to do that, :pitchforkAndTorch.gif:
- Removed
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- Removed
nodebb-plugin-upvote-notifications
. - Added its functionality to core, but not in the broken way it was implemented.
- Modified user settings to use the core functionality.
You couldn't have cross-imported our old setting before you decided to test this in production?Edit: Which is to say, if you intended to pull my "threshold" setting across, which is one way to interpret the last bullet point, that process didn't work. And if you didn't intend to do that, :pitchforkAndTorch.gif:
Here's exactly what my SQL query did to your settings:
nodebb=# select jsonb_set(data - 'upvoteNotificationLevel', '{upvoteNotifFreq}', to_jsonb(case when data->>'upvoteNotificationLevel' = 'none' then 'disabled' else coalesce(coalesce(nullif(data->>'upvoteNotificationLevel', 'all'), data->>'upvoteNotifFreq'), 'all') end)) from legacy_hash where _key = 'user:970:settings'; jsonb_set {[...], "upvoteNotifFreq": "threshold", [...]} (1 row)
except as an
UPDATE
instead of aSELECT
.
- Removed
-
@ben_lubar
Looks like thereâs a problem with at least the front-end for ârememberingâ the upvote notifications setting on my Settings page. Prior to my previous response in this thread, I set my setting to âthresholdâ on the settings page and saved it, and if I go to the settings page now, it shows âall upvotesâ.Edit to add: issue seems to be general with the setting. I just tried with one of the old values (that have been fully localized) and the same behavior is occurring. Not sire that Iâve gotten enough upvotes in the past 10 minutes to speak definitively to what behavior is being used for actual notifications.
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar
Looks like thereâs a problem with at least the front-end for ârememberingâ the upvote notifications setting on my Settings page. Prior to my previous response in this thread, I set my setting to âthresholdâ on the settings page and saved it, and if I go to the settings page now, it shows âall upvotesâ.Edit to add: issue seems to be general with the setting. I just tried with one of the old values (that have been fully localized) and the same behavior is occurring. Not sire that Iâve gotten enough upvotes in the past 10 minutes to speak definitively to what behavior is being used for actual notifications.
oh, it's apparently always been broken O_o
-
@ben_lubar
Yay for HTML properties, and the inconsistencies of which ones are actual booleans versus wish-it-were-booleans.
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar
Yay for HTML properties, and the inconsistencies of which ones are actual booleans versus wish-it-were-booleans.Yay for the database using stringly-typed data almost everywhere.
-
@izzion said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
- Removed
nodebb-plugin-upvote-notifications
. - Added its functionality to core, but not in the broken way it was implemented.
- Modified user settings to use the core functionality.
You couldn't have cross-imported our old setting before you decided to test this in production?Edit: Which is to say, if you intended to pull my "threshold" setting across, which is one way to interpret the last bullet point, that process didn't work. And if you didn't intend to do that, :pitchforkAndTorch.gif:
YMBNH
- Removed
-
Latest update:
-
@hungrier Ouch, that's definitely coming from Postgres.
-
@hungrier said in Discussion of NodeBB Updates:
Latest update:
Upped connection limit from 100 to 500. I'm assuming each of the 8 instances was able to open 10 connections or more.
-
@ben_lubar said in Discussion of NodeBB Updates:
Upped connection limit from 100 to 500. I'm assuming each of the 8 instances was able to open 10 connections or more.
8 * 10 = 80
80 < 100
Let's fix that:
@ben_lubar said in Discussion of NodeBB Updates:
Upped connection limit from 100 to 500. I'm assuming each of the 8 instances was able to open
1013 connections or more.FTFY
-
@polygeekery I'm pretty sure NodeBB uses at least one non-pooled connection for pubsub, possibly 2.
-
More "core" notification rollup feature QA:
Hard to catch the unread screenshot at this point, but the notification for my 5th upvote on this post (https://what.thedailywtf.com/post/1374876) came in as "anotherusername has upvoted your post in Discusson of NodeBBUpdates", as opposed to the "anotherusername and 4 others" behavior that existed with the bz plugin.
Not sure it's a bug in the classical definition of the word, but seems like a behavior oversight for the threshold notification schemas to me - the more desireable behavior would be to mirror the bz plugin behavior to tell you which upvote that was (1, 5, 10, 100, etc)
-
-
@PJH said in https://github.com/NodeBB/NodeBB/pull/6640#issuecomment-403724777
how else would one efficiently check if a number is a power of ten, or 5x a power of ten?
I'd go for bit-twiddling, to check for powers of 2, and 2 times powers of two....
(emphasis added) Someone needs more coffee!
-
@twelvebaud said in Discussion of NodeBB Updates:
@PJH said in https://github.com/NodeBB/NodeBB/pull/6640#issuecomment-403724777
how else would one efficiently check if a number is a power of ten, or 5x a power of ten?
I'd go for bit-twiddling, to check for powers of 2, and 2 times powers of two....
(emphasis added) Someone needs more coffee!
Not that you'll believe me, but that was actually deliberate.
-
I have a suggestion for better a
:seye:
emoji:
Compare to the current
:seye:
:
Subtle difference, isn't it? But IMO it makes it go together better with
:eyes:
:Current:
New:
-
@zecc It's supposed to be flipped. That's what it is.
-
@zecc Make a PR then.
-
@pie_flavor said in Discussion of NodeBB Updates:
@zecc Make a PR then.
What do you think my post above was?