What the inline shit is this?
-
-
@Lorne-Kates What, indeed. I, uh, can't see the problem?
-
@lolwhat I am glad I am not the only one...
-
@lolwhat said in What the inline shit is this?:
the problem?
It's the issue with the button borders being weird with the margin. Discussed elsewhere IIRC.
-
@Tsaukpaetra said in What the inline shit is this?:
It's the issue with the button borders being weird with the margin.
How are they weird?
-
@Lorne-Kates Really? this is the equivalent of FWP in Node bugs. When you light-theme majority only need to worry about imaginary cute s we dark-themers have to deal with this crap:
Do you see the problem? Nope, I do not see anything.
-
@blakeyrat said in What the inline shit is this?:
@Tsaukpaetra said in What the inline shit is this?:
It's the issue with the button borders being weird with the margin.
How are they weird?
To my recollection, because their position is offset due to borders not counting in the post alignment or something. Apparently artisan GUI designers cringed.
-
@Tsaukpaetra Ok... so the screenshot is demonstrating, and I quote, "borders not counting in the post alignment or something".
That really helps me understand the WTF a lot.
-
@blakeyrat the top edge of the buttons is higher than the signature line. I think the buttons are supposed to be below the signature line
-
@bb36e And that's... somehow a problem? I guess?
Whatever.
-
@dse said in What the inline shit is this?:
we dark-themers have to deal with this crap:
-
@bb36e said in What the inline shit is this?:
@blakeyrat the top edge of the buttons is higher than the signature line. I think the buttons are supposed to be below the signature line
AFAIK, the buttons should be BELOW the signature, on their own line.
Suddenly they're not.
Meaning someone fucked up the .css and didn't even bother fixing one of the most visible things on the forum.
Again.
Which means there's 100 other .css things fucked up we haven't found yet.
-
@Lorne-Kates said in What the inline shit is this?:
AFAIK, the buttons should be BELOW the signature, on their own line.
I've never witnessed this. Maybe on Mobile, when the signature line could be so wide it would overflow the buttons, but not typically.
-
@dse said in What the inline shit is this?:
I do not see anything.
I don't care about notifications I've seen. ;)
Truly, once I've actioned a notification, I shouldn't see it except through the
historicalAll notifications route.
-
@Tsaukpaetra said in What the inline shit is this?:
Truly, once I've actioned a notification, I shouldn't see it except through the historicalAll notifications route.
It's almost as if I've filed that bug multiple times. And each time just get a robot answer of "notifications stay active for X days".
-
@Lorne-Kates said in What the inline shit is this?:
It's almost as if I've filed that bug multiple times.
Almost!
-
@Tsaukpaetra said in What the inline shit is this?:
@Lorne-Kates said in What the inline shit is this?:
It's almost as if I've filed that bug multiple times.
Almost!
!tsomlA
-
@Lorne-Kates said in What the inline shit is this?:
Which means
You do realize that the buttons are entirely WTDWTF's CSS, right? And that your signature doesn't extend infinitely to the right?
As far as I know, the reply/quote/upvote/downvote buttons have always been on the far right.
-
@ben_lubar I'm pretty sure this is literally to the point of bikeshedding. Like, real, no kidding, 100% bikeshedding.
-
@sloosecannon
Yes but that shouldn't stop us from repainting it in seasonal appropriate colors. I propose vertical bands of black, yellow and red.
-
I've read through the entire thread, like a good boy, and I still don't see the problem.
Emphasis on the word "problem".
-
-
Would you rather waste vertical space? I actually prefer it the way it currently is.
-
@cartman82 said in What the inline shit is this?:
I've read through the entire thread, like a good boy, and I still don't see the problem.
Emphasis on the word "problem".
You shouldn't be a good boy, you should be telepathic.
-
@r10pez10 Ok, but why is this a problem?
AFAICT this whole thread is about how @Lorne-Kates expected the layout to work a certain way, but then he learned it actually works slightly differently, and he doesn't handle change very well.
-
@Luhmann said in What the inline shit is this?:
Yes but that shouldn't stop us from repainting it in seasonal appropriate colors. I propose vertical bands of black, yellow and red.
Your sense of colour coordination is really belgiumed up...
-
@Onyx
As long as you don't do horizontal stripes we are good. I don't want the shed to look fat.
-
@dse said in What the inline shit is this?:
this is the equivalent of FWP in Node bugs.
we'll let you change to a lighter theme, but only if you can post in a style that none of us already do.
-
@r10pez10 Right; I see the behavior, but I don't see why its a problem.
Especially when NodeBB has about 58,000 other behaviors that are obvious problems.
-
signatures are an anti-feature anyway
-
The signature is as wide as the dotted line above it.
-
Well thanks, Lorne, I can never unsee it
-
Let's see what an exceptionally long and non-breakable signature does.
It breaks. The layout.
Bug #2. No line breaking algorithm applied to .sig, no overflow applied to .sig.
[edit] signature removed, screeny added.
-
@Tsaukpaetra said in What the inline shit is this?:
their position is offset due to borders not counting in the post alignment or something.
It's the padding. Specifically, the top and bottom padding. The
<a>
element is automaticallydisplay: inline;
andpadding-top
andpadding-bottom
will overflow it.
-
@Lorne-Kates said in What the inline shit is this?:
AFAIK, the buttons should be BELOW the signature, on their own line.
Never have been, that I can recall.
It's not really a problem until someone posts something at the bottom of their post that doesn't get a
margin-bottom: 10px;
style, and wide enough that it overlaps the buttons. And then the response has been to give it amargin-bottom
.
-
@ben_lubar said in What the inline shit is this?:
As far as I know, the reply/quote/upvote/downvote buttons have always been on the far right.
Yes, the have. But like this:
signature (.................. buttons)
Not:
signature (................ buttons)
-
@Yamikuronue said in What the inline shit is this?:
Well thanks, Lorne, I can never unsee it
That's the point of a bug report.
-
@cartman82 said in What the inline shit is this?:
AFAICT this whole thread is about how @Lorne-Kates expected the layout to work a certain way, but then he learned it actually works slightly differently, and he doesn't handle change very well.
The whole point of the thread is that it worked some way and now doesn't.
Which means it should be fixed, and it means that other things probably don't work.
So someone who is a NodeBB dev should look into why it broke, so they'll know what else has broken.
-
@Lorne-Kates said in What the inline shit is this?:
why it broke
You still haven't said what is broken. All you've done is mention some expected behavior.
-
@tufty said in What the inline shit is this?:
Let's see what an exceptionally long and non-breakable signature does.
It breaks. The layout.
Bug #2. No line breaking algorithm applied to .sig, no overflow applied to .sig.
[edit] signature removed, screeny added.
How exactly do you suppose they should break an unbroken line of text?
-
@Lorne-Kates you remember wrong. It's always been like this.
-
@sloosecannon said in What the inline shit is this?:
How exactly do you suppose they should break an unbroken line of text?
word-wrap: break-word;
akaoverflow-wrap: break-word;
?
-
@anotherusername said in What the inline shit is this?:
@Lorne-Kates you remember wrong. It's always been like this.
I question the truth of that.
Of course, since this is Continuous Integration and there's no concept of a "previous version", we'll never know, will we?
-
@sloosecannon said in What the inline shit is this?:
How exactly do you suppose they should break an unbroken line of text?
He is TRWTF, because his screenshot doesn't show how it breaks the layout. It does break the layout, though: it lets the signature extend past the right edge of the window, and the whole page gets a horizontal scrollbar. Just go in the inspector and edit the contents of a sig element to see it in action.
I suppose it should just cut off the contents at a certain point.
-
-
@sloosecannon said in What the inline shit is this?:
@anotherusername Oh.
Nice.
That's... an issue.
What happens if you have a string that long full of zalgos?
-
@Luhmann said in What the inline shit is this?:
@sloosecannon
Yes but that shouldn't stop us from repainting it in seasonal appropriate colors. I propose vertical bands of black, yellow and red.Paging @aliceif
-
@Magus Horizontal. And in a different order.
-
@tufty said in What the inline shit is this?:
no overflow applied to .sig
I̮̲̗͠t҉̺̺ ͚̥͕̮̯̭͟me̮͕͖̦ḁ̘̟̫̣ͅn̡͚s͏͔͔͇̩͔͎ ͈̻̀z̼̝͇͚͎̰͕al̵g̸͔o͔̮ ̝̰̦ma͞y͕ ̩͇͚̯̞̙͢c̛͖̬̯̯̮o̥̫͟m̨͕̯̼̰̗̣e̡ ͚͈͙͚̟t͉h͍r̺ơu̠̦͘g̢̖̠̠͍͓h͝ ̙̫͚͘t̺̘h͍̞̹e҉̯̘̫̗ ̭͙̯͔s̠̲̖̳͖i̞͉̞̺̱̟̞͘g?̶̻̰̼̲̗̣̙
-
@Lorne-Kates said in What the inline shit is this?:
What happens if you have a string that long full of zalgos?
NO LONGER WELCOME HERE