Ignoring a topic
-
@Magus said in Ignoring a topic:
This place supports pasting images directly slightly better than Discourse
Beg pardon, but this doesn't support pasting images at all in Firefox. And Discourse did.
-
@blakeyrat said in Ignoring a topic:
@boomzilla said in Ignoring a topic:
Thanks for following up... I believe internally we are concerned that the function of the various states are not intuitive to first time users...
As opposed to this:
Which is immediately intuitive to everybody.
What clowns.
It's immediately obvious to me, but I'm not going to tell you because there's already a thread for Blakeyrat to complain about NodeBB
-
@Lorne-Kates said in Ignoring a topic:
It's immediately obvious to me, but I'm not going to tell you because there's already a thread for Blakeyrat to complain about NodeBB
Good point. Did you flag it?
-
My PR was closed. Looks like one of the devs has started a branch to work on this.
It appears to be largely based on what I did.
-
@boomzilla Sounds like a dick move to me, but I don't know if that's "normal" in shoddy open source development processes.
-
@blakeyrat It depends on if you're more interested in getting the feature done or getting credit for the feature. The important thing is that you idiots stop complaining about this issue.
-
@boomzilla I put $50 on "his version has more bugs than yours did".
-
@blakeyrat I wouldn't take that bet, but he did at least bring along the tests that I wrote.
-
@boomzilla Well just give me $50 then.
-
@blakeyrat No way. You didn't even say, "Fuck you."
-
@blakeyrat upvotes are a good way to eliminate a ton of +1 and me too posts that would happen if we didn't have it.
-
@fbmac +1
-
@flabdablet me too
-
@blakeyrat said in Ignoring a topic:
Sounds like a dick move to me
@boomzillawtf this is mostly based on your work in the other PR, I fixed a bunch of issues I saw there like
cid:<cid>:ignorers
not existing and the call tocategories.filterIgnoringUids()
making uids.length calls instead which is quite slow if you have lots of online users.
👍 2Yeah, what a dick move of @barisusakli to improve the changes @boomzilla proposed.
-
@ben_lubar I have also butchered contributions before but at least I kept the original committer as owner of the initial commit.
I guess Boomzilla won't mind but it's a matter of honor. Somebody did a bunch of research and you're not giving them credit.
-
@ben_lubar said in Ignoring a topic:
Yeah, what a dick move of @barisusakli to improve the changes @boomzilla proposed.
If it's what blakey would do, it's probably a dick move by default…
-
The topic watching PR has been merged into master (marked for the 1.1.0 milestone). I kind of doubt that I'll have time to pull it down locally and test today.
-
-
@boomzilla So the merged version doesn't mute notifications. I have to admit I like that better. The descriptions are also a bit better now.
-
@asdf said in Ignoring a topic:
So the merged version doesn't mute notifications
He said it does:
Ignoring a topic will remove it from the /unread list and you won't get the There is a new post notification on the /unread and /recent pages. You will also not get reply notifications.
And then he said it doesn't:
These settings only effect the new reply notifications so you will still get notifications if someone mentions you in a ignored topic or if one of your posts is upvoted.
So I guess you will only get notifications from Schrödinger's cat.
-
@ben_lubar said in Ignoring a topic:
Yeah, what a dick move of @barisusakli to improve the changes @boomzilla proposed.
Yeah but he could just point those changes out and let Boomzilla make them (isn't that what code reviews are FOR!?), instead of making a new branch where HE becomes the author and takes the credit.
Whatever. I'd never participate in a development methodology that produces ass like this forum. Because it obviously doesn't work.
-
@blakeyrat It probably would have been less work to have pulled my branch into his repo and worked from that. I assume he did that, but made a patch or something and then worked in a new branch.
-
@boomzilla Well if you don't care, you don't care. But it still sounds like a dick move to me.
I thought the "payment" for open source was you get your name plastered all over the shitty product and your ego gets a big boost woooooo!
-
@blakeyrat said in Ignoring a topic:
I thought the "payment" for open source was you get your name plastered all over the shitty product and your ego gets a big boost woooooo!
It's certainly one form. In this case I'm more interested in the feature itself. It's not like my name name was going to get any credit on this.
SPOILER ALERT: boomzilla isn't the name on my driver's license. Cue jokes about the license is fake.
-
@boomzilla said in Ignoring a topic:
Cue jokes about the license is fake.
Or it just predates having to have a name on your license. It's a horse drawn carriage license right?
-
They also fixed the confusing watch/ignore button on the category pages:
-
@NedFodder A CHECKMARK icon?!
What an inventive and creative idea!!!
-
@boomzilla said in Ignoring a topic:
I kind of doubt that I'll have time to pull it down locally and test today.
It's live on community.nodebb.org now.
-
@NedFodder I guess he means the notifications you get when you watch topics when he says "new reply notifications". Because NodeBB implements notifications for direct replies using mentions.
-
@asdf You are correct. I had to read what he wrote several times to figure that out.
-
@boomzilla said in Ignoring a topic:
Cue jokes about the license is fake.
I was more thinking about jokes about your alternative accounts ...
-
@anotherusername said in Ignoring a topic:
Firefox
-
@FrostCat like the guy in that picture, if you think the problem is Firefox you're looking in exactly the wrong place. I'm not sure if that was deliberate or ironic. If deliberate, I'll accept my .
-
@anotherusername said in Ignoring a topic:
I'm not sure if that was deliberate or ironic.
Both. If you didn't know, i'm not a big fan of Firefox.
-
@FrostCat Yeah but you use Edge.
-
@FrostCat it does what it's designed for, and does it pretty well. Like that car, it's not designed to be a boat.
-
@boomzilla said in Ignoring a topic:
Yeah but you use Edge.
What's your point, O Captain ? Edge gets better with every release, unlike FF. With 13432 the main problem I see at this point is a couple of lingering issues where sometimes the browser stops recognizing keystrokes in the search bar for a few seconds, or clicking the X to close a tab doesn't register immediately.
-
Now that we have this feature, is there a way of adding the UI to the topics list (like /unread)? That way I can ignore a topic without going into it / going to the end.
Failing that, what JSON do I need to emit to ignore a topic? (I can poop something up in a userscript)
-
@Lorne-Kates said in Ignoring a topic:
Now that we have this feature, is there a way of adding the UI to the topics list (like /unread)? That way I can ignore a topic without going into it / going to the end.
Failing that, what JSON do I need to emit to ignore a topic? (I can poop something up in a userscript)
Wait, what--- I Just turned on Firebug, went to the Net panel, and changed my watch settings. There's no AJAX call.
How the hell does this work if it doesn't contact the server?!?
-
@Lorne-Kates websockets
here ya go.
function changeWatching(tid, type, callback){ callback = callback || function(){}; //callback's optional i guess window.socket.emit('topics.changeWatching', { tid: tid, type: type }, callback); } function watchTopic(tid, callback){ changeWatching(tid, 'follow', callback); } function normalTopic(tid, callback){ changeWatching(tid, 'unfollow', callback); } function ignoreTopic(tid, callback){ changeWatching(tid, 'ignore', callback); }
callback, if you care to use it will be called with parameters
(err, result)
, both of which will be null on success.
-
@accalia for the sake of completeness, the other two commands appear to be
follow
andunfollow
.
-
@anotherusername updated script above to reflect this.
-
@Lorne-Kates It's always something with you ungrateful fuckers.
-
and because i'm so generous..... here's a bookmarklet to ignore the current topic.
javascript:(function()%7Bvar%20tid%20%3D%20parseInt(location.pathname.split('%2F')%5B2%5D%2C10)%3Bwindow.socket.emit('topics.changeWatching'%2C%7Btid%3A%20tid%2Ctype%3A%20'ignore'%7D%2Cfunction()%7B%7D)%7D)()
-
@accalia or just
javascript:void($('a[component="topic/ignoring"]').click());
That way, the toaster appears telling you it happened and the UI updates to show that you're ignoring it.
-
@anotherusername said in Ignoring a topic:
@accalia or just
javascript:void($('a[component="topic/ignoring"]').click());
That way, the toaster appears telling you it happened and the UI updates to show that you're ignoring it.
or that.....
-
I was going to write a userscript that would add a button to every Topic on the topic list...
except that NodeBB's hooks either:
- Don't work
- Don't work on /unread
- Don't work when pagination is turned on
Filed bug on NodeBurpBurp