On Jellypotato...
-
@ben_lubar not to mention ImageShack or similar where the image is removed later.
-
@Salamander said in On Jellypotato...:
Boomzilla's idea has neither of those issues, but instead requires more effort to determine if something is visible
javascript or jquery has an event for when an element becomes visible. @boomzilla solution is trivial to implement afaik, and would perfectly.
-
@fbmac said in On Jellypotato...:
@boomzilla solution is trivial to implement afaik, and would perfectly.
First rule of software development: nothing works perfectly
-
@RaceProUK said in On Jellypotato...:
@fbmac said in On Jellypotato...:
@boomzilla solution is trivial to implement afaik, and would perfectly.
First rule of software development: nothing works perfectly
I thought it was "works fine on my PC"
-
@DogsB said in On Jellypotato...:
I thought it was "works fine on my PC"
That's the first rule of debugging :P
-
@RaceProUK only when we started doing guis, threads and dlls. at ms-dos times, many software were flawless.
-
@fbmac To be fair, a flawless wasteland is still a wasteland.
-
Edit: My face is HUGE
Edit 2: I take no responsibility for any ill effects this commit causes.
-
@julianlam Wow, it seems to work for now.
@end please take note on how to handle these bug-reports.Filed Under: Thanks
-
@julianlam I'm not convinced the solution's working well: https://what.thedailywtf.com/topic/14061/the-fox-ideas-thread/1209
I'm seeing all the pics fixed at 10px tall, and they don't get biggerChrome 49.numbers on Windows 10
cc @ben_lubar
-
@RaceProUK I see some of the pictures that way.
The way I see it, thats a feature. All the bad pictures are gone :PFiled Under: Still thanks
-
@RaceProUK the HTML sanitizer doesn't work with the new markdown plugin. Working on a fix.
-
@Onyx said in On Jellypotato...:
You could try to get some preliminary post sizes using PhantomJS
-
Ok, so we now have a lot less jellypotato.
Unfortunately, we also have a lot more images-not-loading-without-javascript.
-
@ben_lubar said in On Jellypotato...:
Unfortunately, we also have a lot more images-not-loading-without-javascript.
Whoever was it that was crying his little eyes out about the noscript crap can take one for the team.
-
@cartman82 well, it's mostly search engines that I'm worried about.
-
@Salamander said in On Jellypotato...:
What's there stopping me from just hotlinking to a 1x99999 png?
I was going to say โthe GIF spec only uses 16 bits for each dimensionโ but then I reread what you wrote and saw that it was PNG; PNG uses 32-bits for size measures.
Fuck knows why they bothered given that 64k is a freaking huge linear dimension for an image (and requires an ass-load of data to fill out) but it future-proofs the format for quite a whileโฆ
-
@dkf Some of the images you can get from the JPL get pretty big
-
@dkf said in On Jellypotato...:
โthe GIF spec only uses 16 bits for each dimensionโ
hmm... so a maximum sized GIF would be 4GB per frame (uncompressed)....
and assuming 4 channels at one byte per channel that max res PNG would be well over 70 exabytes.....
that's a massive image.
-
Almost fixed guys, just working out a few niggling bugs...
-
@julianlam said in On Jellypotato...:
niggling
The "Alex got boomzilla banned from GitHub" thread is
-
I told you guys, he wont let us have fun, and keeps fixing the most funny bugs.
Maybe we should troll about the bugs in some private group where he doesnt see.
-
@fbmac never use this the performance is horrific, because it does a whole ton of hacks in the background.
-
@lucas1 said in On Jellypotato...:
never use this the performance is horrific, because it does a whole ton of hacks in the background.
The "Things our customers say about Discourse" topic is
-
@fbmac said in On Jellypotato...:
I told you guys, he wont let us have fun, and keeps fixing the most funny bugs.
Maybe we should troll about the bugs in some private group where he doesnt see.
When all fixed, start using the
darkley
theme for a fresh set of bugs
-
Alrighty, no-js support has been restored, thanks for noticing!
-
@ben_lubar Seems to be working now :)
-
It seems to break after infiniscrolling kicks in and I just get a lot of blank images (On Chrome and Firefox).
Scroll around in something like the Fox Ideas thread for an example.
-
@Salamander paging helps
I was a fun of infiniscroll when I joined, then Discourse convinced me it sucks
-
Something glitches once per topic where I get sent back the the point of insertion. Not sure if the recent additions of image loading...
Chrome 49.###s
-
@julianlam In the department of niggling bugs...
While scrolling through this thread, I scrolled past https://what.thedailywtf.com/topic/19481/on-jellypotato/63... once I got far enough that it unloaded the post, the screen jellypotatoed downward a little bit, and then when I scrolled back up, the image did not re-appear on the "going up" pass by. Eventually I went to the top of the thread and started scrolling back down, and then the image loaded again.
Reproduces when I keep scrolling to end and beginning of thread.
W10 Chrome 49.0.2623.87
(and 49.0.2623.108 after the About screen updated Chrome for me). A bit more playing is giving problems loading the image in post 63 when I scroll by quickly in either direction, or any speed while going "up" (backwards) the thread.
-
@izzion said in On Jellypotato...:
A bit more playing is giving problems loading the image in post 63 when I scroll by quickly
That's intentional-ish. The image loading only occurs once you finish scrolling, as otherwise you'd spam the DOM with event handler executions.
As for images not loading when scrolling up, that's definitely not intentional
You did mention that unloading causes derps, and I think I know why. When the topic loads, I actually go in and unload the images by replacing it with a blank gif... quite possible there's a race condition there, or my logic derped out a bit. I can't reproduce it right now though, but I'll keep trying.
What are your infinite scroll settings? 20 posts per page?
-
@julianlam said in On Jellypotato...:
@izzion said in On Jellypotato...:
A bit more playing is giving problems loading the image in post 63 when I scroll by quickly
That's intentional-ish. The image loading only occurs once you finish scrolling, as otherwise you'd spam the DOM with event handler executions.
As for images not loading when scrolling up, that's definitely not intentional
You did mention that unloading causes derps, and I think I know why. When the topic loads, I actually go in and unload the images by replacing it with a blank gif... quite possible there's a race condition there, or my logic derped out a bit. I can't reproduce it right now though, but I'll keep trying.
What are your infinite scroll settings? 20 posts per page?
I seem to only be able to get it to happen after I post... Maybe that's it?
-
@sloosecannon Hey look, I repro'd
-
@ben_lubar add82ba6c905ac6f5863708986e6153208d783d7 should make upwards scrolling a tad more fluid, it might also fix the bug @sloosecannon and @izzion are reporting.
Oh god what have I done
It's repro-ception!
-
-
@boomzilla said in On Jellypotato...:
50
Mine too. And they'd be higher if it would let me.
For those of us with infiniscroll turned off, I can see no excuse at all for jellypotato. How it should work is that some div around every post should have an ID attribute and post URLs should include a fragment identifier that references that ID, so locating the correct scroll point becomes the browser's job. Browsers are good at that job. All this hipster whitespace inner-platform bullshit needs to die.
I don't care what you do to people thick enough to think infiniscroll is a good idea.
-
Happened in multiple topics today... I enter at last read, as I scroll down to the end of the page, it jellypotatoes me back up to the entry point.
And just now as I am typing this post it jellypotatoes me to the middle of the page, even though I entered at the bottom.
-
@julianlam said in On Jellypotato...:
Almost fixed guys, just working out a few niggling bugs...
Oh that's ok, just shove it out on forums with known bugs. Why not. Who cares? Don't take any pride in your work, that's obviously the best strategy.
-
This post is deleted!
-
@PleegWat said in On Jellypotato...:
I enter at last read, as I scroll down to the end of the page, it jellypotatoes me back up to the entry point.
Confirmed:
-
@flabdablet said in On Jellypotato...:
For those of us with infiniscroll turned off, I can see no excuse at all for jellypotato. How it should work is that some div around every post should have an ID attribute and post URLs should include a fragment identifier that references that ID, so locating the correct scroll point becomes the browser's job. Browsers are good at that job. All this hipster whitespace inner-platform bullshit needs to die.
Yes. At first I was shocked this wasn't happening, since that's how literally every website works since the id attribute was created.
But then I remembered that we need to break everything a browser does well and implement it half-assed to support infiniscroll
I don't care what you do to people thick enough to think infiniscroll is a good idea.
Plus Won.
-
@flabdablet That's not the bug here. We calculate the distance to the post anchor perfectly.
It's the fact that the position of post anchors changes when images are loaded since they're loaded asynchronously, and take a relatively long time.
So I can send you to the right place, but if that place decides to hop on a plane and reappear 600px downwards, I can't easily accommodate without introducing more jellypotato.
Keep in mind when the page loads I have about 300ms before your expectation of where you ought to be resets.
If I can get you to the right place in time, all is well. Any longer, and if I relocate you, I'll get complaints that there's more jellypotato.
ANY site with many pictures suffers from the same issue.
-
@julianlam Yeah, you see this with static pages too, though less so nowadays as connections are faster. The browser will pop you to the anchor at first render, and it might do so again once all resources have loaded.
-
@PleegWat said in On Jellypotato...:
Happened in multiple topics today... I enter at last read, as I scroll down to the end of the page, it jellypotatoes me back up to the entry point.
Has this always happened, or was it a regression introduced yesterday?
-
@julianlam I didn't start experiencing it till today; didn't happen yesterday (16h ago)
-
@PleegWat Actually, only seems to happen on topics with a lot of unread, and I keep up... so that's probably ~26 hours ago when I had the 'lots of unread in a topic' situation without the bug.
-
@ben_lubar said in On Jellypotato...:
Ok, so we now have a lot less jellypotato.
Are you sure? I can't even scroll to the bottom of this topic, it's jellypotatoing me up constantly.
-
@Onyx I think the
<video>
tags might be doing it.
-
@ben_lubar Hard reload helped. I'll see if I can track down the culprit if it happens again. As a note, the only image below the part I couldn't scroll to was the House one, no videos.