Discouse-ful?
-
So there's a new feature on meta that actually seems to be useful. And not bikeshedding.
Of course there's bikeshedding ABOUT the new feature, but I think this is actually a nice addition. Far more useful than the necro-toast, anyway.
-
That's… actually pretty sweet
-
Ahhhh! No more heatmaps!
-
Maybe they could use those meme time cards (from Spongebob, thanks KnowYourMeme):
-
Unfortunately tests seem to be randomly failing
-
You mean the tests that do nothing to find bugs anyway?
-
I'm kinda confused by an example used to show some styling stuff (though like the clock next to it):
specifically:
-
When a developer says "Tests seem to be randomly failing", that always means "I changed things willy-nilly and broke the tests and don't care to understand why".
Always.
Source: I know this because of my learnings, because I have seen many tests in my day, and also because of the pixels.
-
"Looks too much like a button."
BECAUSE ASSHOLE DESIGNERS HAVE ALL DRANK THE FLAT FUCKING KOOL AID.
-
I'm kinda confused by an example used to show some styling stuff (though like the clock next to it):
I suspect @sam has been using a backup of this place for development so he could get a handle on performance things.
-
Source: I know this because of my learnings, because I have seen many tests in my day, and also because of the pixels.
Yeah and her knees were too pointy. #FarkMemes
-
I suspect @sam has been using a backup of this place for development so he could get a handle on performance things.
Ah, that would make sense.
-
Well.... Actually... That was not how that transpired
Tests were randomly failing cause of some protection we had in posts timing that ensure you can't set read timing on posts that is longer than account age
And clock was a bit slow in the test vm
Anyway it was my regression in the test suite and it was hard to figure out
-
Anybody else reading the title as "Discouse-ful"? It seems my brain doesn't want to link "Discourse" with "useful".
Filed under: Haha, Just kidding, I <3 da ForumpointZZZZ
-
cause of some protection we had in posts timing
So in other words, you changed something ;)
Also it sounds like you're doing it wrong. What kind of tests were they that were failing? If they're meant to be unit testing, you shouldn't be using real objects in the first place. I suggest making liberal use of Sinon.js for mocking, it has a great library for mocking out the clock so you don't get time-based issues.
-
So in other words, you changed something
I certainly did :) expecting the clock to monotonically increase during testing is a bit of a stretch it turns out (clock can be frozen for a few of the steps so stuff like
>=
vs>
can matter .Tests were all server side btw https://github.com/discourse/discourse/commit/5eabf01c292a006f5da126f4334a6c0369df8724
-
Falsehoods programmers believe about time
[...]- One minute on the system clock has exactly the same duration as one minute on any other clock
- Ok, but the duration of one minute on the system clock will be pretty close to the duration of one minute on most other clocks.
- Fine, but the duration of one minute on the system clock would never be more than an hour.
- You can’t be serious.
More falsehoods programmers believe about time; “wisdom of the crowd” edition
[...]- Time always goes forwards.
(Falsehoods users believe about discourse:
- Surely numbers in lists in quotes won't be arbitrarily changed, right?)
-
Continuing the above list...
- The first link in an email notification will be a click through to the actual post (spoiler alert: It's the last one)
Anybody else reading the title as "Discouse-ful"? It seems my brain doesn't want to link "Discourse" with "useful".
Totally didn't notice how close the title was to discourse when I made the topic.
-
Maybe they could use those meme time cards (from Spongebob, thanks KnowYourMeme):
Well, it's not like it's something we can't do...
@font-face { font-family : sponge; src : url(/uploads/default/original/3X/8/e/8e076a5d6aa6f28e8a485f969fb06e63082f7a5e.ttf); } .time-gap .topic-avatar { display : none; } .time-gap-words { display : block; font-family : sponge; font-size : 72px; background-image : url(/uploads/default/original/3X/d/d/dd5fb009afd1f83bc662d69ba3ee43a0278d8663.png); color : #FFFFFF; text-align : center; margin-top : 0; }
-
-
Well, it's not like it's something we can't do...
please?! can we have this? it's awesome!
-
…maybe as a selectable theme…
-
…maybe as a selectable theme…
where's the fun in that?
besides spongebob's an awesome show! totally worth it!
-
besides spongebob's an awesome show! totally worth it!
I wouldn't know; never seen it, never wanted to. Always struck me as being a bit stupid really.
-
Always struck me as being a bit stupid really.
unashamedly so! sometime's that's just the thing you need!
-
-
Dammit Discourse! You're eating the text in the posts again!
-
you do realize, do you not, that's the chromium logo, not the chrome logo....?
-
That's close enough.
Besides, Opera turned into Chromium so the analogy works better.
-
-
Much better than the original!
not a spongebob fan
-
you do realize, do you not, that's the chromium logo, not the chrome logo
No, it's a chromed version of the Chrome logo. Everything's Chrome in the future.
-
@Maciejasjmj said:
Well, it's not like it's something we can't do...
please?! can we have this? it's awesome!
- I'm with @RaceProUK on this: it ain't that great. If you want it that bad, put it in your personal CSS.
- Only admins can modify site CSS settings. I cannot help you here.
-
besides spongebob's an awesome show! totally worth it!
I watched it once. I want those five minutes (I didn't watch much, I'll admit) and the countless neurons back.
-
it ain't that great
It's open source, fix it yourself.
(seriously though, yeah, just plop it into Stylish)
-
I want those five minutes (I didn't watch much, I'll admit) and the countless neurons back
Fun fact: my wife hates the idiom "that's [some length of time] I won't get back", because that's not how time works, dammit.
Listening to her complain about it is a good hour of my life I won't get back
-
because that's not how time works, dammit.
that's only because she doesn't have a tardis.
-
Technically, we did get two hours back flying West across two timezones on the way back from honeymoon, but since we'd already lost those extra two hours flying out and the flight was 4 hours anyway, it didn't make much difference