Signs your code is unmaintainable
-
@Lorne-Kates said in Signs your code is unmaintainable:
Okay, everyone. Look back at the code you wrote 2 years ago. Can you maintain it?
Sure, that's a moderate chunk of my job. Of course, some parts are easier than others, but there's very little now that is too horrible to work with.
-
@Lorne-Kates said in Signs your code is unmaintainable:
Okay, everyone. Look back at the code you wrote 2 years ago. Can you maintain it?
Yes, I can and I am.
-
@Lorne-Kates maintainability means that someone else can maintain it, no?
-
@marczellm That's where maintainability meets sustainability.
-
@marczellm I barely remember code I wrote last week unless I'm working on it regularly. Code I wrote 2 years ago might as well have been written by someone else.
-
@Kian said in Signs your code is unmaintainable:
Code I wrote 2 years ago might as well have been written by someone else.
QFT
-
@Gąska
I'd say it's a pretty obvious euphamism for Taking the Browns to the Super Bowl. Or Dropping the Kids Off at the Pool.
-
@Luhmann said in Signs your code is unmaintainable:
Some people carry both an development and a functional expert tag. Preferably in some really specialized domain ... like bookkeeping.
I can see how this could go wrong (e.g. You have a functional expert writing code that isn't up-to-snuff, or, because in the example you gave, it might make embezzlement easier), but I don't see how this is a sign by itself. If I was hiring someone with equal programming credentials, but one was also a subject-matter expert in part of what we were doing, I would hire the latter.
-
@lucas1 said in Signs your code is unmaintainable:
@Groaner Used to work with his guy who couldn't understand why a customer's DBA wouldn't give him alter table permissions to a running application.
Though if you add an unreasonable or inaccessible DBA to that policy, I can see how it could be a WTF.
-
@lucas1 said in Signs your code is unmaintainable:
@abarker said in Signs your code is unmaintainable:
@accalia The deleting~~fixing~~ is fun.
I deleted in one sprint (when left alone):
- 25 C-Sharp projects
- 30 gigs of un-used code
- Fixed the deployment build scripts
- Removed 30 implementations of opening a popup window in JavaScript
This was all achieved with the delete key and ctrl + v. Greatest 2 working weeks of my entire life. A pull down from TFS used to take 30 minutes, now took 2. The best thing is that it passed a full manual regression test, a full automated test and deployed into production with one click.
I'm glad that you could confidently figure out what was dead code and what wasn't. Some places it's not so easy.
-
@AgentDenton said in Signs your code is unmaintainable:
- Saying "That's how we do it here"
^^ is NOT the way you explain things if you expect your resources to learn and build initiative.
Meh. I sometimes prefer an honest "that's how we do it here" rather than an explanation when the way I want to do is actually better.
- Saying "That's how we do it here"
-
@Tsaukpaetra said in Signs your code is unmaintainable:
@asdf said in Signs your code is unmaintainable:
@Tsaukpaetra said in Signs your code is unmaintainable:
Lets be honest here.
Nope. Simply no. This is one of those software engineering rules which are correct in most cases, but simply wrong in others. I
I'm not sure why you're replying to me.
I assumed he was opposed to honesty.
-
@Jaloopa said in Signs your code is unmaintainable:
@masonwheeler IIRC, they quickly moved to forklifts and heavy weights, by the end they were flattening it with a steamroller
How/where did they get a sheet of paper that size to begin with? Sure, the length you could get by unrolling a big roll, but what about the width? Wouldn't you need a press the width of a football field?
-
@Lorne-Kates said in Signs your code is unmaintainable:
Okay, everyone. Look back at the code you wrote 2 years ago. Can you maintain it?
Let's see... apparently I was working on the (we don't really use it really) timeclock...
Well, it's still working, though I will eventually maintain it to reduce this ridiculous "Thinking..." modal that pops when clicking any button inside it, so
Also, it appears that the original Master Server Client was also made (in one months time minus two years). That code is indeed being maintained, and is slated for porting to Linux Soon™!
Mmmm, so much goodness I've done...
-
-
@pie_flavor said in Signs your code is unmaintainable:
@Tsaukpaetra said in Signs your code is unmaintainable:
Perhaps you're better off not knowing what went on...
-
@Tsaukpaetra Is that Perforce?
-
-
@tharpa said in Signs your code is unmaintainable:
I don't see how this is a sign by itself.
It isn't… but people with double expertise are rare and expensive to hire and retain.
-
@Tsaukpaetra You were committing “temporary generated file”s? I think that's a pretty good clue that the code is in a bad way…
-
@dkf said in Signs your code is unmaintainable:
@Tsaukpaetra You were committing “temporary generated file”s? I think that's a pretty good clue that the code is in a bad way…
No, I was committing erasures of the same, because the .p4ignore file didn't exist and so when people went to "reconcile offline files" they just shrugged and added them on.
-
@Tsaukpaetra said in Signs your code is unmaintainable:
Well, it's still working, though I will eventually maintain it to reduce this ridiculous "Thinking..." modal that pops when clicking any button inside it, so
Replace it with a spinning emoji
-
-
@Gąska
Smooth!