Stupid fucking mobile menu is broken on Chrome 65
-
inb4 people lose their minds.
Chrome 65 introduced a bug which results in certain static function being wrong so it broke the slideout library. Luckily we caught it quickly and I've released an updated version to bypass the issue.
Chromium issue: https://bugs.chromium.org/p/v8/issues/detail?id=7545
@ben_lubar update your theme to use pulling@1.1.2
-
I thought I was losing my mind...
-
@bb36e Oh don't worry, you are! This just doesn't happen to be a sign. :D
-
Ah. Well on my particular mobile, the top menues are still broken completely anyways, so I didn't even notice...
-
I just don't notice the brokenness anymore.
-
@pitaj said in Stupid fucking mobile menu is broken on Chrome 65:
@ben_lubar update your theme
I... don't have a theme.
-
@ben_lubar said in Stupid fucking mobile menu is broken on Chrome 65:
@pitaj said in Stupid fucking mobile menu is broken on Chrome 65:
@ben_lubar update your theme
I... don't have a theme.
You do! But you don't usually follow it....
-
@pie_flavor said in Stupid fucking mobile menu is broken on Chrome 65:
I just don't notice the brokenness anymore.
Wait, now I notice it. God dammit, why'd I have to reload?
-
If you delete node modules and reinstall, it should install the latest version automatically. It might also be possible to do it without doing that, but I haven't been able to make it work yet. You could try something like
cd node_modules/nodebb-theme-persona npm install pulling@latest --no-save
-
@bb36e said in Stupid fucking mobile menu is broken on Chrome 65:
I thought I was losing my mind...
I had just finally moved a bunch of CSS from my userscript (only runs on desktop) to the custom CSS section of my profile (runs everywhere, including on mobile), and so I thought maybe that had broken it. Hadn't bothered to dig into it just yet to figure out what was broken...
-
I was wondering when someone was going to report that.
-
@polygeekery said in Stupid fucking mobile menu is broken on Chrome 65:
I was wondering when someone was going to report that.
I thought it was just me, because another, different, site broke around the same time, and I was blaming Chrome itself...
-
Oh sure complain about a bug that only affects your special snowflake browser version, and force the admins to fix it for you. Asshole.
-
@pitaj said in Stupid fucking mobile menu is broken on Chrome 65:
If you delete node modules and reinstall, it should install the latest version automatically. It might also be possible to do it without doing that, but I haven't been able to make it work yet. You could try something like
cd node_modules/nodebb-theme-persona npm install pulling@latest --no-saveWhy --no-save? Wouldn't that break immediately on the next restart when it runs
./nodebb updateagain?
-
@ben_lubar it would break even without no-save, this way it doesn't alter package.json for the theme (which doesn't really matter).
Anyways, the next time you run
./nodebb upgradeit should install the latest compatible version (so the fixed one).
-
Menu is still broken on mobile chrome.
Don't reply to this message, I won't be able to see the notification anyway.
-
@cartman82 Fuck you, I'll do whatever I want!
-
@cartman82 said in Stupid fucking mobile menu is broken on Chrome 65:
Menu is still broken on mobile chrome.
Don't reply to this message, I won't be able to see the notification anyway.
You too?
I am comforted others share in my sorrows...
-
@cartman82 said in Stupid fucking mobile menu is broken on Chrome 65:
Menu is still broken on mobile chrome.
Don't reply to this message, I won't be able to see the notification anyway.
Whoops, I did the
npm installcommand yesterday but forgot to click the rebuild button.
-
@ben_lubar Not
sudo npm update -g?
-
@greybeard said in Stupid fucking mobile menu is broken on Chrome 65:
@ben_lubar Not
sudo npm update -g?
It looks like you're trying to run rm -rf / --no-preserve-root. Would you like help with that?
-
@ben_lubar said in Stupid fucking mobile menu is broken on Chrome 65:
click the rebuild button.
Whatever you did, it fixed the fuckery going on with my phone, so thanks on accident @PitaJ
-
-
@julianlam said in Stupid fucking mobile menu is broken on Chrome 65:
It's a good thing they have Beta and Canary builds to catch this sort of thing before it gets out to the public, right? RIGHT?!! ???!!1!1
-
@tsaukpaetra it was even caught in the Canary, and still made it to the release.
-
-
@jaloopa can confirm.
-
@jaloopa seems to work fine for me
-
@cartman82 have you refreshed? Swiping and tapping the button both do nothing (Well, tapping the button highlights it) and it started as soon as I saw the "nodeBB had updated, pls refresh" toaster
@blubar, did you forget to add the patch on the latest update?
-
@jaloopa said in Stupid fucking mobile menu is broken on Chrome 65:
@cartman82 have you refreshed? Swiping and tapping the button both do nothing (Well, tapping the button highlights it) and it started as soon as I saw the "nodeBB had updated, pls refresh" toaster
Just a sec, let me take another shit.
-
-
@cartman82 yup, broken after refresh.
-
@cartman82 said in Stupid fucking mobile menu is broken on Chrome 65:
Just a sec, let me take another shit.
@cartman82 said in Stupid fucking mobile menu is broken on Chrome 65:
@cartman82 yup, broken after refresh.
that's a euphemism I'd not heard before
-
@jaloopa said in Stupid fucking mobile menu is broken on Chrome 65:
@blubar, did you forget to add the patch on the latest update?
oops
-
@ben_lubar working again. Thanks!
