Discussion of NodeBB Updates
-
@ben_lubar said in Discussion of NodeBB Updates:
The SockBot code I linked looks at the field that that server-side code is modifying:
indeed it does, the start of it.
@ben_lubar said in Discussion of NodeBB Updates:
However, the SockBot code only looks at the start and the server-side code only modifies the end, so we should be okay.
exactly.
-
@ben_lubar said in Discussion of NodeBB Updates:
However, the SockBot code only looks at the start and the server-side code only modifies the end, so we should be okay.
OK. But if it breaks, and people come to us, we'll be sending them to you.
Also, next time, can we have more than half an hour's notice about potentially breaking changes? Right now, Yami's unavailable, Accalia's too busy, and I haven't touched core code in over a year, so if any fixes are needed, it's not a quick turnaround. It'd be less of an issue if there wasn't a Mafia game on, but since there is, care needs to be taken not to interfere.
-
@RaceProUK said in Discussion of NodeBB Updates:
Also, next time, can we have more than half an hour's notice about potentially breaking changes?
I object. We need bugs to entertain us.
-
@wharrgarbl said in Discussion of NodeBB Updates:
We need bugs to entertain us.
Two things:
- If you were playing Mafia, and the game was broken by an update, would you be happy?
- Do you really want me to break the topic list again? :P
-
Aaaaaaaaaaaaaaaand I was logged out. First time it happened to me.
-
@CreatedToDislikeThis As was I.
-
@CreatedToDislikeThis said in Discussion of NodeBB Updates:
I was logged out
I was logged out twice.
-
@CreatedToDislikeThis Same here. At the same time the posts got all stretched out horizontally.
And now, this:
-
@CreatedToDislikeThis I have it happen pretty regularly on a laptop that I do not use that often.
That laptop does not have the same issue with anything else, including Discourse forums that I belong to.
-
@Zecc Try a hard refresh?
-
@RaceProUK said in Discussion of NodeBB Updates:
If you were playing Mafia, and the game was broken by an update, would you be happy?
Depends on how broken it gets. I wouldn't risk ruining a running game, but something weird happening to it's skin could be fun.
-
@RaceProUK Why would a hard refresh solve a stylesheet problem that started after the update?
-
@CreatedToDislikeThis said in Discussion of NodeBB Updates:
I was logged out.
I thought the powers that be decided to cut my number of accounts again.
-
@Zecc said in Discussion of NodeBB Updates:
@RaceProUK Why would a hard refresh solve a stylesheet problem that started after the update?
Because it'll clear the old stylesheets from the cache and load them fresh.
-
@RaceProUK You mean the old stylesheets where the problem didn't exist?
I suppose there's been a change in the DOM of the notifications menu?
-
@Zecc said in Discussion of NodeBB Updates:
@RaceProUK You mean the old stylesheets where the problem didn't exist?
I suppose there's been a change in the DOM of the notifications menu?
Dark themes have a darker notification highlight color now.
-
The new candy-striped background in the Lounge topic list might be annoying... I haven't decided yet.
-
@ben_lubar Sigh. Yes.
Hence my complaint. I'd be okay with the highlight being darker if the text of highlighted items were lighter. Or darker. As long as it's more contrasting.
-
@ben_lubar
Congratulations, the custom emojis are broken.We apply the theory of pre-release testing here...
-
@izzion said in Discussion of NodeBB Updates:
Congratulations, the custom emojis are broken.
-
@izzion said in Discussion of NodeBB Updates:
Congratulations, the
customdefault emojis are broken.The custom ones are fine e.g.
-
@RaceProUK
Yeah, reading the other bugs thread is to stampeding over here to express my
-
It didn't break my custom css too bad, so far I've only had to add
!important
to my unread notification background.
-
...
Yo dawg.
-
@Tsaukpaetra
You really should cut off your alcohol consumption subroutine before it makes you barf all over your browser...
-
@Tsaukpaetra That's why I had to fix it
Also, that "did you mean to post a screenshot of the lounge?" popup is horribly annoying.
-
@izzion said in Discussion of NodeBB Updates:
all over your browser...
The vomit has been contained, worry not.
-
@Tsaukpaetra said in Discussion of NodeBB Updates:
The vomit has been contained
Inside your notification list, from the look of it
-
@hungrier said in Discussion of NodeBB Updates:
Also, that "did you mean to post a screenshot of the lounge?" popup is horribly annoying.
It's supposed to be. It shouldn't appear if you post a screenshot of lounge content inside the lounge.
-
@anotherusername said in Discussion of NodeBB Updates:
@hungrier said in Discussion of NodeBB Updates:
Also, that "did you mean to post a screenshot of the lounge?" popup is horribly annoying.
It's supposed to be. It shouldn't appear if you post a screenshot of lounge content inside the lounge.
Unless my code broke after I tested it, that's what it does.
-
@anotherusername It appeared when I posted that screenshot of my notifications. I couldn't tell whytf it was going off but then I realized that the bottom cut-off notification is from a Lounge topic.
-
@hungrier said in Discussion of NodeBB Updates:
@Tsaukpaetra said in Discussion of NodeBB Updates:
The vomit has been contained
Inside your notification list, from the look of it
Yeah I ate the wrong thing apparently. At least @Tsaukpaetra had the courtesy to censor me vomiting.
-
@ben_lubar said in Discussion of NodeBB Updates:
@anotherusername said in Discussion of NodeBB Updates:
@hungrier said in Discussion of NodeBB Updates:
Also, that "did you mean to post a screenshot of the lounge?" popup is horribly annoying.
It's supposed to be. It shouldn't appear if you post a screenshot of lounge content inside the lounge.
Unless my code broke after I tested it, that's what it does.
Yes. Yes I did intend to post this screenshot of The Lounge.
Clever.
-
Tried to copy/paste some lounge screenshots and no warning came up? Am I doing it wrong?
-
@CreatedToDislikeThis it triggers on the candy-striped background parts. So, notifications or topic list.
-
!WARNING!HACKER ALERT!WARNING!HACKER ALERT!WARNING!
-
Ah nice, it indeed works on the topic list. (Do people actually see these 'candy-striped' background parts with the naked eye? I don't. Is it worse in some theme?
-
@CreatedToDislikeThis Yes. I have good eyesight.
-
@CreatedToDislikeThis said in Discussion of NodeBB Updates:
(Do people actually see these 'candy-striped' background parts? I don't. Is it theme-specific
It's hard to see with the naked eye, but you can see the pattern if you zoom in.
This is also separate from zebra-tables, which I have as part of my custom CSS.
-
The candy stripes aren't applied to posts in the lounge, so arguably the most potentially doxxy screenshots don't get the alert.
-
@hungrier
Maybe we're testing (in production) before it's put into production for the Lounge threds?
-
@izzion nah, the stenography was just too difficult to add there. As it currently goes, only solid colored backgrounds can be used, and the Lounge has that background image.
-
@hungrier said in Discussion of NodeBB Updates:
The candy stripes aren't applied to posts in the lounge, so arguably the most potentially doxxy screenshots don't get the alert.
If you screenshot a topic in the lounge there is less chance you're not aware it's not public, as compared to your notifications or mixed-category topic list.
-
@anotherusername said in Discussion of NodeBB Updates:
@izzion nah, the stenography was just too difficult to add there. As it currently goes, only solid colored backgrounds can be used, and the Lounge has that background image.
First of all, steganography.
Second, I thought about making it modify the lounge background, but it gets really complicated when you have to deal with resizing and scrolling. Plus, losing 2 of the 8 bits for each color channel is a bit more noticeable when it's an actual image as opposed to a solid color.
-
@ben_lubar pff. Yeah I can't spell that word.
The fact that the background image gets stretched pretty much ruins any expectation of embedding information in that. I tried adding a pattern on top of it, and that seemed to work decently well, but you'd have to change up your encoding/decoding scheme. And I was only embedding 1 bit per pixel, as opposed to 6.
Also, do you like my sig? It should work on any solid background color... (but not in the Lounge).
-
@anotherusername said in Discussion of NodeBB Updates:
Also, do you like my sig?
So what you're saying is, every category is now owned by Mafia?
-
@anotherusername said in Discussion of NodeBB Updates:
Also, do you like my sig?
Wait, since when are images allowed in signatures?
-
@ben_lubar Since when aren't they?
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar Since when aren't they?
It was like... The first thing I tested when we migrated.
-
An impressive pair of toasters plus dialog box when the update went out. Pity I didn't have the bandwidth to look up how to screenshot on an iPad.
I hope those login session invalidations are truly necessary—they are a right pain. It brought my morning "browse forum while getting kid ready for daycare" to an abrupt halt.