Discussion of NodeBB Updates
-
@izzion said in Discussion of NodeBB Updates:
a button in the editor that puts in the spoiler tag syntax for you.
Pretty sure @NedFodder had that made but removed it for some reason I can't remember.
-
@ben_lubar said in Discussion of NodeBB Updates:
Pretty sure @NedFodder had that made but removed it for some reason I can't remember.
Discussion topic here:
https://what.thedailywtf.com/topic/19577/composer-buttons-plugin
-
@ben_lubar said in Discussion of NodeBB Updates:
some reason I can't remember.
<details><summary>
didn't work for everyone at the time, and I wanted to use the old[spoiler]
syntax so that the old Discourse posts work again.If the consensus is that we want a button for
<details><summary>
, I can easily add that.
-
@NedFodder Someone needs to go back and re-spoiler old posts, then, like my Firewatch post.
-
Well, from where I sit, given that [spoiler]doesn't work[/spoiler] at this point, I would rather see some improvement via a button to put the details / summary tags in.
And then if some additional work can result in converting the old [spoiler] posts to the HTML tag method (or [spoiler] support gets added and the button gets modified), that would be a really valuable future improvement.
-
@NedFodder said in Discussion of NodeBB Updates:
and I wanted to use the old [spoiler] syntax so that the old Discourse posts work again
As long as you filter the post contents before htmlcleaner runs (priority 3 or below), you should be able to just do a string replace.
-
@NedFodder said in Discussion of NodeBB Updates:
I wanted to use the old [spoiler] syntax so that the old Discourse posts work again.
Was there a particular reason why it got abandoned?
edit: the plugin to make [spoiler] work, not Discourse.
-
@anotherusername said in Discussion of NodeBB Updates:
Was there a particular reason why it got abandoned?
Goddamnit. Read the fucking thread I posted.
-
@ben_lubar said in Discussion of NodeBB Updates:
@Mikael_Svahnberg What browser?
Blakeyrant: does it matter? It worked, now it doesn't.
IOS/Safari.
-
@Mikael_Svahnberg said in Discussion of NodeBB Updates:
Blakeyrant: does it matter? It worked, now it doesn't.
Accalialogic: yes, it does actually, for the purposes of reproducing the error one sometimes needs to know the specific hardware and software setup the issue was encountered on. this is especially true when the developer cannot reproduce the issue in their own preferred hardware/software setup.
now that @ben_lubar knows the hardware/software setuo that created the issue, it's up to him to follow through with things and fix the issue, or accalialogic will turn into accaliarage.
-
@Mikael_Svahnberg said in Discussion of NodeBB Updates:
IOS/Safari.
Hmm, I can't reproduce on my mom's iPad (generation 2, GSM model). :/
-
@ben_lubar it's better now, but the icons are still squeesed together...
-
@Mikael_Svahnberg Are you in default responsive mode or unresponsive desktop mode?
-
@boomzilla desktop mode, it seems.
It also seems like the icons huddle up more for every time I go back a page?
-
-
-
-
-
-
@TDWTF-NodeBB-Development should I install this update? It'd mean a minute or so of downtime.
-
@ben_lubar "Support for UTF-8 in Dockerfiles" so you can put zalgo in your Dockerfile alone is a reason to do it.
-
@ben_lubar said in Discussion of NodeBB Updates:
@TDWTF-NodeBB-Development should I install this update? It'd mean a minute or so of downtime.
do we expect it to improve matters?
have we tested the update in staging so we know it won't break prod just by the install?
do we have a rollback plan?
if you answered no to any of those questions then that's your answer. if you answered yes to all then what are you waiting for?
-
@accalia said in Discussion of NodeBB Updates:
if you answered yes to all then what are you waiting for?
Approval from the vocalists.
-
@accalia said in Discussion of NodeBB Updates:
do we expect it to improve matters?
It probably won't do anything.
@accalia said in Discussion of NodeBB Updates:
have we tested the update in staging so we know it won't break prod just by the install?
Yes
@accalia said in Discussion of NodeBB Updates:
do we have a rollback plan?
Yes
-
@ben_lubar said in Discussion of NodeBB Updates:
@accalia said in Discussion of NodeBB Updates:
do we expect it to improve matters?
It probably won't do anything.
@accalia said in Discussion of NodeBB Updates:
have we tested the update in staging so we know it won't break prod just by the install?
Yes
@accalia said in Discussion of NodeBB Updates:
do we have a rollback plan?
Yes
eeeh. then -shrug-
you have tested and it doesn't make things broken in staging, you have a rollback plan....
either let it be and do it in a monthly patch window, or if you're gung ho about it shcedule an outage window and do it.
-
Has anyone even changed their avatar since the update that made avatar changing easier?
-
@ben_lubar I changed mine from Gravitar earlier today, does that count?
-
@ben_lubar said in Discussion of NodeBB Updates:
Has anyone even changed their avatar since the update that made avatar changing easier?
@accalia and @abarker have both changed avatars fairly recently...
-
@dkf said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
Has anyone even changed their avatar since the update that made avatar changing easier?
@accalia and @abarker have both changed avatars fairly recently...
That's what prompted the update.
-
@dkf said in Discussion of NodeBB Updates:
@accalia and @abarker have both changed avatars fairly recently...
Does new user change from default count? (@player)
-
@ben_lubar said in Discussion of NodeBB Updates:
@TDWTF-NodeBB-Development should I install this update? It'd mean a minute or so of downtime.
Ok so last night the forum went down for like 10 minutes with a bunch of error messages about hostnames not resolving.
dig
on the host andping
in the container could both resolve those hostnames correctly (the hostnames were for the iframely and youtube-embed plugins).I installed the docker-engine update while I was restarting it.
-
@all_users said in Discussion of NodeBB Updates:
@dkf said in Discussion of NodeBB Updates:
@accalia and @abarker have both changed avatars fairly recently...
Does new user change from default count? (@player)
No linkification and no notification from that?
-
@player said in Discussion of NodeBB Updates:
@all_users said in Discussion of NodeBB Updates:
@dkf said in Discussion of NodeBB Updates:
@accalia and @abarker have both changed avatars fairly recently...
Does new user change from default count? (@player)
No linkification and no notification from that?
"@mentions" with punctuation on the left are notoriously broken.
-
@ben_lubar said in Discussion of NodeBB Updates:
"@mentions" with punctuation on the left are notoriously broken.
They require some sort of leading whitespace@ben_lubar (or, for the s, be the first thing in a post), not just no punctuation @ben_lubar.
-
@ben_lubar said in Discussion of NodeBB Updates:
Has anyone even changed their avatar since the update that made avatar changing easier?
o/
do you like it? it's for the start of new mafia game
which by the way.... when is?
-
@ben_lubar said in Discussion of NodeBB Updates:
@player said in Discussion of NodeBB Updates:
@all_users said in Discussion of NodeBB Updates:
@dkf said in Discussion of NodeBB Updates:
@accalia and @abarker have both changed avatars fairly recently...
Does new user change from default count? (@player)
No linkification and no notification from that?
"@mentions" with punctuation on the left are notoriously broken.
Hello?
-
@mentions said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@player said in Discussion of NodeBB Updates:
@all_users said in Discussion of NodeBB Updates:
@dkf said in Discussion of NodeBB Updates:
@accalia and @abarker have both changed avatars fairly recently...
Does new user change from default count? (@player)
No linkification and no notification from that?
"@mentions" with punctuation on the left are notoriously broken.
Hello?
Welcome back !
-
(oops)
Note to @administrators: Until this bug is fixed, don't leave the admin panel open while you're not interacting with it.
This is a pretty dumb "feature" in the first place - it provides a minor annoyance to administrators (I need to open my password manager and manually copy and paste the password like an animal - see Chrome bug 627333) and provides security only under a very specific set of conditions:
- My computer must be stolen, unlocked, while I am logged into the forum as an administrator.
- The attacker must not know that I have the password saved in my browser even though the password field lights up and the password manager icon appears in the top right.
- The attacker must be interested in changing post timeouts or (more likely) installing plugins.
- The attacker must not be interested in altering or deleting posts, topics, or users, because all of those things can be done without accessing the admin panel.
- The attacker must not have an account of their own, because adding a user to the administrators group does not require re-authenticating.
If any of those conditions is not met, this "feature" provides no security.</rant>
-
This is a pretty dumb "feature" in the first place
Maybe we should allow it to be disabled?
How do you all feel about removing skin support from core... I want to move it to a plugin, and have it added to the CSS via the LESS file, so we need fewer hacky workarounds, but the downside is you wouldn't get user-selectable skins anymore, just admin-selected site-wide skin...
-
@julianlam said in Discussion of NodeBB Updates:
but the downside is you wouldn't get user-selectable skins anymore, just admin-selected site-wide skin...
Removing features people actively use? That won't go down too well I think.
Is there no other way it can be handled?
-
@PJH Not without incurring significant additional server-side load...
Bootswatch currently appends CSS to the page. This works pretty well, and allows users to select their own skin for use on the site. However, you run into issues where Bootswatch expected a certain background, but it isn't set, or is set differently (e.g. all those white text on white background things you see sometimes).
This happens in every place we use bootstrap variables in our styles. When we do so, LESS takes the value of that variable from Bootstrap proper, even though Bootswatch expects it to be a different value (based on its own variables). However, being a client-side loaded stylesheet, it can't modify these variables as they are processed on the server on startup during the LESS compilation phase. Hence there is a conflict.
If we loaded bootswatch on the server side (e.g. "admin selects 'Yeti', that LESS file gets precompiled into NodeBB stylesheet"), then the proper variables get overwritten and everything looks good (in theory)...
If we wanted to extend this to the client side, then we would need to run the LESS pre-compilation for every single Bootswatch skin, and serve the proper one based on user skin selection (yikes).
-
@julianlam said in Discussion of NodeBB Updates:
, then we would need to run the LESS pre-compilation for every single Bootswatch skin, and serve the proper one based on user skin selection (yikes).
presumably though you would only have to do that once, write them out to physical files and let nginx serve them?
it's some additional load yeah, but it should amortize pretty well....
unless of course the forum is having servercooties fifty times per day..... that would be a different story i guess.
-
@julianlam said in Discussion of NodeBB Updates:
Bootswatch currently appends CSS to the page
That's a pretty generous way of looking at it. Bootswatch is a CDN. That's it. You can maintain the files yourself and add corrections to them to account for custom classes and whatnot when you do custom things. You can have them be compiled from LESS on your side and request them from the same server you get your DOM from and you have no conflicts. What's the big deal?
As I've offered before, I'll happily PR my Stylish changes for the skin I use back into your core product if you do so.
-
@Yamikuronue said in Discussion of NodeBB Updates:
That's a pretty generous way of looking at it. Bootswatch is a CDN. That's it. You can maintain the files yourself and add corrections to them to account for custom classes and whatnot when you do custom things.... What's the big deal?
That would work, except we'd then be effectively forking our "version" of Bootswatch. The more the they diverge, the more difficult it will be to merge, and I would rather opt to avoid merge conflict resolution if at all possible.
-
@julianlam Sure, but right now Bootswatch can make breaking changes to your application's skins anytime they like and you have 0 influence or control over that. So it's not totally cut-and-dried here :)
-
Yes, that is true, and it has happened, but that was sort of our fault, as we were calling their
latest
API endpoint, instead of a versioned one.Theoretically, if Bootswatch doesn't backport breaking changes, we should be ok
-
@julianlam said in Discussion of NodeBB Updates:
as we were calling their latest API endpoint, instead of a versioned one.
So why don't you rehost again?
If you're just trying to avoid merge conflicts, I'd say compile the things with LESS or some such, putting your changes in a separate file and including their file as a base. No merging required. They even recommend that themselves:
Changes are contained in just two LESS or SASS files, enabling modification and ensuring forward compatibility.
I think it's pretty clear that this, coupled with Accalia's suggestion of only compiling at server start, is the way to go here. You get the benefit of easy skins, the ability to add more, and the ability to customize them, at the price of a few extra milliseconds of startup time and the bandwidth to download the CSS from the same source as the JS
-
15min and we'll have new things to rant about :-)
-
@groo Join us in IRC for an early ranting party!
-
add ban/unban button to the account info page
this one?
Can I ban myself? Find out next post, same bat time, same bat channel
Edit:
No, so that's sane at least. But why the fuck can I see it? My guess is that the testing didn't involve logging in as a non admin user, because the developers are all admins