Discussion of NodeBB Updates
-
@anotherusername said in Discussion of NodeBB Updates:
@pie_flavor I can open the upvotes/downvotes box on my post. You probably just hit one of the vote buttons by mistake. It's hard AF to hit the number on mobile without hitting one or the other vote button instead.
Yes, that's the point. It used to be that if you hit a vote button on your own post it would do the same thing as hitting the vote number on any post. Now it just gives that notification.
As you said, it's hard to hit the number without hitting a button. Thus, this was made more difficult for no reason.
-
@pie_flavor said in Discussion of NodeBB Updates:
It used to be that if you hit a vote button on your own post it would do the same thing as hitting the vote number on any post.
Not IME.
-
@anotherusername said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
It used to be that if you hit a vote button on your own post it would do the same thing as hitting the vote number on any post.
Not IME.
It did IME.
-
@anotherusername You probably just never tried it. I swear it used to work.
-
@anotherusername said in Discussion of NodeBB Updates:
@pie_flavor I can open the upvotes/downvotes box on my post. You probably just hit one of the vote buttons by mistake. It's hard AF to hit the number on mobile without hitting one or the other vote button instead.
Yeah, that should be disabled on mobile. Or at least limit it to one dialog box so you don't get them all over the screen when you are trying to see who voted on something.
-
@polygeekery said in Discussion of NodeBB Updates:
@anotherusername said in Discussion of NodeBB Updates:
@pie_flavor I can open the upvotes/downvotes box on my post. You probably just hit one of the vote buttons by mistake. It's hard AF to hit the number on mobile without hitting one or the other vote button instead.
Yeah, that should be disabled on mobile. Or at least limit it to one dialog box so you don't get them all over the screen when you are trying to see who voted on something.
Why not disabled everywhere? What in the fuck could possibly be the reasoning behind removing a functionality of a button and replacing it with an error message saying you're not supposed to click that button?
-
@pie_flavor said in Discussion of NodeBB Updates:
Why not disabled everywhere?
Occasionally one of @obeselymorbid's 5th or 10th upvotes on a post will lead me in to a thread from months ago. I will read through and find a really witty post that I didn't upvote before. I click or tap on it a few times and nothing happens. I curse NodeBB and its websocket shittiness and then realize I was trying to upvote my own post. (I drink a lot and also suffer from CRS)
So for those edge cases I find that notification helpful. People who don't drink as much as I do and who are not as goddamn witty as I am may not find it as helpful.
-
@Polygeekery Uh, it doesn't just do nothing. It opens the upvote record dialog. That's how you know you're upvoting your own post.
-
@pie_flavor said in Discussion of NodeBB Updates:
@Polygeekery Uh, it doesn't just do nothing. It opens the upvote record dialog. That's how you know you're upvoting your own post.
Yes it did, no it didn't, no you didn't.
-
@polygeekery said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
@Polygeekery Uh, it doesn't just do nothing. It opens the upvote record dialog. That's how you know you're upvoting your own post.
Yes it did, no it didn't, no you didn't.
You must be .png. Because (like is said in the beginning of this reply train) before the update, if you clicked a vote button on your own post, it would bring up the vote record dialog, the same as if you clicked the number. They have now removed the functionality from buttons and replaced it with text telling you not to click the button.
If clicking the button always produces an error, then the fuck is the point of the buttons still even being there?
-
@pie_flavor said in Discussion of NodeBB Updates:
Because (like is said in the beginning of this reply train) before the update, if you clicked a vote button on your own post, it would bring up the vote record dialog
No it didn't.
-
@polygeekery Yeah, I don't recall this ever happening either... Of course, it is possible I've never managed to try to upvote one of my own posts before. Somehow.
-
@polygeekery said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
Because (like is said in the beginning of this reply train) before the update, if you clicked a vote button on your own post, it would bring up the vote record dialog
No it didn't.
Yes, it did. I've done it many times, and @Tsaukpaetra confirmed it.
-
@pie_flavor said in Discussion of NodeBB Updates:
@polygeekery said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
Because (like is said in the beginning of this reply train) before the update, if you clicked a vote button on your own post, it would bring up the vote record dialog
No it didn't.
Yes, it did. I've done it many times, and @Tsaukpaetra confirmed it.
Granted, the update before the update before this past one it didn't, because there was no upvote dialog pop-up thing. Instead, it just put the little hover thing over the number, so it's possible nobody noticed it happening.
-
@pie_flavor said in Discussion of NodeBB Updates:
It didn't use to do this. It used to just open the upvotes/downvotes record box.It does that if you click on the vote button instead of the numbers. It has done that for as long as I can remember. I had to tweak my like bookmarklet to not trigger that.
-
@boomzilla said in Discussion of NodeBB Updates:
@pie_flavor said in Discussion of NodeBB Updates:
It didn't use to do this. It used to just open the upvotes/downvotes record box.It does that if you click on the vote button instead of the numbers. It has done that for as long as I can remember. I had to tweak my like bookmarklet to not trigger that.
You are also a kid since we pony as I remember.
Goddam, Lemme try again: you are also a mod since as long as I remember.
-
@boomzilla said in Discussion of NodeBB Updates:
It has done that for as long as I can remember.
October '17:
The code surrounding it goes back to July '15.
-
-
@pie_flavor said in Discussion of NodeBB Updates:
Yeah, really no idea what went wrong with the ranking this update....
-
@pie_flavor Even better:
This ain't random. It's the same sequence every time.
Just what in the everloving fuck kind of algorithm would produce this?
:t
- is the first result. Unlike the rest of the results, this does not contain a 't'.
:tr
- , .png, these are expected. Rather than other things which start with 'tr', though, we then move to and the various skin colors of .
:tro
- .png is normal. But then we get , , . These are listed before , despite not actually starting with 'tro'.
:trol
- Hey, is at the top now. Yay. Followed by .png, the rest of the trains, and... ? Eh, who cares.
:troll
- Hang on, a second 'l' and now .png is back on top. ? Followed by the usual suspects, nothing to see there. .gif has made a surprise appearance, though.
:trolle
- Oh look, , , and are back above . God knows why. And now is above .gif, even though it was below before, despite being just as good a match to the pattern.
:trolley
- Now we've got back on top! Yay! With making a surprise appearance, despite being pretty damn far off the mark.
:trolleyb
- and is now back below the trains, fuck knows why, with holding on for dear life.
:trolleybu
- No more extraneous things, just the trains and . is still below the trains.
:trolleybus
- Amazingly, the trains are still above . But, out of fucking nowhere, .gif is back.
-
This is amazing.
-
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
-
@julianlam said in Discussion of NodeBB Updates:
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
Why would
rolleyes.gif
be a good match for:trolleybus
, even if that is the case?
-
@ben_lubar said in Discussion of NodeBB Updates:
@julianlam said in Discussion of NodeBB Updates:
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
Why would
rolleyes.gif
be a good match for:trolleybus
, even if that is the case?rolleyes trolleybus
Probably because
rolley
matches betwixt them?
-
@ben_lubar
rolley
andtrolley
share a lot of characters
-
@tsaukpaetra said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@julianlam said in Discussion of NodeBB Updates:
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
Why would
rolleyes.gif
be a good match for:trolleybus
, even if that is the case?rolleyes trolleybus
Probably because
rolley
matches betwixt them?Why did someone add a Levenshtein distance to an algorithm that picks from a list of tiny pieces of text and then throw out the rest of the algorithm?
-
Request: Can we put back the generic
emoji
class on all emojis?
-
@ben_lubar Fuse.js is the fuzzy search library that is used in the emoji plugin. It's the best one I could find.
I plan on decreasing the weights for aliases and keywords (https://github.com/NodeBB/nodebb-plugin-emoji/issues/7)
@hungrier I've also added an issue for adding a generic class to all emoji. In the meantime, you should be able to use the following selector instead:
[class*="emoji-"]
(https://github.com/NodeBB/nodebb-plugin-emoji/issues/8)
-
@pitaj Welcome to the forums!
-
Be nice, we're paying him in bits of string.
-
@julianlam said in Discussion of NodeBB Updates:
Be nice, we're paying him in bits of string.
Mmmmm.... strings....
-
@pie_flavor Thank you for letting me know about this new trolling apparatus. I will put it to good use.
-
@pitaj said in Discussion of NodeBB Updates:
@ben_lubar Fuse.js is the fuzzy search library that is used in the emoji plugin. It's the best one I could find.
I plan on decreasing the weights for aliases and keywords (https://github.com/NodeBB/nodebb-plugin-emoji/issues/7)
Can you just sort the results so that "best" and "good" matches get moved to the top? E.g. do a stable sort on the list of emoji it returns, according to the ranks:
- whole string equals whole emoji name
- whole string equals whole emoji alias
- whole string is found in emoji name
- whole string is found in emoji alias
- anything else (fuzzy substring matches)
-
@anotherusername I'll see what it looks like after I make the changes and if it's still not acceptable I'll implement a secondary sort. Ideally I can figure out a way to get the fuzzy finder to sort how I want in the first place.
-
@julianlam said in Discussion of NodeBB Updates:
Be nice, we're paying him in bits of string.
Not old rope? Tsk!
-
@ben_lubar said in Discussion of NodeBB Updates:
@julianlam said in Discussion of NodeBB Updates:
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
Why would
rolleyes.gif
be a good match for:trolleybus
, even if that is the case?what causes to be the replacement for
:-D
which causes me to have to press escape after all my old school ascii faces, otherwise my posts will be littered with..... huh..... it picked two different replacements for
:-D
?!
-
@accalia said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@julianlam said in Discussion of NodeBB Updates:
You know what it looks like... is that it's matching all aliases for each of those emojis.
That is, based on what you're typing they all match thematically, roughly.
That said, the fact that single letters bring up unrelated matches is not good...
So a couple observations:
- It seems like aliases are treated with the same relevance as direct keyword matches (aliases ought to be nerfed a bit)
- It seems like matching of alises should only begin after a certain letter threshold is met (e.g. 3-4 letters). Anything less, and only direct matches show up.
Why would
rolleyes.gif
be a good match for:trolleybus
, even if that is the case?what causes to be the replacement for
:-D
which causes me to have to press escape after all my old school ascii faces, otherwise my posts will be littered with..... huh..... it picked two different replacements for
:-D
?!That's... special.
-
@accalia Obviously "-D" is closer to "up-down_arrow" and even "non-potable_water" than it is to "smiling_face_with_open_mouth"
-
This is an interesting failure mode:
No idea how to reproduce, but it could only be fixed by closing the tab and opening a new one.
-
@polygeekery unless you're using a dark theme, that's not likely to be something NodeBB is doing - it's probably your browser's rendering process dying for some reason (which admittedly could be NodeBB-related).
-
@ben_lubar said in Discussion of NodeBB Updates:
unless you're using a dark theme
I am not.
@ben_lubar said in Discussion of NodeBB Updates:
it's probably your browser's rendering process dying for some reason (which admittedly could be NodeBB-related).
Yes and yes.
-
just what
-
@pie_flavor said in Discussion of NodeBB Updates:
just
whatanother cache miss, down on his luckFTFY
-
@pie_flavor Not all emoji are available in all emoji sets. I believe our custom emoji have only been added to a single set, whereas at the time @marczellm was using a different set (most likely the default for NodeBB as opposed to the default for TDWTF). When the render-time emoji plugin went to replace the image source, alt text, and title text, it couldn't find them in the data for that set, and blindly substituted a stringified
undefined
object.I am not altogether sure why emoji need a render-time plugin, but there you go.
-
@twelvebaud The hell do you mean, 'set'? Are there different versions of WTDWTF, or what?
-
@pie_flavor said in Discussion of NodeBB Updates:
Are there different versions of WTDWTF, or what?
Depends on how your browser refreshed the page after the site was updated.
-
@twelvebaud said in Discussion of NodeBB Updates:
@pie_flavor Not all emoji are available in all emoji sets. I believe our custom emoji have only been added to a single set, whereas at the time @marczellm was using a different set (most likely the default for NodeBB as opposed to the default for TDWTF). When the render-time emoji plugin went to replace the image source, alt text, and title text, it couldn't find them in the data for that set, and blindly substituted a stringified
undefined
object.I am not altogether sure why emoji need a render-time plugin, but there you go.
Except that the posts are rendered server-side and cached perpetually.
-
@pie_flavor Different emoji sets. It looks like about three months ago emoji were jettisoned from NodeBB core and @PitaJ is redoing them. It also looks like from time to time @ben_lubar has to "recompile the client-side emoji data files" which throws my brain way off balance as it can't handle that that is a process which exists.
Ben gets to pick one or more emoji sets for us, and we just have to live with it; there's no user-level override. I fear the day he removes EmojiOne and installs nodebb-plugin-emoji-strike-the-earth...
-
can we just switch back to discourse
-
Feature request: automatically replace "discourse" in @pie_flavor 's posts with "a festering pile of shit."
Or worse, "community server."