Avatar randomly reverted?
-
hmm..... does anyone else see this? my avatar seems to have reverted back to four avatars ago.....
-
Most users don't change avatars four times per day. CLOSED: WON'T FIX, I guess...
-
well yes i guess. but still, is it only me seeing it or is it showing that way for everyone else?
i've done a full refresh and it's still the wrong avatar.
-
I'm seeing the first one from your screenshot.
-
hmmm... i'll call it JS weirdity then and stop worrying.
-
-
.... and there it picks up the right one again....
weird.
still missing my hat but i can't blame discourse for that!
-
I did fix this 2 days ago, was quite an involved series of issues.
-
-
Any idea when 1.2.beta6 will happen?
-
Discourse Syndrome.
in this case no.... neither the hatter nor his merry assistants has seen fit to hat my most recent avatar.
-
We are getting very close, I hope that by the end of the week.
-
in this case no.... neither the hatter nor his merry assistants has seen fit to hat my most recent avatar.
Have you read my most recent post in Mad Hatter Hijinx?
-
was quite an involved series of issues
Wow, even your bugs are overengineered.
Seriously, it seems like every problem lately is some kind of The Incredible Machine-style contraption going across the whole codebase. I can't even be pissed off as much as I'm amused.
-
Wow, even your bugs are overengineered.
Seriously, it seems like every problem lately is some kind of The Incredible Machine-style contraption going across the whole codebase. I can't even be pissed off as much as I'm amused.
The Rube Goldberg Machine antipattern?
-
not yet, but i'm on my way there next
-
Wow, even your bugs are overengineered.
To be fair this system is complex we perform resizing of avatars on demand so:
http://what.thedailywtf.com/user_avatar/what.thedailywtf.com/maciejasjmj/47/13194.png
for example is your avatar at 47px. Of course you don't want to be serving this stuff from the ruby process so we tell nginx to cache it forever. I needed to allow for situations where the upload id changes and ensurehttp://what.thedailywtf.com/user_avatar/what.thedailywtf.com/maciejasjmj/47/666.png
redirects you to the correct avatar.So there is quite a lot going on for such a seemingly simple part.
-
-
your avatar at 47px. Of course you don't want to be serving this stuff from the ruby process so we tell nginx to cache it forever
Not just resize on upload and save it? Then next time its uploaded, overwrite it?
Too simple?
-
If there's a cache, there's cache invalidation.
-
Not just resize on upload and save it?
Its very hard to guess which sizes the end user is going to need, and plugins may want different sizes as well. (not to mention needing doubling of everything for retina), bookkeeping for "desired image sizes" would add up big time and cause a different class of bugs.
-
bookkeeping for "desired image sizes" would add up big time and cause a different class of bugs.
Keep a few set classes and let the client shrink it to size if necessary? I mean yeah, you'll be wasting a few pixels of bandwidth with more uncommon sizes, but I think you've already spend more in development time than that bandwidth would cost.
Unless there are more weird considerations, I don't know.
-
-
-
now that the update is installed, is changing avatars working betterer?
-
haven't noticed any new issues.
i'll keep an eye open and shout if something changes.
-
When I changed my avatar about an hour ago, it showed up half its actual height/width on my profile page until I viewed my user card for the first time (or at least that's what I think made it change to the correct size).