Opening emoji selector crashes browser
-
- Click on this fucking stupid thing:
http://i.imgur.com/hOs4mWG.png
- Get a popup with emojis.
Expectation: browser not crash
What happens: because apparently displaying some 16x16 images is too hard, NodeBB fucks it up somehow and the browser crashes
-
E_WORKS_IN_MODERN_FIREFOX
-
@Jaloopa said in Opening emoji selector crashes browser:
E_WORKS_IN_MODERN_FIREFOX
Expectation: A list of 16x16 images should not crash a browser.
Justification: Discourse somehow managed to open an emoji explorer without crashing a browser, and it was a steaming pile of js shit.
-
Maybe don't load every fucking emoji all at once, huh?
2585 requests, taking over 30 seconds, transferring 4mb of data.
-
It didn't crash my not-ancient Firefox but it froze for a few seconds trying to make the list.
-
@Lorne-Kates said in Opening emoji selector crashes browser:
Maybe don't load every fucking emoji all at once, huh?
2585 requests, taking over 30 seconds, transferring 4mb of data.
Yeah, that definitely could be better.
Though caching helps a bit.It doesn't even open for me on mobile (probably due to z-order shenanigans in the custom theme again).
-
@coderpatsy said in Opening emoji selector crashes browser:
It didn't crash my not-ancient Firefox but it froze for a few seconds trying to make the list.
If I go to an instance of Discourse, and open the emoji selector, and it crashes my browser, I'll withdraw the bug.
If you can think of a good reason why showing a paginated list of 16x16 images should reasonably be expected to crash a browser, I'll withdraw the bug.
Otherwise, bug.
-
@Lorne-Kates said in Opening emoji selector crashes browser:
If I go to an instance of Discourse
Step 1: create a new account on meta.derp.
lololol... special snowflake "must have 10 characters in your password".
http://i.imgur.com/I3o2v0U.png
Why? I thought Dickhorse was immune to spammers. They'll never be able to bruteforce an 8 character password.
Okay, I'll just assume that my 10 character password must involve complex requirements like uppercase, numbers and special characters.
NOPE! Password
fuckyoudiscourse
(all lower case, no numbers, no characters) works.Someone want to do the math? What's more secure, an 8 character password that must have at least one upper, number and symbol-- or an all lowercase 10 character password?
-
Loading it multiple times without changing the page still freezes the browser and gives unresponsive script popups, so is going on can most very likely stand to be optimized.
-
Anyways. Discourse: latest (meta.derp).
FF22.
Click Emoji.
69 requests (I think there's a poll in there somewhere). 58.4kb. Emoji pagination works. Does not crash browser.
Bug remains open.
-
@Lorne-Kates said in Opening emoji selector crashes browser:
no characters
but you just said it has ten! Liar!
-
reproduced on FF nightly. browser became damn-near unusable for a good 5 minutes. 2,600 requests, 4.8MB.
I understand the motivation for using SVGs, but until there's a spritesheet equivalent for them, this might not be the best use of them...
-
after the icons are all loaded, opening the selector only hangs the page for about 5 seconds.
-
Opening the selector doesn't hang the page at all, even with cache disabled.
-
@ben_lubar weird, it opened faster the second time. /shrug
either way, this doesn't seem to be due to FF22
-
Edit: huh, it seems to be working on mobile again.
-
@bb36e said in Opening emoji selector crashes browser:
either way, this doesn't seem to be due to FF22
:smug:
-
What is, emoji spirit sheet with css selectors for request minimization and size savings, Alex.
-
@Matches said in Opening emoji selector crashes browser:
What is, emoji spirit sheet with css selectors for request minimization and size savings, Alex.
You didn't answer in the form of a question, since there's no question mark.
But this isn't Double Jeopardy, so you don't get penalized.
Unrelated: Jeopardy! recently changed the rule so Canadians can't apply. Not fair. I'll take "Fuck you, give me money" for $100, Alex.
-
@Lorne-Kates it's not a question, you're right. It's like "how can she slap!"
Seriously though. Sprite sheet and css selectors.
-
@bb36e Not multiple minutes, but still a scarily long amount of time on Firefox Developer Edition.
-
@aliceif I had the dev tools open to monitor requests -- that may have had something to do with it.
-
@Lorne-Kates said in Opening emoji selector crashes browser:
Expectation: A list of 16x16 images should not crash a browser.
Is this something like the nested kbd tags crashing older firefoxes?
EDIT: My experience on chrome is that the thing opens up pretty quickly and the images show as they load.
-
Takes about 5 seconds on my laptop (elementaryOS Freya, Firefox 48.0) on first open. About half that for subsequent openings. Browser is locked up until it opens.
-
@boomzilla I think it's the JS building the whole damn thing (some 700k of HTML) on-the-fly.
-
@anotherusername Hang on...trying FF...
-
@boomzilla I'm using FF. Takes about 5 seconds to render the damn thing.
-
@anotherusername That's about what I'm seeing.
Diagnosis:
E_FIREFOX
-
Firefox is not webscale enough
-
Solution: have the browser send Ajax calls to a distributed server and have the server render the emoji selector and give it back to the client
This makes the app isomorphic, which is an important thing to have for a project these days
-
@bb36e said in Opening emoji selector crashes browser:
Solution: have the browser send Ajax calls to a distributed server and have the server render the emoji selector and give it back to the client
Emoji selector CDN v2!
-
If it only rendered the visible tab of the emoji instead of the whole gosh darn thing, it'd probably be a lot faster. Then it could load the other tabs only if they're clicked on...
-
Well, it's not requesting anything via the websocket to render the list...
-
@anotherusername said in Opening emoji selector crashes browser:
Well, it's not requesting anything via the websocket to render the list...
I'm as shocked as you are.
-
Also takes about the same amount of time using Safari on latest iOS, if that helps.
-
@Erufael said in Opening emoji selector crashes browser:
Also takes about the same amount of time using Safari on latest iOS, if that helps.
The same amount of time as my ARM dhromebook or the same amount of time as Lorne Kates (presumably more powerful) PC with Firefox 22 on it?
Because it makes a difference.
-
@ben_lubar Sorry. As my previous post using FF 48 on my laptop.
-
@boomzilla said in Opening emoji selector crashes browser:
@anotherusername That's about what I'm seeing.
Diagnosis:
E_FIREFOX
@boomzilla said in Opening emoji selector crashes browser:
@anotherusername That's about what I'm seeing.
Diagnosis:
E_FIREFOX
E_REMOVE_FIREFOX_INSTALL_CHROME
FireFox shits itself doing absolutely nothing, every few minutes it just hangs! It is fucked up beyond repair.
-
@dse said in Opening emoji selector crashes browser:
FireFox shits itself doing absolutely nothing, every few minutes it just hangs! It is fucked up beyond repair.
Possibly related:
Chrome pausing for a few seconds every couple of minutes. ???
-
@Tsaukpaetra said in Opening emoji selector crashes browser:
@dse said in Opening emoji selector crashes browser:
FireFox shits itself doing absolutely nothing, every few minutes it just hangs! It is fucked up beyond repair.
Possibly related:
Chrome pausing for a few seconds every couple of minutes. ???Nope, I had this problem on Linux few months back. And that was when I ditched FF for good. There is no reason for FF to exist, they even copy the look and feel of Chrome, it is just the shittier version of Chrome written by incompetent Mozilla.
-
@dse said in Opening emoji selector crashes browser:
written by incompetent Mozilla
Writing phrases in that style is bad for two reasons:
- You sound like Donald Trump does when he hasn't prepared the speech in advance.
- It's redundant.
-
@dse said in Opening emoji selector crashes browser:
FireFox shits itself doing absolutely nothing, every few minutes it just hangs! It is fucked up beyond repair.
Maybe later versions do....
-
@ben_lubar said in Opening emoji selector crashes browser:
@dse said in Opening emoji selector crashes browser:
written by incompetent Mozilla
Writing phrases in that style is bad for two reasons:
- You sound like Donald Trump does when he hasn't prepared the speech in advance.
Of course! I am trolling
- It's redundant.
So is FireFox
@Lorne-Kates said in Opening emoji selector crashes browser:
Maybe later versions do....
Yes, it started almost the same time that they abandoned menus in favor of shamelessly copying Chrome's menu.
-
@dse said in Opening emoji selector crashes browser:
Yes, it started almost the same time that they abandoned menus in favor of shamelessly copying Chrome's menu.
They managed to make a hamburger that is not only different things stacked vertically but also different things stacked horizontally. I'm not sure if that's even something that can be compared to a food anymore.
-
@bb36e said in Opening emoji selector crashes browser:
2,600 requests, 4.8MB.
Is there any good reason why the emoji images collection can't get retrieved as a single zip file?
-
@flabdablet said in Opening emoji selector crashes browser:
@bb36e said in Opening emoji selector crashes browser:
2,600 requests, 4.8MB.
Is there any good reason why the emoji images collection can't get retrieved as a single zip file?
Because the ways of doing that seem pretty awkward and may not do what we're asking...
-
@dse But FIREFOX HAS MENUS.
You just have to set a checkbox.
-
@ben_lubar said in Opening emoji selector crashes browser:
They managed to make a hamburger that is not only different things stacked vertically but also different things stacked horizontally. I'm not sure if that's even something that can be compared to a food anymore.
Casserole menu!
-
@flabdablet I'd imagine that client side file decompression is pretty spotty right about now. We basically do the same thing with sprite sheets, but because nodebb uses svgs I don't think it's possible to do that.
-
@flabdablet said in Opening emoji selector crashes browser:
@bb36e said in Opening emoji selector crashes browser:
2,600 requests, 4.8MB.
Is there any good reason why the emoji images collection can't get retrieved as a single zip file?
It probably wouldn't be that big an improvement over an HTTP connection with keep-alive and compression enabled.