Blocking a prolific poster plays havoc with read positions on thread navigation
-
@julianlam
Precondition:- Infiniscroll turned on (
I know).
Steps to reproduce:
- Use the profile action to block an active user.
- Do any of the following:
2a. Navigate to a topic you've visited in the past in which the blocked user has posted
2b. Post in a topic in which the blocked user has posted
Expected behavior--
The last read marker and scroll position are correct (at the bottom if you've read all the unblocked posts). After posting, you're scrolled to the appropriate position.Actual behavior--
The last read marker and scroll position are horribly incorrect, seemingly at random. And scrolling to the bottom manually does not update the last read marker on reload/re-navigation.[1] There's an offset that seems, at casual inspection, to vary with the number of "hidden" replies/posts. Topics in which the banned user isn't very active aren't off by much, those in which they're a frequent poster are off by a large amount. Hypothesis--the psuedo-paging algorithm is borked.
- Infiniscroll turned on (
-
@Benjamin-Hall said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@julianlam
Precondition:- Infiniscroll turned on ( I know).
Steps to reproduce:
- Use the profile action to block an active user.
- Do any of the following:
2a. Navigate to a topic you've visited in the past in which the blocked user has posted
2b. Post in a topic in which the blocked user has posted
Expected behavior--
The last read marker and scroll position are correct (at the bottom if you've read all the unblocked posts). After posting, you're scrolled to the appropriate position.Actual behavior--
The last read marker and scroll position are horribly incorrect, seemingly at random. And scrolling to the bottom manually does not update the last read marker on reload/re-navigation.[1] There's an offset that seems, at casual inspection, to vary with the number of "hidden" replies/posts. Topics in which the banned user isn't very active aren't off by much, those in which they're a frequent poster are off by a large amount. Hypothesis--the psuedo-paging algorithm is borked.
Builder bias uncovered. You're welcome! Have you seen the thing they say is breaking the CSS? Other cowards are complaining about something in that area, but it doesn't seem at all well-characterized.
Amazed it took a brain-damaged Russian chick to find this feature for you, but the amazement didn't last through the first capital letter.
Fascinating slip on "banned" vs "blocked ". For your talk of cancel culture, you are more than ready to implement it.
I now refer you to the first sentence of this response.
- Infiniscroll turned on (
-
It doesn't work well with paging either.
-
@Karla said in Blocking a prolific poster plays havoc with read positions on thread navigation:
It doesn't work well with paging either.
Good to know.
My guess is that the paging algorithm is not taking into account the "missing" posts correctly on one side or the other.
-
@Benjamin-Hall said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@Karla said in Blocking a prolific poster plays havoc with read positions on thread navigation:
It doesn't work well with paging either.
Good to know.
My guess is that the paging algorithm is not taking into account the "missing" posts correctly on one side or the other.
Isn't there a similar bug with profile pages and ignored categories? I seem to remember someone looking at the profile of a prolific garage poster and seeing the first page consisting of "this person hasn't posted anything yet. Next page..."
-
@Jaloopa said in Blocking a prolific poster plays havoc with read positions on thread navigation:
Isn't there a similar bug with profile pages and ignored categories?
There are a bunch of bugs related to pagination. They all seem to boil down to doing pagination before collapsing, hiding, or other processing that changes the number of things on the page, and then being confused that the number of things on the page doesn't match what it expects.
-
I don't have anyone ignored and I find myself going to the wrong part of a topic. Maybe once or twice a day? Almost exclusively on desktop, too.
-
@Benjamin-Hall said in Blocking a prolific poster plays havoc with read positions on thread navigation:
Actual behavior--
The last read marker and scroll position are horribly incorrect, seemingly at random.Random weird behavior is how this place works.
-
@El_Heffe The forum software, or the forum users?
(Yes.)
-
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
You're not weird...
-
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
Yes.
-
@El_Heffe said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
Yes.
I agree with whatever @El_Heffe just said
-
@Jaloopa said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
Yes.
I agree with whatever @El_Heffe just said
I agree with whatever
SELECT username FROM posts WHERE topic_id = ? ORDER BY post_date LIMIT 1just said
-
@sloosecannon said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@Jaloopa said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
Yes.
I agree with whatever @El_Heffe just said
I agree with whatever
SELECT username FROM posts WHERE topic_id = ? ORDER BY post_date LIMIT 1just saidThat's you. Well, it was.
-
@Gribnit said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@sloosecannon said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@Jaloopa said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@HardwareGeek said in Blocking a prolific poster plays havoc with read positions on thread navigation:
@El_Heffe The forum software, or the forum users?
(Yes.)
Yes.
I agree with whatever @El_Heffe just said
I agree with whatever
SELECT username FROM posts WHERE topic_id = ? ORDER BY post_date LIMIT 1just saidThat's you. Well, it was.
I see no problem here.
-
I'm having the same problem: when I've blocked someone, if they're active in a thread, all of my "someone replied" notifications go to the wrong post.
So, in short, it seems like CSS hacks work better for blocking than NodeBB does.
-
@PotatoEngineer said in Blocking a prolific poster plays havoc with read positions on thread navigation:
I'm having the same problem: when I've blocked someone, if they're active in a thread, all of my "someone replied" notifications go to the wrong post.
So, in short, it seems like CSS hacks work better for blocking than NodeBB does.
I do what I can to promote software quality. But the word "hero" is used too lightly these days. Please hold your accolades.
