Notification Communications
-
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more either.
-
@izzion said in 🙅 THE BAD IDEAS THREAD:
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more.Luuuuuuubaaaaaaaaar!
@ben_lubar
-
@M_Adams said in 🙅 THE BAD IDEAS THREAD:
@izzion said in 🙅 THE BAD IDEAS THREAD:
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more.Luuuuuuubaaaaaaaaar!
@ben_lubarWhat do you want me to do? Reinstall Redis?
-
@ben_lubar said in 🙅 THE BAD IDEAS THREAD:
@M_Adams said in 🙅 THE BAD IDEAS THREAD:
@izzion said in 🙅 THE BAD IDEAS THREAD:
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more.Luuuuuuubaaaaaaaaar!
@ben_lubarWhat do you want me to do? Reinstall Redis?
I know, I know, counting is hard...
-
@ben_lubar said in 🙅 THE BAD IDEAS THREAD:
@M_Adams said in 🙅 THE BAD IDEAS THREAD:
@izzion said in 🙅 THE BAD IDEAS THREAD:
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more.Luuuuuuubaaaaaaaaar!
@ben_lubarWhat do you want me to do? Reinstall Redis?
What about the notification subsytem prevents it from updating the UI?
-
@boomzilla said in 🙅 THE BAD IDEAS THREAD:
@ben_lubar said in 🙅 THE BAD IDEAS THREAD:
@M_Adams said in 🙅 THE BAD IDEAS THREAD:
@izzion said in 🙅 THE BAD IDEAS THREAD:
@M_Adams
I'm pretty sure that's less NodeBB's fault and more the "patch" Ben put together a few weeks back for changing the notification subsystem to use the database as the backend. Same core problem as has made the notification bell not update by websocket any more.Luuuuuuubaaaaaaaaar!
@ben_lubarWhat do you want me to do? Reinstall Redis?
What about the notification subsytem prevents it from updating the UI?
I'm assuming it's not passing socket.io messages correctly between the instances.
-
@ben_lubar said in 🙅 THE BAD IDEAS THREAD:
I'm assuming it's not passing socket.io messages correctly between the instances.
Hmm...was that something you changed? This has been kicking around for a while now. I don't recall it being reported upstream.
-
@boomzilla said in 🙅 THE BAD IDEAS THREAD:
@ben_lubar said in 🙅 THE BAD IDEAS THREAD:
I'm assuming it's not passing socket.io messages correctly between the instances.
Hmm...was that something you changed? This has been kicking around for a while now. I don't recall it being reported upstream.
Our current implementation is this one:
-
@ben_lubar OK, so...I guess that disabled communicating through the DB (based on the title, not by looking at any code). Was there an alternate way of communicating those? What was the problem that was being solved by not communicating via the DB?
-
@boomzilla said in 🙅 THE BAD IDEAS THREAD:
@ben_lubar OK, so...I guess that disabled communicating through the DB (based on the title, not by looking at any code). Was there an alternate way of communicating those? What was the problem that was being solved by not communicating via the DB?
The problem was that some messages were being dropped by the database because they were longer than the limit for NOTIFY. The implementation in that PR makes it use NodeJS IPC.
-
@ben_lubar Ah. So something there is breaking down?
Alternately: Is there the possibility of changing what is being sent via NOTIFY to a pk in a table of messages or something that could be long enough?
-
[forked this out to meta where it belongs]
-
@boomzilla said in Notification Communications:
I don't recall it being reported upstream.
I'm sorry, been lazy. Mentioned it several times in the Status thread, so that counts for a least one cent, right?
-
@Tsaukpaetra I created a Bugs thread a while ago. I never go into Status unless someone mentions me there. But you probably knew that.
-
@boomzilla said in Notification Communications:
@Tsaukpaetra I created a Bugs thread a while ago. I never go into Status unless someone mentions me there. But you probably knew that.
I have noticed you don't typically upvote me there. I didn't think anything unusual, so have not mentioned it.
Allow single-host clusters to not send pubsub and socket.io messages through the database. by BenLubar · Pull Request #6659 · NodeBB/NodeBB