In which users yell at @ben_lubar about select-to-quote sucking
-
@error said in Thanks for the tip!:
Filed under: The quote button removed the emoji. I manually reinserted it., CC @ben_lubar
The problem is:
- NodeBB does the Discourse thing and quotes from the "baked" version instead of the "raw" version.
- We can't make it do what Community Server did because NodeBB doesn't allow HTML by default.
- Quoting is hard.
We could fix this in one of two ways:
- Go from the "baked" version to the "raw" version somehow. Run the functions in reverse, I don't care.
- Store raw-offsets in the cooked post somehow. Still needs cooperation from all of the plugins that modify post content, but probably a lot easier. Either send the offsets for every post or generate them when the client requests to selectively quote a post and somehow match them up with the user's selection.
Actually, three ways:
- Ignore the select-to-quote feature and quote the full post, then edit it.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Ignore the select-to-quote feature and quote the full post, then edit it.
This is generally what I do when there is formatting that I wish to preserve for a quote.
-
@ben_lubar It also puts the quoted content at the end of the in-progress post, instead of where the insertion point is.
Doubly-annoying, because dragging-and-dropping an image puts the image at the insertion point and not the end of the post. Could at least be consistently wrong.
-
@ben_lubar does NodeBB have built-in support for any formatting in posts, or is that 100% added through plugins?
-
@anotherusername said in In which users yell at @ben_lubar about select-to-quote sucking:
@ben_lubar does NodeBB have built-in support for any formatting in posts, or is that 100% added through plugins?
Markdown is a plugin that's installed by default. Without any plugins the posts are unrestricted HTML like Community Server had.
-
@ben_lubar ew.
Well, from a user's perspective, if it could reproduce emoji and markdown I'd be happy. If it could replace a onebox with the raw URL that oneboxed, that'd be a bonus.
From a programmer's perspective, that's the first of the two ways you described, and considering that it has to play nicely with a bunch of plugins it's very much .
-
@anotherusername said in In which users yell at @ben_lubar about select-to-quote sucking:
if it could reproduce emoji and markdown
Emoji is quite simple because 's alt text is
:frog:
. Markdown is basically the entire problem.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Without any plugins the posts are unrestricted HTML like Community Server had.
That could be fun......
-
@ben_lubar it wouldn't be that hard to handle italics, bold, links, pre/code blocks, lists, and quotes, and produce markdown that mostly reproduces it without blowing up too badly for most typical situations. It'd be 99% better than what it does currently.
I just can't shake how ... dirty that'd feel.
The "right" way to do it would be to try to calculate offsets. But that would be hard.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Actually, three ways:
Actually, four ways:
- Have a Show Raw button that displays the entire post exactly as the composing user entered it, and allow that to be used as a source for quoting.
Given that Nod allows posts to be edited, it's obviously keeping raw versions around as well as baked ones, so Show Raw wouldn't need to unfunctionate anything, just pull the raw version that already exists. Let human eyeballs be the tool used to work out which bits of raw correspond to the wanted bits of baked. They're better at that than computers.
-
Another way: Use WYSIWYG like every single other forum in the world does. *
* By "every", I mean every one that hasn't gotten the Markdown brainworm-- and intestinal worms from eating dogfood-- then shoved their heads so far up their own asses that their intestinal worms have mated with the brainworms creating a super-parasite worm.
-
@flabdablet said in In which users yell at @ben_lubar about select-to-quote sucking:
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Actually, three ways:
Actually, four ways:
- Have a Show Raw button that displays the entire post exactly as the composing user entered it, and allow that to be used as a source for quoting.
Given that Nod allows posts to be edited, it's obviously keeping raw versions around as well as baked ones, so Show Raw wouldn't need to unfunctionate anything, just pull the raw version that already exists. Let human eyeballs be the tool used to work out which bits of raw correspond to the wanted bits of baked. They're better at that than computers.
Click the quote button without a selection
-
@flabdablet said in In which users yell at @ben_lubar about select-to-quote sucking:
Given that Nod allows posts to be edited, it's obviously keeping raw versions around as well as baked ones, so Show Raw wouldn't need to unfunctionate anything, just pull the raw version that already exists.
That's a really good point, assuming it doesn't just dump the raw versions after the timeout is up for editing. But if the editor can retrieve a raw version, the quoting function should be able to also.
-
@Polygeekery said in In which users yell at @ben_lubar about select-to-quote sucking:
@flabdablet said in In which users yell at @ben_lubar about select-to-quote sucking:
Given that Nod allows posts to be edited, it's obviously keeping raw versions around as well as baked ones, so Show Raw wouldn't need to unfunctionate anything, just pull the raw version that already exists.
That's a really good point, assuming it doesn't just dump the raw versions after the timeout is up for editing. But if the editor can retrieve a raw version, the quoting function should be able to also.
Why are you people talking about the quote button as if it doesn't do that?
This topic is about select-to-quote, not full post quotes.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Why are you people talking about the quote button as if it doesn't do that?
This topic is about select-to-quote, not full post quotes.Well someone is certainly wearing their Crankypants tonight.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
@Polygeekery said in In which users yell at @ben_lubar about select-to-quote sucking:
@flabdablet said in In which users yell at @ben_lubar about select-to-quote sucking:
Given that Nod allows posts to be edited, it's obviously keeping raw versions around as well as baked ones, so Show Raw wouldn't need to unfunctionate anything, just pull the raw version that already exists.
That's a really good point, assuming it doesn't just dump the raw versions after the timeout is up for editing. But if the editor can retrieve a raw version, the quoting function should be able to also.
Why are you people talking about the quote button as if it doesn't do that?
This topic is about select-to-quote, not full post quotes.
The solution is to remove select-to-quote, Or to pop up and tell users if they are sure they are Ok with losing the emoji and oneboxes. Everyone loves popups, then in the same popup add "I am sure, do not ask me this again" and will be grateful for not seeing the popup again.
-
@ben_lubar said in In which users yell at @ben_lubar about select-to-quote sucking:
Go from the "baked" version to the "raw" version somehow. Run the functions in reverse, I don't care.
Next you want me regurgitate on my smart phone to compute how much Calories I spent today!
-
@dse said in In which users yell at @ben_lubar about select-to-quote sucking:
Next you want me regurgitate on my smart phone
If it's an Apple.
-
...
-
@dse said in In which users yell at @ben_lubar about select-to-quote sucking:
regurgitate on my smart phone