find --no-preserve-search-terms
-
I type stuff into the search in the top bar.
I click the gears.
I get to the advanced search but my search terms are lost.Why doesn't nodeBB just copy them over?
-
@aliceif The search is broken anyway. Guess what isn't on one of the first pages when I search for "Things our customers have said about Discourse"? Yep, the thread with that exact title.
-
@asdf said:
@aliceif The search is broken anyway. Guess what isn't on one of the first pages when I search for "Things our customers have said about Discourse"? Yep, the thread with that exact title.
Then search by title.
-
@asdf no repro:
-
@aliceif https://what.thedailywtf.com/search/Things our customers have said about Discourse?in=titles&sortBy=timestamp&sortDirection=desc&showAs=posts
-
@asdf https://what.thedailywtf.com/search/"Things our customers have said about Discourse"?in=titles&sortBy=timestamp&sortDirection=desc&showAs=posts
-
@asdf said:
@aliceif https://what.thedailywtf.com/search/Things our customers have said about Discourse?in=titles&sortBy=timestamp&sortDirection=desc&showAs=posts
That's shitty.
-
@ben_lubar OK, it works with quotes. Still, without the quotes the thread whose title matches every single word in my query is nowhere to be found.
-
@asdf said:
@aliceif The search is broken anyway. Guess what isn't on one of the first pages when I search for "Things our customers have said about Discourse"? Yep, the thread with that exact title.
Maybe it's adapted to your browsing habits, like Google. Tell us, do you have a lot of porn in those results?
-
-
@Maciejasjmj said:
Tell us, do you have a lot of porn in those results?
Do XSS exploits count as porn?
-
@asdf said:
@Maciejasjmj said:
Tell us, do you have a lot of porn in those results?
Do XSS exploits count as porn?
We're not judging your fetishes.
Although I do feel the need to scrub myself clean now...
-
@Maciejasjmj said:
We're not judging your fetishes.
Must… resist… urge… to… page… certain… people…
-
@ben_lubar said:
any quote will have said as a word contained in the post.
True, but the title should have a higher priority than the post contents when sorting the search results.
-
Okay, everyone. I enabled
/t/whatever/123
URL redirects and it turns out that the Discopedia meta thread was crashing the server.
-
@ben_lubar Ok, turns out visiting a PM that you weren't allowed in also crashed the server.
You creeps.
-
At least when NodeBB shits itself, it recovers in seconds; Discourse would take up to half an hour
-
@RaceProUK I think the rule is something like "first 3 crashes in 10 seconds get instant restarts" and after that the docker container shuts down and upstart restarts it eventually.
-
@ben_lubar said:
any quote will have said as a word contained in the post.
Why would that be indexed as if it were post content? You could just say "the search indexer is broken", that would be simpler.
-
@blakeyrat It's literally just mongodb's fulltext search index.
-
@ben_lubar I don't care why it's broken, the point is it is broken.
"@ben_lubar said:" in that post is OBVIOUSLY UI and not post content. Yes it happens to look like post content, but it isn't. Therefore, it shouldn't be indexed as if it were.
Look, people, when you're writing software, please just engage your brain and think about what you're doing. The search indexer should only search the parts of the post that aren't obviously UI.
-
@blakeyrat Personally, I'm also really fucking tired of idiot software that OR's all my search terms.
I can count on zero fingers the number of times that I have ever wanted that. If I add words to my fucking search, I WANT TO NARROW THE FUCKING SEARCH.
-
@Weng I can't say I've never wanted an OR in a search, but, yes, the vast majority of times more terms should make it more specific. If I do want an OR, let me type a OR b, like Google used to do before it tried to gain sentience.
-
@HardwareGeek google regressed to the point that is common for me to look into other search engines
-
@blakeyrat said:
"@ben_lubar said:" in that post is OBVIOUSLY UI and not post content. Yes it happens to look like post content, but it isn't.
Except it is post content, same as [insert forum software here]
-
@RaceProUK said:
Except it is post content, same as [insert forum software here]
No. It's a UI widget that indicates the following blockquote originated from another post. I didn't type it. It's not my text. It shouldn't be searched as if it were.
-
@blakeyrat said:
It's a UI widget that indicates the following blockquote originated from another post.
You sure about that? Looks like text content to me:
But hey, if you're going to ignore the most basic truths, then don't be surprised when no-one listens to you.
-
@RaceProUK If I search for the word "blockquote", should it search for
<blockquote>
tags?
-
@RaceProUK Fine; you think it's useful for the search indexer to have 650,000,000 copies of the auto-generated word "said" (making it impossible to search for the typed word "said".) Whatever. I'm not going to debate with you. You're perfectly right and Blakeyrat is a stupid moron idiot stupid head.
-
@RaceProUK said:
You sure about that? Looks like text content to me:
But only because NodeBB's implementation of quotes is stupid.
-
@aliceif said:
If I search for the word "blockquote", should it search for <blockquote> tags?
If that's what's in the raw, then why not?
@blakeyrat said:
You're perfectly right and Blakeyrat is a stupid moron idiot stupid head.
Remember, you heard it here first!
@asdf said:
But only because NodeBB's implementation of quotes is stupid.
Every forum package I've ever used embeds quotes in a similar manner; normally they're enclosed in [quote] BBCode tags. Discourse did it that way, as does phpBB, SMF, XenForo, IPB, etc; to do it any other way would just increase the complexity of the feature.
Hang on… what's going on with the Markdown?
Edit: Ah, fixed it.
-
@RaceProUK said:
Every forum package I've ever used
Lolwhat? we just came from one that didn't. The stupid part is the "so-and-so said:" text being inserted for no good reason when the bbcode quote tag has existed forever and can embed that information for display prettily.
-
Well, I'm sorry if no-one bothered to explain the fucking problem. Is it really too much for people to do so?
Oh, of course it is. Who am I fucking kidding. Maybe I'll just develop psychic powers or some such shit.
-
By the way, since nobody beats Google at search, we could just use Google. Maybe I should write a search provider that just uses Google's custom embedded search thing.
-
@RaceProUK said:
Looks like text content to me
@asdf said:
But only because NodeBB's implementation of quotes is stupid.
So... that's the problem.
-
Yes, because obviously someone saying 'It's stupid' is a complete explanation of the issue. Or maybe I missed it because it was microencoded in the fucking apostrophe or something.
-
@RaceProUK Wow. Ok, whatever.
-
No really, it is all my fault. What was I thinking? I should have known that making a useless search term useless is worth throwing a nuclear-grade hissy fit over. Maybe we should open an issue about this on NodeBB's GitHub. Oh wait, what about the word 'the'? Or maybe 'an'?
Seriously, who searches for 'said'?
-
@RaceProUK said:
Oh, of course it is. Who am I fucking kidding. Maybe I'll just develop psychic powers or some such shit.
@blakeyrat can probably help you with that.
-
- Additionally,
text
indexes do not store phrases or information about the proximity of words in the documents. As a result, phrase queries will run much more effectively when the entire collection fits in RAM.
- Additionally,
-
@ben_lubar wait, there's a sort-by-score thing. I wonder why the dbsearch plugin ignores that.
-
-
@ben_lubar Nope, still a pile of useless crap.
That particular kind of potatoes was mentioned in a thread once.
It doesn't appear on the top result spot - and not even on the first page!Useless.
-
@aliceif said:
@ben_lubar Nope, still a pile of useless crap.
That particular kind of potatoes was mentioned in a thread once.
It doesn't appear on the top result spot - and not even on the first page!Useless.
Pretty sure that patch hasn't been applied here..... Given the URL and the fact that it utterly failed to return a relevant result for "desktop search" too
-
@sloosecannon correct! However, putting quotes around @aliceif's search term returns one result both here and on the test forum.
-