Blakeyrat pointing out NodeBB problems
-
@tufty but the purge option doesn't work for us plebs
it's just visible to show us how inferior and unprivileged we are
-
@fbmac except if restore works, purge probably does too... Or did you try it FOR SCIENCE?
-
@tufty said in Blakeyrat pointing out NodeBB problems:
@Yamikuronue Yeah, I know, I had the "purge" option as well.
I shouldn't have had either.
Forget security by obscurity. This is security by honor system.
-
@Arantor I tested
-
@fbmac so it's even worse: it displays options you can't use for one thing, then also displays another option that you also shouldn't have, but let's you do that...
-
@Arantor the UI simply doesn't care about permissions and let the core deal with thay
-
@Arantor Yep. Quality software from quality developers. Mind you, even if the UI blocked access, I have no confidence that the back end would bother re-checking.
-
@tufty sure you don't mean kwality?
-
@tufty said in Blakeyrat pointing out NodeBB problems:
@Arantor Yep. Quality software from quality developers. Mind you, even if the UI blocked access, I have no confidence that the back end would bother re-checking.
The UI doesn't block access to ANYTHING client-side.
-
@ben_lubar correct, it even shows options it shouldn't, which is what was being referred to.
-
… and the back end doesn't block things it should. Was the securty side of things developed by Paula?
-
@tufty what is the back end allowing that it shouldn't?
-
@fbmac restoring soft deleted posts
-
@fbmac Me being able to restore one of my posts that had been soft deleted by the mods.
-
@tufty said in Blakeyrat pointing out NodeBB problems:
@fbmac Me being able to restore one of my posts that had been soft deleted by the mods.
Why would that be something it prevents? If a mod wants to make it so you can't restore a post, they have the purge option. And if it becomes a problem, there's also the ban option.
-
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
And if it becomes a problem, there's also the ban option.
Not welcome here you are, for a discoyear?
-
@ben_lubar why should a non mod be able to undo a moderator action in the first place? Even editing a post after a moderator edited it is questionable.
-
@Arantor if a moderator fixes something in your profile settings, should that lock you out of editing your profile indefinitely?
-
@ben_lubar moderator actions are something that mere users should not be able to reverse. If the mods decide one my posts is beyond the pale, either I accept that, or petition the mods to have it undeleted. I don't get to just go and reinstate it.
It probably wouldn't even have been noticed that I'd reinstated my post, explicitly reversing moderator action, except that I mentioned it.
Fuck. I can't believe I'm having to explain this to an admin.
-
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
@Arantor if a moderator fixes something in your profile settings, should that lock you out of editing your profile indefinitely?
Perhaps not in the general case, no. But if I change my avatar to meatspin.gif, I would expect to find myself locked out of editing my avatar pretty damn fast.
-
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
@tufty said in Blakeyrat pointing out NodeBB problems:
@fbmac Me being able to restore one of my posts that had been soft deleted by the mods.
Why would that be something it prevents? If a mod wants to make it so you can't restore a post, they have the purge option. And if it becomes a problem, there's also the ban option.
'purge' works as a 'hard hide' ( hides, not user reversible, content preserved) or as a 'delete' (content deleted, unrecoverable by mods) ?
I see why a mod would hesitate to use 'purge' if the second case.
-
@cabrito said in Blakeyrat pointing out NodeBB problems:
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
@tufty said in Blakeyrat pointing out NodeBB problems:
@fbmac Me being able to restore one of my posts that had been soft deleted by the mods.
Why would that be something it prevents? If a mod wants to make it so you can't restore a post, they have the purge option. And if it becomes a problem, there's also the ban option.
'purge' works as a 'hard hide' ( hides, not user reversible, content preserved) or as a 'delete' (content deleted, unrecoverable by mods) ?
I see why a mod would hesitate to use 'purge' if the second case.
If the content needed to be kept, it could be moved to a forum the user couldn't access, as has been done here in the past.
-
- This fits the criteria rather well, unless you have goatophobia:
- Why I could drag and drop the screen shot (for automatic upload) but goat2 is opened in the browser? both are png. Only one file can be drag-dropped?
-
@Arantor moderators already have too much power as it is
down with the establishment!!
-
@dse said in Blakeyrat pointing out NodeBB problems:
- Why I could drag and drop the screen shot (for automatic upload) but goat2 is opened in the browser? both are png. Only one file can be drag-dropped?
There's a specific region of the composer that stuff can be dragged into. If you're in the right place, a blue box appears because of TDWTF's custom CSS.
-
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
If you're in the right place, a blue box appears because of TDWTF's custom CSS.
Now that you mentioned it yes I can see it! Any reason that it does not cover all the way from top to bottom of the composer? Only like 2/3 of height is covered.
-
@tufty said in Blakeyrat pointing out NodeBB problems:
soft deleted
Why is this even a thing in the software? It seems like it would never be used, except by accident. No Mod in the history of ever would expect something called "delete" to mean "unless the user decides otherwise".
Did the developer who came up with this idea also want to implement WhispersBB?
-
@tufty said in Blakeyrat pointing out NodeBB problems:
The @mods, at the request of @Vaire, who has no sense of humour, removed one of my posts. Which is fair enough, moderator discretion and it was badly worded anyway. So, I can see it, kinda greyed out, but I guess nobody else can.
However, it has this little 3 vertical dot "you can do shit" icon to the right of it. So I click on it. It has a "restore" option./* Replace deleted posts with "This post is deleted !" until you hover over it (if it's a post you deleted) */ .posts .deleted .content:not(:hover) { color: transparent; } .posts .deleted .content:not(:hover):not(:empty)::before { content: 'This post is deleted !'; position: absolute; color: #333; } .posts .deleted .content:not(:hover) > *, .deleted *[component='post/edit'], posts .deleted .divider:last-child { display: none; }
@ben_lubar said in Blakeyrat pointing out NodeBB problems:
There's a specific region of the composer that stuff can be dragged into. If you're in the right place, a blue box appears because of TDWTF's custom CSS.
Why not make our custom CSS fix the stupid box instead of just highlighting it?
/* Make the "drag and drop images here" div *correctly* cover the composer area */ .imagedrop > * { position: relative; top: 50%; transform: translatey(-50%); } .imagedrop { top: 0 !important; height: 100% !important; left: 0; }
(disclaimer: I only know that works in Firefox, might need some tweaking to get it to work in all browsers. IIRC that
translatey
thing is kind of a hack.)
-
Why show the
purge
option only to show this later:
-
@anotherusername Yeah, right.
Because we should absolutely be trying to fix utterly retarded design with CSS.
-
@tufty isn't that what CSS is for?
-
@Jaloopa Isn't that what CSS is?
-
@flabdablet isn't that what CSS?
-
@Jaloopa !important, that's what CSS is.
-
For some reason, when I click on the triple-dot ... thing? on either of these two posts, instead of giving me the menu that allows me to edit the post, I get shot back to the top of the topic.
I should start reporting cases here where the forum crashed while I was writing or trying to submit a post, but I can't because the forum's crashed when those happen. For the record, starting on Saturday, that's happened at least 6 times to me.
-
@blakeyrat said in Blakeyrat pointing out NodeBB problems:
For some reason, when I click on the triple-dot ... thing? on either of these two posts, instead of giving me the menu that allows me to edit the post, I get shot back to the top of the topic.
I should start reporting cases here where the forum crashed while I was writing or trying to submit a post, but I can't because the forum's crashed when those happen. For the record, starting on Saturday, that's happened at least 6 times to me.This happens whenever you need to do a hard refresh. All the javascript handlers have shit themselves.
You can also tell because the favicon turns back into the WTF guy, instead of the useless Discocounted number.
Why? Because Web 3.0, that's why! FUCK YOU.
-
@Lorne-Kates You'd think a refresh would FIX missing handlers like that.
-
@Lorne-Kates said in Blakeyrat pointing out NodeBB problems:
You can also tell because the favicon turns back into the WTF guy, instead of the useless Discocounted number.
Never see either of those TBH. Nearly as soon as it loads, it becomes a "Hey, this site is a dooface and requested unsecure stuff elsewhere!" icon.
-
@blakeyrat said in Blakeyrat pointing out NodeBB problems:
@Lorne-Kates You'd think a refresh would FIX missing handlers like that.
You'd think so. I'd think so.
A web 3.0 developer doesn't think
so.
-
Gee. I wonder why I didn't notice the Ignore Thread option now existed.
Maybe because it opens outside the window bounds 100% of the time? Maybe that? Maybe?
-
@blakeyrat I hate that dropdown. It makes the page longer for no reason.
-
@Magus The person who implemented this menu item, did they even click the menu ONCE to try it out? How could they fail to notice that it opened off-screen?
I mean I know I go on and on about this, but what the fuck! How do you test this, even the most CURSORY TESTING IN THE UNIVERSE and fail to notice this bug? How do you look at that, then nod to yourself and says, "yup works! Push it to production!" What the fuck is WRONG with that person!
-
@blakeyrat Like the composer and most other things, though, you can still scroll down to it. It expands the scrollbar.
So it hides things stupidly, without a doubt, but it isn't as bad as half the discourse additions, where you couldn't be sure of anything about them.
-
@blakeyrat said in Blakeyrat pointing out NodeBB problems:
Gee. I wonder why I didn't notice the Ignore Thread option now existed.
Maybe because it opens outside the window bounds 100% of the time? Maybe that? Maybe?Unable to reproduce:
-
@blakeyrat (serious response now)
The JS event that displays the dropdown could do something like:
var main = document.querySelector("main#panel"); // assume: ulElement is the <ul> of the list being opened ulElement.classList.remove("dropdown-menu-upward"); // in case it was opened before if (ulElement.getBoundingClientRect().bottom > main.getBoundingClientRect().bottom) { ulElement.classList.add("dropdown-menu-upward"); }
(note that first line can't be moved into an
else
because it affects the calculation ofulElement.getBoundingClientRect()
.)And the CSS:
.dropdown-menu.dropdown-menu-upward { top: unset; bottom: 100%; margin: 0 0 2px; }
Then it'd open upward instead of downward.
@boomzilla, your plugin is responsible for that list, right?paging @julianlam, this apparently applies to every dropdown menu, including the menu on individual posts. Could something like this be added globally?
-
@anotherusername said in Blakeyrat pointing out NodeBB problems:
Then it'd open upward instead of downward. @boomzilla, your plugin is responsible for that list, right?
No. I did an implementation of that stuff, but it has to be in core. They redid it. You should open an issue on the main NodeBB repo. Or put it in ours and wait for @ben_lubar to move it over. Or just submit a PR.
-
@boomzilla said in Blakeyrat pointing out NodeBB problems:
@anotherusername said in Blakeyrat pointing out NodeBB problems:
Then it'd open upward instead of downward. @boomzilla, your plugin is responsible for that list, right?
No. I did an implementation of that stuff, but it has to be in core. They redid it. You should open an issue on the main NodeBB repo. Or put it in ours and wait for @ben_lubar to move it over. Or just submit a PR.
If only there were some way to BLOCK elements from rolling off the page. Like some MODEL where it could be kept in a BOX and allowed to alter the FLOW.
Like
display:block
But nah. css3 and javascript!
-
@Lorne-Kates said in Blakeyrat pointing out NodeBB problems:
If only there were some way to BLOCK elements from rolling off the page. Like some MODEL where it could be kept in a BOX and allowed to alter the FLOW.
Like display:block
But nah. css3 and javascript!Would that keep it from going off the page? I do not even try to predict what CSS will do.
-
@blakeyrat said in Blakeyrat pointing out NodeBB problems:
@Magus The person who implemented this menu item, did they even click the menu ONCE to try it out? How could they fail to notice that it opened off-screen?
I mean I know I go on and on about this, but what the fuck! How do you test this, even the most CURSORY TESTING IN THE UNIVERSE and fail to notice this bug? How do you look at that, then nod to yourself and says, "yup works! Push it to production!" What the fuck is WRONG with that person!
That's @boomzilla IIRC...
-
@Lorne-Kates said in Blakeyrat pointing out NodeBB problems:
If only there were some way to BLOCK elements from rolling off the page. Like some MODEL where it could be kept in a BOX and allowed to alter the FLOW.
Like
display:block
But nah. css3 and javascript!
edit: Really, I don't see what the problem is anyway. The button already uses Javascript to open/close that menu. How else would it work? And what's wrong with using Javascript to detect whether the menu should open upward or downward? I'm almost positive you can't do it in pure HTML/CSS. The only thing that does that (detect which direction to open so as to always be visible) in pure HTML/CSS is
<select>
, and those are extremely limited... you couldn't reproduce that menu, with its icons and multiple lines and styles per option, with a<select>
.