Is link highlighting now broken in topic lists?



  • Clicking a link on a topic list used to turn it a lighter shade until another post rolled in, as the URL had been visited. Seems this morning it's not doing that any more?

    Tested on Discourse default.


  • Winner of the 2016 Presidential Election

    relevant:

    Filed under: Second relevant post today



  • Oh right. Of course. Fuck sake.

    It wasn't confusing, and I'm not sure what he's on about as you only needed to visit it once.

    @PJH can we CSS this back in please?



  • @loopback0 said:

    you only needed to visit it once.

    At least in my case, I needed to visit them twice.

    Consider a topic with 10 posts, and 5 read.
    Before you visit it, its URL is /t/some-topic/1000/5, so not visited.
    After you visit it, its URL is /t/some-topic/1000/10, so not visited. Actually, since Discourse updates the URL while you’re reading the topic, it’s possible that your browser considers it visited; but Firefox doesn’t do this AFAIK.
    After you visit it again, its URL is /t/some-topic/1000/10, so it’s now visited.

    TL;DR: it’s browser-dependent.



  • Oh right. Yeah, I guess that makes sense, I just don't remember ever seeing that.

    I have the Discohistory turned off so the URL doesn't update when reading the topic.


  • SockDev

    @Kuro said:

    relevant:

    OH THANK THE GODDESS!

    that highlighting was so annoying and disconsistent! i understand the intention behind the coloring, but it just never worked for me and drove me absolutely batty!



  • I WANT IT BACK.

    Fuck you Dischorse, that is descriptive.


  • SockDev

    …user configurable option? @sam?


  • SockDev

    i guess we cancel each other out on this score.

    sorry mate.



  • @RaceProUK said:

    user configurable option

    Isn’t that Doing It Wrong™?



  • I'd CSS it back locally if I could figure out the right values.



  • @accalia said:

    that highlighting was so annoying and disconsistent!

    Yeah, the bubbles tell me what I have or haven't seen. If they left the titles as default links it might have bothered me, but since they changed them already it just made things look discoursistent for no obvious reason.


  • SockDev

    exactly why it bothered me!

    the bubbles told me where to go.



  • I have a tab open for the topic list, and open topics from it in new tabs. The change of colour helped me see which I'd opened and which I hadn't without the bother of actually remembering.

    I'm aware this is Doing It Wrong™ but meh.


  • Discourse touched me in a no-no place

    @loopback0 said:

    I'd CSS it back locally if I could figure out the right values.

    Removed lines:

    Desktop:

    .topic-list {
    a.title:visited:not(.badge-notification) {color: scale-color($primary, $lightness: 50%); }
    }
    .topic-list.categories {
    a.title:visited:not(.badge-notification) {color: scale-color($tertiary, $lightness: 35%);}
    }

    Mobile

    .topic-list {
    a.title:visited:not(.badge-notification) {color: scale-color($primary, $lightness: 35%);}
    }

    ./app/assets/stylesheets/common/foundation/colors.scss:1:$primary:           #222222 !default;
    ./app/assets/stylesheets/common/foundation/colors.scss:3:$tertiary:          #0088cc !default;
    


  • Sweet thanks, it was the value for $primary and $tertiary I couldn't work out.



  • @loopback0 said:

    I have a tab open for the topic list, and open topics from it in new tabs. The change of colour helped me see which I'd opened and which I hadn't without the bother of actually remembering.

    I'm aware this is Doing It Wrong™ but meh.

    That's exactly what I do. Additionally, this bug (IMO) actually caused me to miss this topic.


  • mod

    I vote with @loopback0.


  • Banned

    I think there is a way strong argument here for keeping the blue/grey circles up-to-date, we already have the information. I get that in a tabbed workflow it can be handy.



  • @loopback0 said:

    I WANT IT BACK.

    Fuck you Dischorse, that is descriptive.

    Hang on, are you saying they fixed the bug where some topic titles were rendering in a lighter colour for no apparent reason? Why do you want that back? :/


  • mod

    Because it wasn't a bug. It was actually useful information.

    And it wasn't "no apparent reason". It was indicating the links you had followed.



  • Actually, this reminds me of something I've been wanting to make but haven't gotten around to trying:

    @Monarch, you've done some ui stuff here, right? Have you been looking for another project?



  • @abarker said:

    Because it wasn't a big bug. It was actually useful information.

    And it wasn't "no apparent reason". It was indicating the links you had followed.

    Hmm. It seemed to me there'd be topic titles in either colour, regardless of the number of grey or blue numbers following them. I was never able to discern anything useful from it anyway, so if it's gone it's one less minor irritation to deal with...


  • BINNED

    I think they changed on any updates to the topic as well. I had that "X topics changed" bar show up, I'd click it and a topic I am tracking would jump to the top and go black, but there were no bubbles next to it, and indeed no new posts.

    I always buttumed that happens when someone edits their post or somesuch.



  • Or when you read the last post, but hadn't had it at the top of your screen. Or when you read the last post but did not have URL updating enabled.



  • @abarker said:

    And it wasn't "no apparent reason". It was indicating the links you had followed.

    But it was inconsistent, because unless they're in the New category, they should have all been things I'd been to.

    I guess it's our topic changing that fucks that shit up and makes it look wrong. But again, the bubbles tell me whether there's anything interesting.


  • mod

    @boomzilla said:

    But it was inconsistent, because unless they're in the New category, they should have all been things I'd been to.

    No, because each unread link is different, thanks to the post number at the end. For example:

    At the start of the day you have 20 unread post in t\1000. You start at post 36458. The URL when you enter at that time is http://what.thedailywtf.com/t/{current likes title}/1000/36458. Later in the day, additional posts are added. However, because of the post offset, the URL in the Unread list is now http://what.thedailywtf.com/t/{current likes title}/1000/36478. Because of the change in the post number portion of the URL, the browser considers the link to be not followed until you click on it. If the title changes during that period as well, there are two reasons for the browser to consider it a new URL.

    @boomzilla said:

    But again, the bubbles tell me whether there's anything interesting.

    Not if you use the multi-tab browsing approach.


  • Banned

    @abarker said:

    Not if you use the multi-tab browsing approach.

    which is what I am totally open to, keeping the bubbles up to date ... we have all the info.


  • mod

    I'd still like to see the links that I've followed on the unread and new tabs grayed out so I don't have to refresh the page every time I go back there.



  • @abarker said:

    I'd still like to see the links that I've followed on the unread and new tabs grayed out so I don't have to refresh the page every time I go back there.

    This. Still need to work out the CSS.



  • .topic-list a.title:visited:not(.badge-notification) {
      color: #919191;
    }
    
    .topic-list.categories a.title:visited:not(.badge-notification) {
      color: #38bdff;
    }
    

  • mod

    So much better!!!



  • @abarker said:

    Not if you use the multi-tab browsing approach.

    Eh...it can still work fine, so long as you aren't relying on stale suggested topic lists.


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.