The censor feature is discoursistent
-
The new censor feature is extremely discoursistent, just based on a few hours of testing done in the likes thread. A few noticeable bugs:
- Censoring is not applied to topic titles.
- Censoring is not always applied. Not sure why, since viewing the raw on these posts doesn't usually reveal any hidden entities.
- Generally, quoting a post that should have been censored will result in the quote being censored.
- Unrolling a quote with a censored word will remove the censoring.
- Sometimes the censoring of a post will change minutes or hours after posting (censoring will be added or removed).
- And more that I just don't feel like listing.
It looks like "Belgium" was added to the censoring list about here
@Sam, @CodingHorror: If you're listening, get a QA team!!! The censor feature was not ready to be released. The items I mentioned above are the types of things that are easy to miss if the developer is the only one doing the testing, but they are hard to get past a decent QA team.
-
*ahem*
- belgium
- Belgium
- BELGIUM
- "belgium"
belgium belgium [spoiler]belgium[/spoiler]
http://what.thedailywtf.com/t/belgium/1000
-
*ahem*
- belgium
- Belgium
- BELGIUM
- "belgium"
belgium belgium [spoiler]belgium[/spoiler]
http://what.thedailywtf.com/t/belgium/1000
Preview while editing:
Yeah, that censor feature works great
-
If a mention contains the word it shows censored in the preview but not (always) in the post.
-
If a mention contains the word it shows censored in the preview but not (always) in the post.
Clearly the civilized thing to do is realize a word is supposed to be censored and then not use it.
-
The new censor feature is extremely discoursistent,
understatement
just based on a few
hoursminutes of testing
-
To be fair, I was basing the time frame on when "Belgium"1 was added to the prohibited list and when this bug topic was created. That gives us about 3 discohours. So:
based on a few discohours
1 I am choosing to rely on the censor here. Probably a bad idea, but oh well.
-
Testing a theory:
belgium
Belgium
BELGIUMa belgium
a Belgium
a BELGIUMbelgium c
Belgium c
BELGIUM ca belgium c
a Belgium c
a BELGIUM c
-
So much for that ...
There is officially no consistency to the censor.
Raw of previous post here, if anyone cares.
-
Not sure if it’s always the case, but the censoring seems not to be applied in the edit panel when doing a full quote. That feels wrong.
Also, it’s applied live in the preview pane, so you can check in real time if your post will be censored or not, and try some workarouds. It would make more sense to always show the current user’s posts without any censoring, IMHO.
-
Not sure if it’s always the case, but the censoring seems not to be applied in the edit panel when doing a full quote.
Sometimes it is. See the screen cap of my full quote of @aliceif in post 3 of this topic.
Also, it’s applied live in the preview pane, so you can check in real time if your post will be censored or not, and try some workarouds. It would make more sense to always show the current user’s posts without any censoring, IMHO.
That's a good point. There are two ways to look at this:
- Actively censor while editing to warn the user. A good user will catch the warning and rethink their wording. A bad user will do as you said and abuse this feature to find a workaround.
- Don't actively censor while editing. Only censor the baked posts. This way, the bad user will have a harder time finding workarounds, and the good user will hopefully keep this in mind for next time.
Option 2 is probably the safer way to go.
-
And then don't censor the post when showing it to the original author, because letting him know about any moderation action is anathema.
-
I'm pretty sure Discourse either censor for all or none. Take my test post above, all twelve instances of B******m are censored for me by Discourse. In @aliceif's post, however, nothing is censored. There just isn't any consistency.
Wait. No. It can't be that ...
@aliceif's post has some markdown. My test post doesn't have any. Could the presence of markdown in a post be preventing the censoring? It isn't the bbcode, since we've seen some posts with censoring inside spoiler tags, and even in quotes.
-
Test Post A (No markdown)
Belgium
EDIT: FAIL
EDIT 2: SUCCESS AFTER FIRST EDIT (WTF?!)
-
But unfail when you added your edit.
-
belgium
-
I give up trying to decipher this bug. They should just pull the feature. It is so broken, it's making Red Hulk mad.
-
So, at this point, what, censoring works (in posts) except where Markdown is
involvedpresent? EDIT: No? I removed the Markdown and it kept the post uncensored for me. EDIT 2: But that edit did censor them? WTF. EDIT 3: Seriously, WTF, it just went back to uncensored after the edit.Belgium - plain text
Belgium - Markdown
[i]Belgium[/i] - BBCode
Belgium - HTMLAnd a belgium for good measure.
-
I'm pretty sure Discourse either censor for all or none.
Yes, there's only one baked version. I was just demonstrating some more JDGI.
-
belgium
- belgium *
belgium
_ belgium _
edit- Preview matches the post!
edit[2] - WELL IT BLOODY DID!
This is retarded.
- belgium *
-
Jesus...
-
-
-
belgium* belgium *belgium_ belgium _
belgium
- belgium *
belgium
_ belgium _
I don’t get it. I only see my posts as censored. Even with the same raw content as another post. WTF?!
- belgium *
-
So, at this point, what, censoring works (in posts) except where Markdown is involved present?
No, that was a
theoryhypothesis I had, but it didn't pan out. It is just truly discoursistent. So much so that even a simple edit of a couple words can change the censoring on your post (as you've seen).
-
Showing censored here.
-
-
No, that was a
theoryhypothesis I had, but it didn't pan out.Never hurts for someone else to try to see if they can find a source.
As far as I can see, though, there seems to be some odd combination that breaks it from censoring sometimes, except not on the preview pane, which works a lot more like you'd expect.
-
I was 100% sure there was no such censoring feature and you guys were screwing around (ala hunter2) until about halfway down this thread. It's the only sane explanation.
Belgium
(censored in preview, censored for 3/4 a second after posting, then uncensored immediately. Censored after edit. Uncensored after edit. Another edit returns to previous flashing behavior.)
-
I don’t get it. I only see my posts as censored. Even with the same raw content as another post. WTF?!
Here's some fun. When I rebake your post, censoring goes away. Rebake again, censoring is back.
-
It's like there's a little man behind the curtain doing it all and he's just a bit overwhelmed and can't always keep up with the requests.
-
belgium
belgium
belgium
-
It's like there's a little man behind the curtain doing it all and he's just a bit overwhelmed and can't always keep up with the requests.
Or @PJH is sitting there turning it off and on randomly to fuck with us.
-
censored for 3/4 a second after posting, then uncensored immediately
The 3/4 second is the local rendering before the server returns the "official" baked version of your post. Basically, you're seeing what was in your preview pane.
-
Stuff be crazy...
https://meta.discourse.org/t/how-is-word-censoring-supposed-to-work/21879?u=boomzilla
NB, original title was: How is word censoring supposed to work?
I assume that will get edited at meta.d.
-
I wonder if this has anything to do with it:
Has @PJH done a restart after adding the word?
-
Has @PJH done a restart after adding the word?
No, but not for lack of trying:
http://what.thedailywtf.com/t/docker-upgrades/1929/84?u=boomzilla
-
Thankfully, the laugh I accidentally let out sounded evil enough that my coworkers won't bug me to see what's so funny.
I love discourse. It brings new meaning to the word "cluster-belgium".
-
FWIW, I see your post as censored, your quote of loopback0 as censored1, and loopback's original as uncensored.
1 Well, three out of the four belgiums are censored.
-
FWIW, I see your post as censored, your quote of loopback0 as censored1, and loopback's original as uncensored.
Haha...I just rebaked it. No more censoring (though you describe what I saw before that).
-
I was 100% sure there was no such censoring feature and you guys were screwing around (ala hunter2) until about halfway down this thread. It's the only sane explanation.
I thought the same thing, and I'm still not sure. Seems half the instances of belgium are censored and the other half are not. How do you even write code that does that?
-
Discourse i love you
because you would rather black the name of
paging than enquire whose Android hasn't been
upgraded which would be embarassing for
bothparties and because you
unflinchingly insist that
infiniscroll is made of rainbows and
unicornsDiscourse i love you because
when you're hard up you pawn CPU
cycles to buy new shinies and when
you're flush you blameGoogle and because you are continually committing
nuisences but more
especially in TDWTFDiscourse i love you because you
are perpetually putting good
user experience in your pants and forgetting
it's there and sitting downon it
and because you are
forever making new bugs
Discoursei hate you
-
+42 (and bookmarked)
Would read again.
-
Or @PJH is sitting there turning it off and on randomly to fuck with us.
Amusing though the conceit may be, I really have better things to be doing than rolling 1d6 and changing it when <=4....
Has @PJH done a restart after adding the word?
There are two words there. Both may or may not be masked depending on.. whatever.
No, but not for lack of trying:
It's still like that >7 hrs later...
-
Discourse poetry thread? I'd like to see a blank verse version. Or rhymed couplets. Or a sonnet.
-
Amusing though the conceit may be, I really have better things to be doing than rolling 1d6
@sockbot 1d6
-
Rolling 1d6: 3
-
Amusing though the conceit may be, I really have better things to be doing than rolling 1d6 and changing it when <=4....
I suspect that you meant concept there.
-
I really don't care for this feature, never did, nor did anyone on the team. We did it to appease a customer.
Here is probably the last place I would expect anyone to care about this feature.
Getting this feature working "perfectly" is probably a month of engineering work. (deal with permutations, maybe dash in a bit of OCR, while at it, let's automatically blur pictures of body parts).
Spending a month to on a feature that one paying customer is using and has not even complained about yet seems a tad on the, "wait a moment Sam, your priority list is insane" bucket.
Appreciate the bug reports though, even though pretty much all the bugs in the censor feature are at the back of line.
Filed under: fixing up the upgrade button so PJH can upgrade again
-
We did it to appease a customer.
Sometimes you just have to tell a customer, "Your request is stupid." Maybe phrase it more politely; maybe not.