Sites where our embed box needs to be fixed
-
-
Medium:
-
Facebook (no screenshot
-
whatever that (news?) site was from a few days ago that auto played a loud video ad
BONUS: The Reddit embed box is perfect
- shows a preview of whatever, and it's not cut off
- playback controls are there
- if it's a video, it doesn't play sound by default (IIRC)
- the links all go where they're supposed to, and they all fit inside the embed box
- looks nice without any weird CSS issues
e: although, even for Reddit maybe some kind of "click to play" feature that wouldn't automatically run whatever Javascript Reddit wants to present us with might be an improvement
-
-
@hungrier Except Reddit's embed has a set foreground color (black) but no set background color (transparent), so I get a fun black-on-black experience.
-
@TwelveBaud Oh yeah, I always forget I have this custom CSS:
.embedly-card { background-color: #ddd; }
-
We do have some CSS customizations to iFramely. Take a look here: https://github.com/boomzillawtf/tdwtf/blob/master/plugins/nodebb-plugin-tdwtf-customizations/iframely.less
We also patch up iFramely on deploy to fix up dates (probably unrelated to this stuff): https://github.com/boomzillawtf/tdwtf/blob/master/iframely-date.diff
-
@hungrier said in Sites where our embed box needs to be fixed:
whatever that (news?) site was from a few days ago that auto played a loud video
I believe it was zdnet.com.
-
Also:
GitHub - itteco/iframely: oEmbed proxy. Supports over 1800 domains via custom parsers, oEmbed, Twitter Cards and Open Graph
oEmbed proxy. Supports over 1800 domains via custom parsers, oEmbed, Twitter Cards and Open Graph - itteco/iframely
GitHub - NodeBB-Community/nodebb-plugin-iframely: Iframely Embeds for NodeBB
Iframely Embeds for NodeBB. Contribute to NodeBB-Community/nodebb-plugin-iframely development by creating an account on GitHub.
-
@hungrier said in Sites where our embed box needs to be fixed:
shows a preview of whatever, and it's not cut off
playback controls are there
if it's a video, it doesn't play sound by default (IIRC)
Reddit embeds have the bottom cut off (including controls) after a certain height. It looks fine in that one because it's a landscape video. They also autoplay (which they shouldn't even do to begin with) with sound if you have previously unmuted any other reddit embed (it remembers your preference).
It's reddit's fault anyway. The metadata specifies the wrong height. I've actually contacted them twice about it but apparently they don't care if their stuff can be shared easily or not.
-
@anonymous234 said in Sites where our embed box needs to be fixed:
They also autoplay (which they shouldn't even do to begin with) with sound if you have previously unmuted any other reddit embed (it remembers your preference).
Yeah, fuck those embeds.
-
@anonymous234 said in Sites where our embed box needs to be fixed:
(it
remembers your preferenceisn't prevented by the browser anymore)
-
Can I point out one weird embed box? This text
https://www.gocomics.com/garfield/1995/12/05
Results in:
It's just the image and a link! Great for minimalism, but I think a little title or border to show that you can click on it to get to the context would be appreciated.
-
Yarn.co embeds seem to autoplay.
https://tv.getyarn.io/yarn-clip/ed170c95-b47f-4aaf-a60d-64b75d376ec2
-
@anonymous234 said in Sites where our embed box needs to be fixed:
Yarn.co embeds seem to autoplay.
With audio.
Yarn is very knotty.
-
@anonymous234 said in Sites where our embed box needs to be fixed:
Yarn.co embeds seem to autoplay.
https://tv.getyarn.io/yarn-clip/ed170c95-b47f-4aaf-a60d-64b75d376ec2But.... that's not how it's pronounced!
:zwj:
-
@loopback0 said in Sites where our embed box needs to be fixed:
@anonymous234 said in Sites where our embed box needs to be fixed:
They also autoplay (which they shouldn't even do to begin with) with sound if you have previously unmuted any other reddit embed (it remembers your preference).
Yeah, fuck those embeds.
Goddam PLEASE stop these autoplaying. I assume we're still interested in fixing stuff here.
-
@loopback0 said in Sites where our embed box needs to be fixed:
. I assume we're still interested in fixing stuff here.
No. It seems we're focusing on constructing civilized discourse.
-
@loopback0 said in Sites where our embed box needs to be fixed:
@loopback0 said in Sites where our embed box needs to be fixed:
@anonymous234 said in Sites where our embed box needs to be fixed:
They also autoplay (which they shouldn't even do to begin with) with sound if you have previously unmuted any other reddit embed (it remembers your preference).
Yeah, fuck those embeds.
Goddam PLEASE stop these autoplaying. I assume we're still interested in fixing stuff here.
Yeah, 90% of the time the Reddit posts aren't even worth embedding because most of the fun is in the comments. Just a plain link would save a bunch of frustration.
-
Must be a dark theme problem.
-
@topspin said in Sites where our embed box needs to be fixed:
Must be a dark theme problem.
I don't use dark theme here, as they're all shit.
-
Can somebody block ZDNet?
Their onebox starts autoplaying and causes jellypotato by trying to scroll the content into view. If you then have the misfortune of living in Europe you get a GDPR consent screen which even blocks said content.
This is bad and they should feel bad.
-
@JBert Why doesn't the embed box block Javascript by default, with a whitelist or click-to-activate?
-
@hungrier because nobody thought anyone would abuse it in this specific way?
inb4 <del>
