Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read
-
I'm sure it was already reported, but just in case, reporting it again.
-
@gąska said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
it was already reported
Yep
-
Clicking the notification toaster has never cleared the notification. Except now, just entering the thread clears all of the notifications from it, if the thread has unread posts, so there's that...
-
@anotherusername not if I enter the topic through toaster.
-
@gąska the clearing notifications behavior that I'm talking about happens if the topic has unread posts, regardless of how you enter the topic.
-
@anotherusername said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
Clicking the notification toaster has never cleared the notification. Except now, just entering the thread clears all of the notifications from it, if the thread has unread posts, so there's that..
I've had it work that if I use pagination it clears only the notifications from that page.
I think it clears notifications when it tries to read anything about the post.
-
Am I crazy or could all the notification bugs (not cleared when clicking the toaster, everything cleared when reading the topic but only sometimes, mention notifications cleared whenever you think about looking at the topic on a Thursday, etc) be fixed with something like this?
if (post.isInViewport()) { post.notifications.map(n => n.markRead()); }
-
@hungrier pull requests are appreciated
-
@anotherusername said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
@gąska the clearing notifications behavior that I'm talking about happens if the topic has unread posts, regardless of how you enter the topic.
Well, this clearing notifications behavior doesn't happen if I enter the topic through notification toaster.
-
-
@pie_flavor oh, sorry.
-
@gąska said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
@anotherusername said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
@gąska the clearing notifications behavior that I'm talking about happens if the topic has unread posts, regardless of how you enter the topic.
Well, this clearing notifications behavior doesn't happen if I enter the topic through notification toaster.
That's what you said last time. I understood you; I just don't think you're right.
-
@anotherusername are you saying I'm seeing things that aren't there?
-
Which toaster are you clicking... the desktop notification, or the in-page notification toaster?
Clicking the desktop notification, as far as I can tell, doesn't do anything other than giving focus to the tab. edit: which is hilarious, because in my experience, if the tab's not in focus you're probably not going to get notifications anyway.
-
@gąska I just tested clicking the in-page toaster. I had cleverly marked the topic unread beforehand, to trigger the automatic-notification-clearing behavior.
So when I got an upvote notification from that topic, I first clicked the desktop notification. Since I was already on the NodeBB tab, that did nothing perceptible, other than dismissing that toaster. I then clicked the in-page notification toaster, which loaded the topic, highlighted the post, and marked the notification read.
I'm saying that you're seeing behavior that only happens sometimes, and I don't think you've connected the "what" to the "when" or "why".
-
@anotherusername in-page. I'm not using desktop notifications.
Though I'm not sure if the topic was actually unread. I admit I didn't read your posts carefully and missed that detail.
-
@anotherusername I have experienced the exact opposite. The desktop toaster clears the notifications but the in-site toaster doesn't.
-
@pie_flavor Does the desktop notification toaster actually do something when you click on it? In Chrome or something? Because it doesn't do much for me on Firefox...
edit: omg they do work in Chrome. So I guess they're broken in Firefox.
-
@julianlam clicking a desktop notification doesn't do anything in Firefox. Apparently it should take me to the post? At least, it did in Chrome.
-
@anotherusername said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
Which toaster are you clicking... the desktop notification, or the in-page notification toaster?
Clicking the desktop notification, as far as I can tell, doesn't do anything other than giving focus to the tab. edit: which is hilarious, because in my experience, if the tab's not in focus you're probably not going to get notifications anyway.
My experience is the reverse: The desktop notification navigates the page, but does not foxus the tab.
-
@tsaukpaetra said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
foxus
-
@pie_flavor I guess it's a good thing that it doesn't do it?
-
@gąska Yeah, I thought we banned him.
-
I think you guys don't have this yet, but it should fix the issue https://github.com/NodeBB/NodeBB/issues/6450
-
@barisu said in Topics are free and easier than bug tracker! Also, clicking notification toaster doesn't mark notification as read:
I think you guys don't have this yet
Correct, we're currently on 1.9.3 (issue is marked as fixed in 1.9.4 / 1.10.0).
