Guess that topic owner!
-
@ben_lubar he's saying that select-to-quote has a bug. Because that's the reason that happened.
-
@ben_lubar said in Guess that topic owner!:
@Lorne-Kates are you saying I should disable select-to-quote? Because that's the reason that happened.
I think he's saying the unclosed
<a>
should stay within the quoted post
-
@ben_lubar said in Guess that topic owner!:
disable select-to-quote?
Since its not getting the actual raw for the selection, I would say that needs to be fixed first. If it worked properly (which would probably also fix emoji not coming through as well), the problem would be much more difficult to encounter.
-
@sloosecannon said in Guess that topic owner!:
I think he's saying the unclosed
<a>
should stay within the quoted postWhat unclosed
<a>
? There isn't one in the post he quoted.@Tsaukpaetra said in Guess that topic owner!:
If it worked properly (which would probably also fix emoji not coming through as well), the problem would be much more difficult to encounter.
If it worked properly, it'd know that if it's not getting the raw and the text content contains
<
or>
, they need to be HTML-encoded as<
and>
. FFS.
-
@anotherusername said in Guess that topic owner!:
it'd know that if it's not getting the raw and when the text content contains < or >, they need to be HTML-encoded properly, as < and >. FFS.
That's hella more complicated than if it just used raw...
-
@Tsaukpaetra it's really not more complicated. Just get the text contents of the selection, which it already does, and then escape the HTML entities, which is ridiculously easy. If it used the raw, it'd need to figure out which part of the raw the highlighted text corresponds to, and that could be tricky. Especially when things like oneboxes come into play.
-
@sloosecannon said in Guess that topic owner!:
@ben_lubar said in Guess that topic owner!:
@Lorne-Kates are you saying I should disable select-to-quote? Because that's the reason that happened.
I think he's saying the unclosed
<a>
should stay within the quoted postOr close the
<a>
in the original post.Or convert invalid tags (including unclosed ones that should be closed) to &html; entities < and >
-
@Matches said in Guess that topic owner!:
re @cartman82
What's your excuse for this? Plenty of screen real estate hereNo excuse. They should add "by XXX" after the ago date string.
-
@Lorne-Kates said in Guess that topic owner!:
OH COME THE FUCK ON @ben_lubar
an unclosed tag in a quote:
fucks up the post:
I assume you meant to post;
-
-
@Lorne-Kates or escape the highlighted text correctly when quoting it.
Seriously. That's the correct way to do this.