Discussion of NodeBB Updates
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar Oh, shit! I didn't realize there was a difference!
Disc-hooverability!
-
@perverted_vixen said in Discussion of NodeBB Updates:
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar Oh, shit! I didn't realize there was a difference!
Disc-hooverability!
It's because the built-in thing doesn't have an edit count and my plugin was written before the edit icon was clickable.
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar Oh, shit! I didn't realize there was a difference!
It does seem there's a difference clicking the pencil vs. the digit... also, that difference is 3px (</meme>, it's really 3px at my resolution). WHY.
-
@heterodox I assume that @ben_lubar attached his event to the container but @julianlam attached his event to the .
-
@polygeekery said in Discussion of NodeBB Updates:
@julianlam do it is all @ben_lubar's fault? I can believe that.
Turns out it was my fault
-
Still busted.
https://i.imgur.com/U3of4lK.png
-
-
@ben_lubar said in NodeBB Updates:
I'm seeing both versions of the code there now?
Basically, everything above line 93 needs to be deleted.
-
@ben_lubar said in NodeBB Updates:
per @Erufael's discovery, it looks like
.details
is already being used.I guess doing a global replace of
.details
with[component="post/content"] .details
in the shim's CSS would probably be the simplest fix?
-
@ben_lubar said in Discussion of NodeBB Updates:
fa
-commenting-of
ae-commenting-o= Ugly
fdaaaaaaaay-commenting-o
-
@ben_lubar said in NodeBB Updates:
NodeBB 1.9.0
- Attachments now have THE RIGHT TO BE FORGOTTEN under European Union regulation.
- Moderators will no longer get a notification that they reported a post.
- Closed bugs
- Blog post
- Brag post
When I visit /me/uploads, it says:
Uploads are public, all visitors can see them.
However, trying to access /user/anotherusername/uploads as a visitor requests that I log in, and if I log in as a sock, I get an "access denied" error. This makes the message confusing. Is it supposed to mean that anyone with a link to an attachment can see it? That seems rather... obvious.
Although, adding category information to attachments wouldn't be a terrible idea, since then you could restrict access based on the category -- so, say, images that were originally uploaded in the Lounge would only be visible to users with Lounge access, even if they had the URL.
-
@anotherusername said in Discussion of NodeBB Updates:
When I visit /me/uploads, it says:
It still only shows about 10 uploads for me, when I have hundreds or thousands of files I've uploaded to this server. (If there's supposed to be a pager, it ain't working.)
Per usual, they didn't bother actually testing the shit.
-
@blakeyrat said in Discussion of NodeBB Updates:
@anotherusername said in Discussion of NodeBB Updates:
When I visit /me/uploads, it says:
It still only shows about 10 uploads for me, when I have hundreds or thousands of files I've uploaded to this server.
Per usual, they didn't bother actually testing the shit.
I was wondering about this also, but I assume they only track uploads that were uploaded after they started tracking who uploaded the file.
Seems really odd if there's no way of knowing who uploaded a file, though... say someone registered, uploaded naughty stuff (let's say it's child porn), and didn't actually post it, but shared direct links to the images hosted on WTDWTF's server. Would admins be able to determine which user had uploaded them? Surely they would...
-
@anotherusername said in Discussion of NodeBB Updates:
I was wondering about this also, but I assume they only track uploads that were uploaded after they started tracking who uploaded the file.
It didn't even occur to me that they would have half-assed it in that way. I just assumed it was broken. Jesus.
-
@ben_lubar said in NodeBB Updates:
@cvi said in Apple uses cray X-MP and Unix to design your next Macintosh:
Feature request: necro-toasters before OP when relevant:
Ah, good. Will this hit the guys who don't set their date and you get the start of the epoch?
-
@boomzilla said in Discussion of NodeBB Updates:
@ben_lubar said in NodeBB Updates:
@cvi said in Apple uses cray X-MP and Unix to design your next Macintosh:
Feature request: necro-toasters before OP when relevant:
Ah, good. Will this hit the guys who don't set their date and you get the start of the epoch?
It'll hit any OP that is just a single iframely link with a date associated with it.
-
@ben_lubar said in NodeBB Updates:
@cvi said in Apple uses cray X-MP and Unix to design your next Macintosh:
Feature request: necro-toasters before OP when relevant:
Awesome!
Edit: It even seems to round better than my original disco-truncation.
-
Ben do you know when NodeBB is going to fix the thing with deleting file uploads, so it shows all of them instead of just the last few?
Is that on their radar?
What about the fix we discussed where it'd automatically delete files if they aren't referenced from any posts, to help people dispose of accidentally-uploaded files?
-
Also pertaining to uploads, I think it'd be helpful if you could search for posts which included an upload. Maybe in the list of uploads, put next to each upload the number of posts that refer to it, and a icon that you can click on to see the list of posts?
-
@blakeyrat said in Discussion of NodeBB Updates:
Ben do you know when NodeBB is going to fix the thing with deleting file uploads, so it shows all of them instead of just the last few?
Interestingly (?) you can add
?page=x
and see more than the first page of results. Weird that it doesn't already infiniscroll or have a pager.
-
@boomzilla mine has a pager. Maybe you should turn on pagination.
-
@anotherusername said in Discussion of NodeBB Updates:
Maybe you should turn on pagination.
That doesn't sound like a good idea.
-
@anotherusername but for infini-plebs it just doesn't do anything. A+ list design
-
@hungrier is it even possible to scroll the list? If the whole first page fits on the screen without scrolling, infiniscroll might not know to load more...
-
@anotherusername said in Discussion of NodeBB Updates:
@boomzilla mine has a pager. Maybe you should turn on pagination.
It does, but it doesn't look like it shows all my uploads. Only two pages. I have uploaded the "Also, Yes" meme more than that.
-
@anotherusername I actually just checked mine, and I have enough for it to be scrollable, but apparently not enough for more than one page. Adding
?page=2
returns "No uploads found"
-
@polygeekery that's already been discussed... I don't think it has any way of connecting old (before the update) uploads to you, and we've already had a blakeyrant on how awful and broken that is. I think there surely must be some way of determining who uploaded all of the existing uploads...
-
@hungrier Mine goes to page 4, which has a single entry. So I presume that it only has the stuff that you uploaded since the feature was added. I remember uploading this not too long ago:
I think I was asking what a "slack bouncer" was, or something.
-
@anotherusername said in Discussion of NodeBB Updates:
I think there surely must be some way of determining who uploaded all of the existing uploads...
In theory you could go through all of the posts on the site and connect the earliest post with a particular upload to that user.
-
@blakeyrat said in Discussion of NodeBB Updates:
What about the fix we discussed where it'd automatically delete files if they aren't referenced from any posts, to help people dispose of accidentally-uploaded files?
@ben_lubar this should also determine whether they're referenced from signatures (e.g. mine) or chats (assuming it's still possible to embed images in chats... it is, right?).
-
@boomzilla said in Discussion of NodeBB Updates:
@anotherusername said in Discussion of NodeBB Updates:
I think there surely must be some way of determining who uploaded all of the existing uploads...
In theory you could go through all of the posts on the site and connect the earliest post with a particular upload to that user.
Yeah, that would probably be worst-case scenario since it'd require a full scan of every post made before the update.
-
@anotherusername what if I upload a file here and then post a link to it in the front page comments or on the Discord server or in IRC? How would NodeBB know?
-
@boomzilla Makes sense. I know I've uploaded a lot more than the 25 or however many items that show up in my list.
-
@hungrier said in Discussion of NodeBB Updates:
@anotherusername but for infini-plebs it just doesn't do anything. A+ list design
Fixed in version nine-eleven
-
@ben_lubar said in Discussion of NodeBB Updates:
@anotherusername what if I upload a file here and then post a link to it in the front page comments or on the Discord server or in IRC? How would NodeBB know?
Should that be allowed?
The Discord/IRC thing would be simple enough... it could just ignore files that were less than a week old or something. A week later, nobody will care that it's gone.
If you posted it in the front page comments, then about the only way to have NodeBB detect this is to log
referer
for the requests and create a whitelist of domains where it's allowed to be posted (and won't be deleted).
-
@ben_lubar There's also the Spongebob font that someone had uploaded as an attachment, which probably isn't linked in any post unless plain-text (i.e. the css that uses it) counts.
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar said in Discussion of NodeBB Updates:
@anotherusername what if I upload a file here and then post a link to it in the front page comments or on the Discord server or in IRC? How would NodeBB know?
Should that be allowed?
The Discord/IRC thing would be simple enough... it could just ignore files that were less than a week old or something.
If you posted it in the front page comments, then about the only way to have NodeBB detect this is to log
referer
for the requests and create a whitelist of domains where it's allowed to be posted (and won't be deleted).Disk space is not an issue. The thing we're trying to solve is how to figure out who uploaded a file so they can have control over deleting it.
-
@ben_lubar unless that was logged somewhere, the only way to tell would be to check all posts, signatures, and chat messages to see who linked to it first.
Also, users' custom CSS.
-
@anotherusername said in Discussion of NodeBB Updates:
and we've already had a blakeyrant on how awful and broken that is. I think there surely must be some way of determining who uploaded all of the existing uploads...
It's not just a "blakeyrant", the entire point of the feature is to help them be GDPR compliant and with the current implementation they aren't.
-
@anotherusername said in Discussion of NodeBB Updates:
Yeah, that would probably be worst-case scenario since it'd require a full scan of every post made before the update.
It's not our fault that they're really shitty at designing databases. They made the bed, now they have to lie in it.
-
@ben_lubar said in Discussion of NodeBB Updates:
what if I upload a file here and then post a link to it in the front page comments or on the Discord server or in IRC? How would NodeBB know?
Ben as we discussed in Discord, the answer is: who cares, DailyWTF is not a free web hosting service for anybody to use, tough luck.
-
@blakeyrat said in Discussion of NodeBB Updates:
@anotherusername said in Discussion of NodeBB Updates:
and we've already had a blakeyrant on how awful and broken that is. I think there surely must be some way of determining who uploaded all of the existing uploads...
It's not just a "blakeyrant", the entire point of the feature is to help them be GDPR compliant and with the current implementation they aren't.
That's not completely true. If a site wasn't using NodeBB because NodeBB wasn't compliant, then yes, it's compliant now, so they could start using it. But if they were already using NodeBB when it wasn't compliant, then no, the update hasn't changed much of anything regarding files that had been uploaded while NodeBB wasn't compliant.
-
@anotherusername Well fine ok whatever, but I'd still like to delete all the files I've accidentally uploaded over the years. If NodeBB were smart enough to delete files that weren't referenced from anywhere (which, BTW, I just assumed it was because I'm fucking stupid and I assume software isn't written by morons and I'm always disappointed), than this would be a non-issue.
-
@blakeyrat said in Discussion of NodeBB Updates:
@anotherusername Well fine ok whatever, but I'd still like to delete all the files I've accidentally uploaded over the years. If NodeBB were smart enough to delete files that weren't referenced from anywhere (which, BTW, I just assumed it was because I'm fucking stupid and I assume software isn't written by morons and I'm always disappointed), than this would be a non-issue.
Assuming for the sake of argument that you have "accidentally" uploaded lots of files over the years... if they're not referenced from anywhere, what's the problem really? Either you trust Ben enough to not go trolling through the thousands and thousands of uploaded files, and it's really a complete non-issue, or you don't trust him, but then how do you know he hasn't already made backup copies of your more interesting stuff if you try to delete it?
Don't get me wrong, it'd be a nice feature, but it'd be more for feels than for real privacy. I think that it gives the illusion of privacy without really guaranteeing much of anything...
-
@anotherusername said in Discussion of NodeBB Updates:
but then how do you know he hasn't already made backup copies of your more interesting stuff if you try to delete it?
I do have backups of the uploads folder and the forum database.
-
@ben_lubar Yes, but do you have a script that does a diff to show files of interest in the backup that blakey has since deleted on the live server?
(so that you can delete them from the backup, obviously, totally without looking at them first...)
-
@anotherusername said in Discussion of NodeBB Updates:
@ben_lubar Yes, but do you have a script that does a diff to show files of interest in the backup that blakey has since deleted on the live server?
(so that you can delete them from the backup, obviously, totally without looking at them first...)
No, but I download the uploaded files using
rsync
, so there's probably some switch I can add to the command to do that.
-
@anotherusername said in Discussion of NodeBB Updates:
Assuming for the sake of argument that you have "accidentally" uploaded lots of files over the years... if they're not referenced from anywhere, what's the problem really?
For all I know there's passwords in there.
Look, it's simple: this topic discusses NodeBB updates. NodeBB added a feature that's really half-assed, and I'm just asking "hey when do we get the full ass here?" That's it. Ok?
Call me crazy, but I think if developers release shitty obviously-unfinished crap features they should be called out on it. It's called "giving a shit about the quality of the software". And I'm not going to apologize for wanting better software.
-
@blakeyrat said in Discussion of NodeBB Updates:
I'm just asking "hey when do we get the full ass here?"
Currently debugging https://github.com/NodeBB/NodeBB/blob/master/src/upgrades/1.9.0/refresh_post_upload_associations.js with the NodeBB devs in Slack.
-
@ben_lubar Thank you, that makes me feel a lot better.
Maybe you should take a quick break to tell them, "hey if you hadn't half-assed your dumb database design, you dumbshits, you wouldn't have to do this shit now."