Notification enhancements
-
So, I've turned this into a plugin:
npm: https://www.npmjs.com/package/nodebb-plugin-upvote-notifications
github: https://github.com/boomzillawtf/nodebb-plugin-upvote-notifications
-
I found an issue here with the way the plugin gets implemented. Notifications fire on a second delay. When I implemented this as part of NodeBB, I did filtering before that delay happened. But the plugin happens after the delay. That means that if, say, you're interested in only being notified for the first upvote, you don't get any, because the plugin checks the number of upvotes on the post when the notification fires, and there's more than one.
-
@ben_lubar said in Notification enhancements:
why do you have NodeBB plugins installed globally?
Here's a question for your question: if that's a wrong "whaaaa"-worthy thing to do, why does it let him?
Is the answer "because it's shitty and broken?" I bet it is.
-
-
@boomzilla said in Notification enhancements:
@blakeyrat said in Notification enhancements:
I bet it is.
How much did you lose on that bet?
I for one would never make that bet with @blakeyrat unless we decided beforehand whose definition of "shitty and broken" to use and it wasn't @blakeyrat's definition of it.
-
@boomzilla said in Notification enhancements:
So, I've turned this into a plugin:
npm: https://www.npmjs.com/package/nodebb-plugin-upvote-notifications
github: https://github.com/boomzillawtf/nodebb-plugin-upvote-notifications
I did some more work on this and figured out how run integration tests between a plugin and nodebb (which was how I realized there was a problem with the delay). It's not too difficult, though it requires that you do things in a certain way in order to handle the differences between running under a normal nodebb and in a testing environment.
Has anyone else had a chance to try it out locally? You should be able to download it directly from the admin console if you're so inclined.
Man, I'm looking forward to getting this running so I'm less aware of @obeselymorbid's catch-up reading.
-
@boomzilla said in Notification enhancements:
@obeselymorbid's catch-up reading.
Yeah, some people and their liking things....
-
@boomzilla said in Notification enhancements:
I'm less aware of @obeselymorbid's catch-up reading.
Have a couple upvote notifications in this thread - it's your own fault for summoning me here.
On a more serious note I, too, would welcome enhanced settings for notifications.
-
@obeselymorbid v0.1.2 activated!
You should see this on your Settings page:
-
@boomzilla Awesome! I think I'll go with 1st, 5th etc. for now. Since we don't have badges anymore, this will strike the best balance between notification spam and stroking my ego with new likes.
-
@obeselymorbid Me, too.
-
Thank you, @boomzilla !
-
Yeah, that's pretty cool.
-
@boomzilla now I completely disabled upvote notifications, it would be useful if votes showed when I see my posts in my profile page
-
@fbmac said in Notification enhancements:
useful if votes showed when I see my posts in my profile page
Something like this?
But that would make it so much easier for someone with a chip on their shoulder to just downvote all your posts down the line...
-
@Tsaukpaetra that's not shown on mobile at least
the vote buttons shouldn't show on the profile for the reason you mentioned