Highlighting for Quote Reply merges text into single lines
-
Seen in The Funny Stuff Thread:
When attempting to highlight text to do a quote reply, if the quoted text is not
a plain text link followed by plain textseparated by more than one line of whitespace, the "Quote Reply" button will merge the two lines into one, and include the first word of the second line as part of the link, breaking it.Example:
http://www.simuwelt.de/rondomedia/gleisbau-simulator-2014.html
It's real!Raw of the above post:
http://www.simuwelt.de/rondomedia/gleisbau-simulator-2014.html It's real!
Post quoting original post:
@FrostCat said:@aliceif said:
http://www.simuwelt.de/rondomedia/gleisbau-simulator-2014.htmlIt's real!
[snip]
Edit: Fixed title to be clearer, removed damn emoji from report, noted that bug affects all cases where two lines contain no white space between, not just link then text.
Repro:
Content immediately after a plain text URL
-
http://www.google.com/Content immediately after a plain text URL
Highlighted the text after "Repro" and hit "Quote Reply" (clicking the "Reply" button on the post with it highlighted also does it), got the above.
-
http://www.google.com/Content immediately after a plain text URL
that is the weakest XSS injection ever man
-
Also, it should work with any number of <br> tags... let's try
how could this ever end up on the same line, right?
-
http://www.google.com/how could this ever end up on the same line, right?
OOOOOOOOPS
-
<br> tags, yes, but more than one plain new line in the editor prevents it.
Looks like it's because it makes those distinct paragraphs, and the quote logic only breaks on the <p> tags when you highlight and quote reply.
-
OOOOOOOOPS
-
I think his problem is that if you don't extend the quotebox all linebreaks get ignored.
Filed Under: Counterpicture, Go!
-