Discourse/Main Site Test Plan

error

It's more customary to put the parens inside: (function() { }());

Really though, all that's necessary to ensure it's a function expression (instead of a function declaration) is a token before it.

So, just as valid: void function() {}(); or 0,function() {}();

ben_lubar

As long as we're returning an object, why not just

var Discourse = function(){ return ["forum", "pagination"] }()

error

@ben_lubar said:

As long as we're returning an object, why not just

var Discourse = function(){ return ["forum", "pagination"] }()
```</blockquote>
ASI makes Baby Jesus cry.

---
Filed under: [Markdown makes him weep blood.](#tag)

apapadimoulis

Wow! That's so awesome. Thanks.

Ok, I think I see how these plugins work. So you start with renderFeature to push a <button> html out, and then do a clickFeature gets attached to the thingy that was just rendered.

Seems pretty straight forward.

In the theme of keeping this as ghetto plug-in, I was thinking we could store the featured postIds as a CSV in the firstpost, like ARTICLE ID. Something like . It seems pretty straight-forward to read this out of the firstpost, but i'm wondering...

how to set a class on a post? (so we can indicate which posts are featured)
how to edit of the first post? is it like, firstPost.set('cooked', '????')

On an unrelated note, I have a hard time seeing fa-paper-plane as anything but fapper-plane.

error

@apapadimoulis said:

I have a hard time seeing fa-paper-plane as anything but fapper-plane

Rule 34

error

@apapadimoulis said:

In the theme of keeping this as ghetto plug-in, I was thinking we could store the featured postIds as a CSV in the firstpost, like ARTICLE ID. Something like

If this isn't setting off your WTFometer, perhaps yours is broken.

riking

@apapadimoulis said:

Ok, I think I see how these plugins work. So you start with renderFeature to push a <button> html out, and then do a clickFeature gets attached to the thingy that was just rendered.

Nope, that's not how "these plugins" work - that's how the particular class, PostMenuView, which we're modifing, works.

You basically have to read the JS file you want to change, and figure out how to inject your opinion on a case-by-case basis.

In this case, the post_menu SiteSetting gets split on |, then iterated, calling this["render" + typeWithFirstLetterCaps](post, buffer);. Then it sets up a click listener for the whole menu, and when something is clicked it gets the data-action from the element and calls the method in a similar fashion.

@apapadimoulis said:

In the theme of keeping this as ghetto plug-in, I was thinking we could store the featured postIds as a CSV in the firstpost, like ARTICLE ID.

Yeah, I'm with @error here - No, no, hell no.

Topics can have custom fields stored in the DB - https://github.com/discourse/discourse/pull/2297

However, this would involve setting up a Rails web endpoint. Are you up to that?

Just noticed that the paper airplane is in the newest version, which Discourse isn't using. I'll pick another one - inspect the change and update the plugin, if you already installed it.