Dear blakeyrat. I fixed the css. Signed The Desktop View
-
BTW, for the record, every reply in this thread with a quote sends a notification to me. Because "@blakeyrat" is in the title of the thread.
QUALITY SOFTWARE DEVELOPMENT.
-
@blakeyrat said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
BTW, for the record, every reply in this thread with a quote sends a notification to me. Because "@blakeyrat" is in the title of the thread.
QUALITY SOFTWARE DEVELOPMENT.
no repro
-
@RaceProUK said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
That would get the job done.
I basically went with that, plus swapped out
.container
for.container-fluid
. Otherwise it'll get stuck wider than the window, which is probably not what people want.@RaceProUK said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
I assume this'll be a user setting or something?
Per user per browser. I've stored the setting in local storage, because you may want different behavior on different devices. I added to the menus:
Obviously I'm calling it Desktop Mode for now. Haven't taken the next step to internationalize it yet. Hell, I haven't even made a readme yet. Hopefully we can get some @TDWTF-NodeBB-Development types to test it out a little bit:
-
@boomzilla Is it reversible? Lorne's script actually deletes those DOM nodes from memory, and AFAIK they can't be brought back short of a full refresh.
-
@blakeyrat It does a refresh whenever you pick a different mode, currently. And yes, it uses the same destructive technique that @Lorne-Kates used to modify the CSS.
I'm certainly open to people with ideas on how to do it differently, but I suspect the refresh isn't going to be a big deal. Aside from initial tests, I assume people will stick with it, not go back and forth a lot.
Initially, I only had a refresh when you went back to normal responsive mode, since the CSS needed to be restored. But without the refresh you needed to resize your browser if you were in the small / mobile mode and wanted to switch to desktop. Which I suppose you can't do at all for mobile. But the refresh handles that for you automatically.
-
@boomzilla Without buy-in from the NodeBB developers, it's probably the best we can do. The reversible method requires changes to their obfuscated CSS files.
-
@blakeyrat Given their response to this, I think we pretty much have to go plugin or custom header with this. The problem with the custom stuff is that there is no built in change control. And hey, maybe others will want to use it.
From the user's standpoint, I don't think this vs a reversible method really matters. This could probably be made reversible by remembering all the changes somehow, but I can't imagine why you'd want that. It's just an invitation to bugs when a refresh restores it all, guaranteed.
-
@boomzilla said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Given their response to this,
Did Ben L actually present it to them? He was just sitting on the bug last I saw.
-
@blakeyrat I thought there was some conversation on here about it.
Oh, BTW, I tested on Chrome (Linux and Android) and Firefox (Linux).
-
@boomzilla said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
I thought there was some conversation on here about it.
A billion hours' worth, but none involving NodeBB developers as far as I'm aware.
Someone (Lorne I think?) mentioned they were working on it, but it turned out they'd pulled that little nugget of information straight out of their ass and it was based on nothing.
-
@boomzilla wait... are there settings for those values somewhere? Wouldn't it make sense to just make
@screen-md
smaller than 960 (half of the 1080p display width)?@screen-lg
is the point at which it switches from a full-width column of text to a centered fixed-width column of text, which is supposed to prevent it from becoming a really wide column since really wide columns are hard to read. So having it switch from@screen-md
to@screen-lg
at some point is probably a good thing...
-
@anotherusername CSS doesn't have variables, so. If you're seeing variables, you're looking at a SASS or LESS or something file which is compiled into CSS.
All we have access to via. JavaScript is the compiled, obfuscated CSS.
-
@blakeyrat Yeah, that stuff is in less files, which get compiled to CSS.
Alternate implementations are certainly welcome.
-
@blakeyrat I'm talking about whatever code the CSS was generated from. Do we not have the ability to change the variables and recompile it?
-
@anotherusername said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Do we not have the ability to change the variables and recompile it?
We probably don't have the capability to make that happen outside of a fork that we'd have to maintain.
-
@anotherusername said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
@blakeyrat I'm talking about whatever code the CSS was generated from. Do we not have the ability to change the variables and recompile it?
Not without doing a complete fork of the project and then becoming responsible for keeping that fork up to date.
... how is it possible I know more about open source software than someone else on this forum?
The annoying thing is they wouldn't even need to install this feature in the core product if they didn't want to. They just need to add the selectors to the CSS so we can. Oh well.
-
This post is deleted!
-
@boomzilla said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
I basically went with that, plus swapped out .container for .container-fluid. Otherwise it'll get stuck wider than the window, which is probably not what people want.
Good call
@boomzilla said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Per user per browser. I've stored the setting in local storage, because you may want different behavior on different devices.
Again, good call
-
Published:
But I don't want to install it here until someone else has at least tried it out.
-
Also tested on Vivaldi!
-
It's active here now. May require a hard refresh. Also, I noticed that requires a refresh when I middle click. That is, the menu isn't there at first and the setting isn't applied.
I was using this to fire it up:
$(window).on('action:widgets.loaded', function() {
Guess that's not right? Why would middle click on a local link be different than, say, middle clicking a bookmark? Is this a browser thing? NodeBB thing?
-
Well, I figured it out, but NodeBB isn't seeing the update on npm yet. Aaaand I didn't put the change in the readme. Oops.
Ah, there it is.
-
0.4.0 is now on here, which fixes max notification height problems and also allows configuration of the notification dropdown width.
I also noticed this issue:
-
@boomzilla I love you.
-
@Lorne-Kates Hey, you never answered before when I asked about license for your code, which is the backbone of this plugin. I usually go with some sort of MIT / BSD sort of thing, but you started it.
-
@boomzilla said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
@Lorne-Kates Hey, you never answered before when I asked about license for your code, which is the backbone of this plugin. I usually go with some sort of MIT / BSD sort of thing, but you started it.
Oh. Um, whatever the most appropriate "do whatever the fuck you want with it, you owe me nothing" license is.
-
@Polygeekery To be fair, that concept on a desktop application is kind of crap.
-
@fbmac Low resolution window != low resolution device.
-
Sorry about the necro everybody. I thought the timestamps were newer from today but I think I was remembering a different thread. And then I noticed I responded to stuff from like 11-14 days ago.
-
@mikehurley said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Sorry about the necro everybody.
YMBNH, , etc.
-
@mikehurley said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
I thought the timestamps were newer from today but I think I was remembering a different thread.
There was just some activity in here. You just responded to old stuff.
-
@boomzilla He can't use an excuse like confusing "May 15" with "May '15" anymore.
-
@Lorne-Kates said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Oh. Um, whatever the most appropriate "do whatever the fuck you want with it, you owe me nothing" license is.
You could use a "fuck you, give me money" license.
-
@Lorne-Kates said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Oh. Um, whatever the most appropriate "do whatever the fuck you want with it, you owe me nothing" license is.
That's pretty close to what the MIT/BSD license is.
-
@dkf said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
@Lorne-Kates said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Oh. Um, whatever the most appropriate "do whatever the fuck you want with it, you owe me nothing" license is.
That's pretty close to what the MIT/BSD license is.
Then I'll fork it and call it the "Lorne says you can use this code, whatever" license.
-
@Lorne-Kates said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
Oh. Um, whatever the most appropriate "do whatever the fuck you want with it, you owe me nothing" license is.
-
I'm actually impressed at how nice that OneBox turned out...
Filed Under: Color me
-
@M_Adams said in Dear blakeyrat. I fixed the css. Signed The Desktop View:
I'm actually impressed at how nice that OneBox turned out...
Filed Under: Color me
Yes, OneBoxes that cut off in the middle of a sentence are really fucking impressive.