Custom homepage broken?

boomzilla

I have mine set to category/4/staff which makes it easy for me to get there when I want to.

Going there via url or by the categories page works fine, but otherwise I get this:

EDIT: amusingly, clicking on the link gives the same result.

hungrier

@boomzilla We definitely need an emergency update for this, but only if it also includes the :900_dollary_doos: emoji that's been sitting in a PR for a while

ben_lubar

test link to /category/4/staff

ben_lubar

@boomzilla hmm, that works so I'm gonna guess it's not a tdwtf-specific problem

/cc @julianlam @barisu

boomzilla

@ben_lubar yeah, that link works, too. This one breaks, though:

https://what.thedailywtf.com/

boomzilla

@ben_lubar said in Custom homepage broken?:

@boomzilla hmm, that works so I'm gonna guess it's not a tdwtf-specific problem

/cc @julianlam @barisu

Actually, come to think of it, I was seeing this in my dev environment where I have a more vanilla install that doesn't have all of our custom stuff. I assumed it was something weird about my setup and didn't really worry about it.

boomzilla

@ben_lubar said in Custom homepage broken?:

@boomzilla hmm, that works so I'm gonna guess it's not a tdwtf-specific problem

/cc @julianlam @barisu

Yep, I get the same thing on community.nodebb.org:

ben_lubar

@boomzilla said in Custom homepage broken?:

@ben_lubar yeah, that link works, too. This one breaks, though:

https://what.thedailywtf.com/

I was just curious because I know NodeBB likes to be sneaky with internal links.

PleegWat

I am not getting the problem. Mine is set to /unread.

Tsaukpaetra

Interestingly enough, the dropdown thing (that essentially just sets the custom box to a particular string) does work to set the string, but also does not work in the same way.

After saving (and reloading):

Curiously, when it works, this is the response:

When it doesn't (keep in mind both are attempted straight from the settings page):

The one that don't work is missing that x-upstream header...

JBert

@levicki From your screenshot it would seem that they forgot to unescape the / characters in the custom URL (or escaped it one too many times) before passing it off to the code which tries to find the right page.

So far everything has kept working for me, but then I set it to unread which doesn't contain any special characters.

boomzilla

@levicki said in Custom homepage broken?:

Navigation to https://what.thedailywtf.com/ is now broken as well, I am getting 404:

Yes, when you're logged in navigating to the basic URL goes to whatever you've set as your homepage.

boomzilla

Since none of the nodebb devs showed up:

Custom homepage route broken · Issue #8168 · NodeBB/NodeBB

NodeBB version: Whatever's on community.nodebb.org February 18th, 2020 NodeBB git hash: Exact steps to cause this issue: Set my custom homepage: What you expected: Using community.nodebb.org I ...

JBert

@levicki said in Custom homepage broken?:

@JBert That may be the case for the custom URL but not for this, what you get when you click on the link @boomzilla and I posted?

My setting:

Surfing to https://what.thedailywtf.com/ just shows unread topics, like I said I don't get an error.

boomzilla

@JBert said in Custom homepage broken?:

@levicki said in Custom homepage broken?:

@JBert That may be the case for the custom URL but not for this, what you get when you click on the link @boomzilla and I posted?

My setting:

Surfing to https://what.thedailywtf.com/ just shows unread topics, like I said I don't get an error.

Oh, I notice that they added categories to the dropdown! Let's try that:

New error!

LB_

Seems slashes may be the issue? This has been working fine for me, I actually thought it was /unread/new but I forgot they had changed it:

boomzilla

@LB_ said in Custom homepage broken?:

Seems slashes may be the issue?

Yep:

- settings.homePageRoute = validator.escape(String(settings.homePageRoute || ''));
+ settings.homePageRoute = validator.escape(String(settings.homePageRoute || '')).replace('&#x2F;', '/');

Tsaukpaetra

@JBert said in Custom homepage broken?:

like I said I don't get an error.

It's already been mentioned, we don't really need proof that what's working is working.

Tsaukpaetra

@boomzilla said in Custom homepage broken?:

@LB_ said in Custom homepage broken?:

Seems slashes may be the issue?

Yep:

- settings.homePageRoute = validator.escape(String(settings.homePageRoute || ''));
+ settings.homePageRoute = validator.escape(String(settings.homePageRoute || '')).replace('&#x2F;', '/');

I was wondering why it now says you're supposed to not include the slash. Now I know they shoddily enforce it.

HardwareGeek

@PleegWat said in Custom homepage broken?:

I am not getting the problem. Mine is set to /unread.

Isn't /unread the default? I wouldn't expect weird behavior on that. Well, weirder than 's usual behavior, anyway.

boomzilla

@levicki said in Custom homepage broken?:

Any idea when a fix for this will land? It's really annoying.

You could ask over at community.nodebb.org. It's been 26 days since 1.13.2 was released. 1.13.1 was released mid-December and 1.13.0 in November. So...probably soon?

Releases · NodeBB/NodeBB

Node.js based forum software built for the modern web - NodeBB/NodeBB

Luhmann

@levicki said in Custom homepage broken?:

it's driving me mad.

I thought that was your default state?

dkf

@levicki Don't use an unsigned char for that next time.

topspin

@dkf said in Custom homepage broken?:

@levicki Don't use an unsigned char for that next time.

Sounds more like unsigned bool to me.

Tsaukpaetra

@topspin said in Custom homepage broken?:

@dkf said in Custom homepage broken?:

@levicki Don't use an unsigned char for that next time.

Sounds more like unsigned bool to me.

Nice.

Tsaukpaetra

@levicki said in Custom homepage broken?:

Guys, can someone log in to the FTP or whatever you use to maintain the forum software and edit the problematic line manually until we get a proper update?

It's been weeks.

I think technically PRs are accepted. Could submit a thing that does it or whatever.