Name generation done right

NeighborhoodButcher

Those of us familiar with Docker know it generates random two-word names for running containers, if you don't provide them yourself. This is a nice feature to have, since you don't need to bother with unpronounceable hash identifiers. Until one day you have to tell your customer to stop "amazing_cocks". Good show, Docker. Good show.

PJH

'Cocks' isn't one of the variations in the current version of docker - how old is it?

moby/pkg/namesgenerator/names-generator.go at master · moby/moby

The Moby Project - a collaborative project for the container ecosystem to assemble container-based systems - moby/moby

NeighborhoodButcher

@PJH 18.06, I think. Windows server version.

hungrier

@PJH Not too old, this commit from Dec 23, 2018 is where they replaced it.

Also,

  // Emmett Brown invented time travel. https://en.wikipedia.org/wiki/Emmett_Brown (thanks Brian Goff)
  "brown",

PleegWat

@hungrier said in Name generation done right:

@PJH Not too old, this commit from Dec 23, 2018 is where they replaced it.

Replaces cocks with cerf as the former might be perceived as
offensive by some people

Might?

hungrier

Also, there's this

	if name == "boring_wozniak" /* Steve Wozniak is not boring */ {
		goto begin
	}

boomzilla

@hungrier said in Name generation done right:

Also, there's this

	if name == "boring_wozniak" /* Steve Wozniak is not boring */ {
		goto begin
	}

Duh. That's one of Elon's outfits.

Gąska

@hungrier If this was C code:

	if (name == "boring_wozniak") /* Steve Wozniak is not boring */ 
		goto begin;
		goto begin;

PleegWat

@Gąska I assume you are aware that if statement is (probably) always false?

MrL

	if name == "boring_wozniak" /* Steve Wozniak is not boring */ {
		goto begin
	}

goto
goto
goto
goto
goto?

PJH

@Gąska said in Name generation done right:

@hungrier If this was Apple C code:

	if (name == "boring_wozniak") /* Steve Wozniak is not boring */ 
		goto begin;
		goto begin;

dcon

@MrL I just "fixed" some code that looked like:

    ...
    switch (val) {
    case IDC_MENUITEM1: val = realVal1; goto more;
    case IDC_MENUITEM2: val = realVal2; goto more;
    ...
    case IDC_MENUITEM6; val = realVal6;
more: DoThing(val);
    break;
    }

Yes. That's what the formatting looked like. Your image is appreciated.

After fixing, it looked kinda like:

    ...
    int v = 0;
    switch (val) {
    case IDC_MENUITEM1: v = realVal1; break;
    case IDC_MENUITEM2: v = realVal2; break;
    ...
    case IDC_MENUITEM6; v = realVal6; break;
    }
    if (v)
        DoThing(v);

izzion

@dcon
Hopefully you also fixed the original programmer, so as (s)he cannot further dilute the gene pool

dcon

@izzion said in Name generation done right:

@dcon
Hopefully you also fixed the original programmer, so as (s)he cannot further dilute the gene pool

I'm pretty sure that's some contractor thing from before my time. And I've been here almost 6 yrs... (that whole module uses coding styles that simply do not match the rest of the code base)