Poll: Are polls broken?
-
- Yes
- Also yes
- NO_NOT_FOUND
-
It also affects older polls:
-
@VinDuv - Days Since Last Discourse Bug: 0
-
-
-
@eviltrout said:
changed 48 files
with 417 additions
and 436 deletions.
That's a good sign.
-
-
Moving to Bugs...
-
http://what.thedailywtf.com/t/your-is-showing/5339/75?u=pjh
(Nice. A link instead of the text, so I can't make it smaller and user-friendly - you know furthering "discourse". Sigh.)
Any how, glad he's having fun, I suppose.
Glad Sam and trout can buy groceries and a roof over their heads.
Filed under: whistling all the way to the bank.
-
-
upvoted.
-
VinDuv found this code on the github repository of a fairly popular discussion forum. It's called whenever a 'poll' thread (yes, no, POLL_NOT_FOUND) is selected by the user.
The main focus of this code is to display a poll, allow the user to respond, and show several more posts in the thread. Once it has done that, it hands off to another function to make an AJAX request to load more posts as the user scrolls down.
Sounds simple, right? Well, it is, assuming you've ever heard of basic HTML concepts like tables, divs and displaying options as a set of radio buttons. However, if you haven't, your code might not display anything at all.
Here's to hoping that at least their server-side stuff isn't hard-coded to return the entire thread in json whenever requesting a single slice of posts...
Filed under: low effort parody
-
Here's to hoping that at least their server-side stuff isn't hard-coded to return the entire thread in json whenever requesting a single slice of posts...
unless they changed it recently it isn't. would have made @sockbot's job easier for full thread scans.
-
Yes mistress Commander @Accalia Shepard, I shall appear as summoned.
-
I thought I read that it was doing something like that. Maybe it was just the metadata for the entire thread? I dunno, like I said it was low-effort.
-
it sends a lot of things.....
-
What's the problem exactly?
-
This is the problem:
-
No repro. You must be doing it wrong
-
What's the problem exactly?
The problem is that U+1F315 FULL MOON SYMBOL looks like a square on your screenshot. You should install better fonts.More seriously, I have no idea why it works for you. Even after a page reload I still get this:
-
Perhaps he hasn't refreshed and is still on yesterday's version of Discourse? I tried CtrlShiftR to make sure it wasn't Hanzofixed, and the problem is still there.
-
Perhaps he hasn't refreshed and is still on yesterday's version of Discourse?
That may be it. Had the tab closed for a while and now I've lost the poll. Hooray for Discoursistency
-
-
- {{#each po poll.options}} + {{#each po in poll.options}}
I guess Handlebars doesn’t do much syntax checking?
EDIT: And why does syntax highlighting of diffs only work in the preview?
EDIT2: Oh, so it works for a fraction of second when I post, then it stops working, and then it starts working after a refresh.
-
It's the same shit I was doing. Ember has deprecated this
{{#each items}} <strong>{{id}}</strong> {{name}} {{/each}}
in favor of this
{{#each item in items}} <strong>{{item.id}}</strong> {{item.name}} {{/each}}
It's a fucking nightmare to refactor, because you often have references to multiple sources, not to mention "magic" references buried inside strings. Example:
{{#each items}} <tr {{bind-attr class="isSelected:success:default :table-row tableRowStyle"}}> <td>{{index}} / {{total}}</td> <td>{{id}} - {{name}}</td> <td>{{helpText}}</td> </tr> {{/each}}
So where does each of these placeholders bind to? It's not clear at all, it could be
this
(current element ofitems
) orcontroller
ormodel
. In fact, if we wrote full paths to everything, using zero magic, we'd refactor to this:{{#each item in controller.model.items}} <tr {{bind-attr class="item.isSelected:success:default :table-row controller.tableRowStyle"}}> <td>{{item.index}} / {{controller.model.total}}</td> <td>{{item.id}} - {{item.name}}</td> <td>{{controller.helpText}}</td> </tr> {{/each}}
We are not going that far, because that'd be too verbose. But see how tricky this is? @eviltrout probably made some mistakes while refactoring. Used
{{item.x}}
in one place and left{{x}}
in other. I fully expect to have made similar mistakes in my own refactoring.Hopefully things are at least a bit clearer with this new "best practice".
-
Oh, so it works for a fraction of second when I post, then it stops working, and then it starts working after a refresh.
Rebake the rebake after you rebake but before you rebake. And then rebake again, just to be sure.
-
-
We are not going that far, because that'd be too verbose. But see how tricky this is? @eviltrout probably made some mistakes while refactoring. Used {{item.x}} in one place and left {{x}} in other. I fully expect to have made similar mistakes in my own refactoring.
This is exactly what happened. Honestly changing the scope with
each
was always a bad idea so I was okay with biting the bullet, but I had to upgrade dozens of templates to fix the deprecations. It was error prone and I knew a bunch of errors were likely to pop up, hence the topic on meta warning people who are following master.
-
THEY'RE BACK
-
Holy shit, checkbox polls that aren't obviously checkbox polls so you don't actually know to vote multiple times
[poll type=multiple]
- This is a cool feature
- WTF is there no documentation to say you need to put type=multiple
- Why is this not stylized differently
- RIP Thunder Road
- Checkbox
[/poll]
Also Status: RIP Thunder Road I need to go to Carowinds to ride it before they close it. They really need to run one of the trains backward again, that was the best part.
-
you don't actually know to vote multiple times
You may choose up to 5 options.
-
Do your stupid as testing of moron features somewhere else. In a topic I have ignored preferably.
-
Ok, Mr. Pedantic, at first glance which of these polls are checkbox polls
[poll name=1]
- Option 1
- Option 2
[/poll]
[poll name=2]
- Option 1
- Option 2
[/poll]
[poll name=3]
- Option 1
- Option 2
[/poll]
[poll name=4]
- Option 1
- Option 2
[/poll]
[poll name=5 type=multiple]
- Option 1
- Option 2
[/poll]
[poll name=6]
- Option 1
- Option 2
[/poll]
[poll name=7]
- Option 1
- Option 2
[/poll]
[poll name=8]
- Option 1
- Option 2
[/poll]
[poll name=9 type=multiple max=1]
- Option 1
- Option 2
[/poll]
It's a pretty poor comparison, because the text sticks out like a sore thumb with multiple ones in a series
-
The one with the Vote Now button.
-
lol, I thought it did, but it took a second to update.
-
Discourse handles multiple max=1 correctly
True. But it also allows
max=0
,min
to be higher thanmax
andmin
to be set higher than the amount of poll option.
-
Ooh, new error.
-
Actually it doesn't. Multiple max=1 should just ignore both attributes and show a regular poll, which I thought it did, but it didn't.
-
That's because I killed the poll while you were voting.
-
That's because I killed the poll while you were voting.
Which, cleverly, Discourse doesn't show.
-
It does now I've refreshed. I'll play with that bug later.
-
Also Status: RIP Thunder Road I need to go to Carowinds to ride it before they close it. They really need to run one of the trains backward again, that was the best part.
But yeah, this again. I also forgot that they must have spent millions over the past several years renovating the ride and replacing old wood.
-
http://what.thedailywtf.com/t/status-whatever-happened-to-ssds/1673/19643?u=wukl
So that's possible too.EDIT: that doesn't look right, does anyone else see 1 voter in the actual post?
-
-
EDIT: that doesn't look right, does anyone else see 1 voter in the actual post?
Yeah - I see "1 voter"
-
Awesome
Breakpoint in the poll script, click vote, then setthis.min = 1
.